From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0BF1137743 for ; Tue, 9 Apr 2024 15:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712675589; cv=none; b=EnqB1sr8yNIvkwaxRC4ndZnxONMDK8CZGQPEloE0tG8HvNh/L35611kjEn+PuzDflokbagH2O73MjWeQ+MD5GEBshKpbg/A6Yp1VSwg0DyVbsQDT7nOs8hA55lypi1vxKtgfLRqBRvkscvtcuY1IygTrWhpsjdUn0SpQSd0WtiQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712675589; c=relaxed/simple; bh=svXoUn7pJbodvM/2XilyJXI5NmN/Wi+8SzXisEBwYbw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MvAGuWieK+bsCesJzMOfIReDHEDoTad7jhh7QBwHfIEmf38LLPyP45MkUMWJELoZ/3C+ZOM3Z1Xrvn+1ARuf0o5UKsU60t6c5DusktYZSJzunuZMnoR+hRcQwXC3cuBAL7esFhTgsdxZGc9bEQmgNW5RAVOb2wQjjbao+Amk7Tw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cD5k3yge; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cD5k3yge" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-516f2e0edb7so3109066e87.1 for ; Tue, 09 Apr 2024 08:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712675586; x=1713280386; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MDKIxls1YcB1qEzw3C9K5gDjPIzcv/YgHt6CoWlWLcc=; b=cD5k3yge+H1z+kuZkwHTJYRgDd7G+ZeNpUcdBSEB942uetxRq6dIQVihdKKtMaLv9t KMuti7oaHMypkAQ3vPdtR0+9CR15v+r0RuFU6Q2ys1asPVdXx/V0p1JM/H9NyY/hbjD9 xaXo1K/R67WTPZZ1yZoPFCqAmgvyFFwr7KS8r4JPaaOsMPM3CAKH98acD6w9Iah23ouQ L9jlVkkvxrR7zs5H0qlgbNr9QL/3x9i9CnVB7rL/X4l3E2FAeIk+4v3au+VpedwVSElA yxtOVQiIdUMA4bPR3A0ZVz5Co7b1BOJY2Ie5QK3wMp624YI0c4I1HYfRL0mekG0FZ7uM h+9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712675586; x=1713280386; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MDKIxls1YcB1qEzw3C9K5gDjPIzcv/YgHt6CoWlWLcc=; b=lZKDxNk9nNWT3rctmez7lB6FGRgiqjxt6aUWFh6ZJX0eFC4vFpSKyw68LGR7pyn1xr /xrMdVUk3vdNBeT2DlDkU7ZQ/AKqs/VzwpSSCtmnn4euzCh/02WTs8kiaz4XOhjaKKmm oeRS7Gr093vI6qUAIovl/A71R60DX1xSU3kDzOlN6WDYT6B/xLjk4dHne13onmIPgXgk D2hjEvF7/AVSjDrJoCdt+tfhN0TZCTGtz/sx4/ooUBkll9g4anp1nvNB0IvuC/59fuAB ui4k2ZY/TfNnvyd1aoHeslDTYn+oLB79C7RDCRQW84K6HPY4iGzaMN6h0UNKUlrxGIHX eGsQ== X-Forwarded-Encrypted: i=1; AJvYcCUxLsMYphO3F/ia3/erjOzDSbB6OyEsvoOF4ULqogUFs/OHrv1W1GWKKAR+UskDzNafCOXa3NBkc8uBrbfiKWMsmm6OurneGZbErU5W X-Gm-Message-State: AOJu0Yx9rZX6uYU98DIhdxRgbD5woHKX2XCnNdRtdvgHA5SU7bTFORUe r9UfFbjh7w4MkQOsrrSoK3Kw5MZ9U1D5lUMKw2JnP8+7mG47UggR82zc1aRu8i4= X-Google-Smtp-Source: AGHT+IGhk42UgX0piJ3IhGVv53mL8Xv3MlZAlkmhqiALnY/XM/pfqByw6e+NvkM8SZnf8BoJDnWAbw== X-Received: by 2002:a19:8c5d:0:b0:515:93ef:98ae with SMTP id i29-20020a198c5d000000b0051593ef98aemr8314023lfj.54.1712675585961; Tue, 09 Apr 2024 08:13:05 -0700 (PDT) Received: from [172.30.205.99] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id f9-20020a193809000000b00516aff23fc1sm1610227lfa.138.2024.04.09.08.12.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Apr 2024 08:12:59 -0700 (PDT) Message-ID: Date: Tue, 9 Apr 2024 17:12:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value To: Dmitry Baryshkov Cc: Bjorn Andersson , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, Neil Armstrong References: <20240405-topic-smem_speedbin-v1-0-ce2b864251b1@linaro.org> <20240405-topic-smem_speedbin-v1-3-ce2b864251b1@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/6/24 04:56, Dmitry Baryshkov wrote: > On Fri, Apr 05, 2024 at 10:41:31AM +0200, Konrad Dybcio wrote: >> From: Neil Armstrong >> >> Usually, speedbin 0 is the "super SKU", a.k.a the one which can clock >> the highest. Falling back to it when things go wrong is largely >> suboptimal, as more often than not, the top frequencies are not >> supposed to work on other bins. > > Isn't it better to just return an error here instead of trying to guess > which speedbin to use? Not sure. I'd rather better compatibility for e.g. booting up a new laptop with just dt. > > If that's not the case, I think the commit should be expanded with > actually setting default_speedbin for the existing GPUs. I think that should be addressed, although separately. Konrad