From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C53FA3743 for ; Tue, 1 Nov 2022 11:16:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbiKALQ1 convert rfc822-to-8bit (ORCPT ); Tue, 1 Nov 2022 07:16:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbiKALQX (ORCPT ); Tue, 1 Nov 2022 07:16:23 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BED6186C9 for ; Tue, 1 Nov 2022 04:16:22 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-148-T16JRegdN2KCP6Vv8a13JA-1; Tue, 01 Nov 2022 11:16:19 +0000 X-MC-Unique: T16JRegdN2KCP6Vv8a13JA-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 1 Nov 2022 11:16:17 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.042; Tue, 1 Nov 2022 11:16:17 +0000 From: David Laight To: 'Bo Liu' , "pbonzini@redhat.com" CC: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] KVM: replace ternary operator with min() Thread-Topic: [PATCH] KVM: replace ternary operator with min() Thread-Index: AQHY7cMaIkkRYJlAy0yMrTd+ywOc6K4p6rBQ Date: Tue, 1 Nov 2022 11:16:17 +0000 Message-ID: References: <20221101072513.7364-1-liubo03@inspur.com> In-Reply-To: <20221101072513.7364-1-liubo03@inspur.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bo Liu > Sent: 01 November 2022 07:25 > > Fix the following coccicheck warning: > > virt/kvm/kvm_main.c:5289:10-11: WARNING opportunity for min() ... > - return r < 0 ? r : 0; > + return min(r, 0); As has been repeatedly pointer out this is bogus. min() should only be used for 'sizes'. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)