From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Peter Chen <Peter.Chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2] usb: chipidea: Grab the (legacy) USB PHY by phandle first
Date: Thu, 31 Jan 2019 10:47:52 +0300 [thread overview]
Message-ID: <d8a66e38-ad7d-a919-905f-8bbbff1d7425@cogentembedded.com> (raw)
In-Reply-To: <20190130163011.26437-1-paul.kocialkowski@bootlin.com>
Hello!
On 30.01.2019 19:30, Paul Kocialkowski wrote:
> According to the chipidea driver bindings, the USB PHY is specified via
> the "phys" phandle node. However, this only takes effect for USB PHYs
> that use the common PHY framework. For legacy USB PHYs, a simple lookup
> based on the USB PHY type is done instead.
>
> This does not play out well when more than USB PHY is registered, since
More than one?
> the first registered PHY matching the type will always be returned
> regardless of what the driver was bound to.
>
> Fix this by looking up the PHY based on the "phys" phandle node.
> Although generic PHYS and rather matched by their "phys-name" and not
> the "phys" phandle directly, there is no helper for similar lookup on
> legacy PHYs and it's probably not worth the effort to add it.
>
> When no legacy USB PHY is found by phandle, fallback to grabbing any
> registered USB2 PHY. This ensures backward compatibility if some users
> were actually relying on this mechanism.
>
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2019-01-31 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 16:30 Paul Kocialkowski
2019-01-31 7:47 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8a66e38-ad7d-a919-905f-8bbbff1d7425@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Peter.Chen@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®