From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754890AbdGVAFn (ORCPT ); Fri, 21 Jul 2017 20:05:43 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26184 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753684AbdGVAFm (ORCPT ); Fri, 21 Jul 2017 20:05:42 -0400 Subject: Re: [PATCH] mm/hugetlb: __get_user_pages ignores certain follow_hugetlb_page errors To: Punit Agrawal Cc: linux-mm@kvack.org, aarcange@redhat.com, akpm@linux-foundation.org, aneesh.kumar@linux.vnet.ibm.com, gerald.schaefer@de.ibm.com, james.morse@arm.com, kirill.shutemov@linux.intel.com, mhocko@suse.com, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, zhongjiang@huawei.com, linux-kernel@vger.kernel.org References: <1500406795-58462-1-git-send-email-daniel.m.jordan@oracle.com> <87o9sekux9.fsf@e105922-lin.cambridge.arm.com> From: Daniel Jordan Message-ID: Date: Fri, 21 Jul 2017 20:05:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <87o9sekux9.fsf@e105922-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Punit, On 07/21/2017 05:20 AM, Punit Agrawal wrote: > The change makes sense. > FWIW, > > Acked-by: Punit Agrawal Thanks, I appreciate that. > I was wondering how you hit the issue. Is there a test case that could > have spotted this earlier? This was actually just by inspection. I checked selftests/vm, but there's nothing in there that would have come close to spotting this, so unfortunately there's no existing test case. Thanks, Daniel