From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Cc: vivien.didelot@gmail.com, davem@davemloft.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linus.walleij@linaro.org, georg.waibel@sensor-technik.de
Subject: Re: [PATCH net-next 16/17] Documentation: networking: dsa: Add details about NXP SJA1105 driver
Date: Wed, 3 Apr 2019 08:07:24 -0700 [thread overview]
Message-ID: <d8af0493-064a-2ef7-722c-79d1ac8cb6c7@gmail.com> (raw)
In-Reply-To: <47131b09-8f39-0cdc-70cd-809b64448097@gmail.com>
On 4/3/2019 3:09 AM, Vladimir Oltean wrote:
> On 4/3/19 12:24 AM, Andrew Lunn wrote:
>>> +The switches do not support switch tagging in hardware. But they do
>>> support
>>> +customizing the TPID by which VLAN traffic is identified as such.
>>> The switch
>>> +driver is leveraging CONFIG_NET_DSA_TAG_8021Q by requesting that
>>> special VLANs
>>> +(with a custom TPID of ETH_P_EDSA instead of ETH_P_8021Q)
>>
>> Hi Vladimir
>>
>> Reusing ETH_P_EDSA is possibility going to case problems in tcpdump.
>> It has code which looks for this Ethertype and uses it to call the
>> Marvell EDSA header decoder code. This is not going to work for your
>> switch, where you have a normal VLAN header.
>>
>> I wounder if we should allocate a new EtherType for this application
>> of VLANs?
>>
>> Andrew
>>
>
> Hi Andrew,
>
> This makes me wonder whether I would be able to use an EtherType range
> to support cascading switch tags on SJA1105.
> In theory if I were to consistently lie to all switches within a switch
> tree, I could make all of them see each other's fake VLAN-tagged traffic
> as untagged.
> By the way what is the simple ETH_P_DSA used for?
ETH_P_DSA is not used since commit
3e8a72d1dae374cf6fc1dba97cec663585845ff9 ("net: dsa: reduce number of
protocol hooks") but since it is in an UAPI exported file we probably
cannot remove it.
--
Florian
next prev parent reply other threads:[~2019-04-03 15:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 17:42 [PATCH net-next 00/17] NXP SJA1105 DSA driver Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 01/17] lib: Add support for generic packing operations Vladimir Oltean
2019-04-04 9:19 ` Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 02/17] net: dsa: Fix pharse -> phase typo Vladimir Oltean
2019-04-02 20:45 ` Andrew Lunn
2019-03-31 17:42 ` [PATCH net-next 03/17] net: dsa: Store vlan_filtering as a property of dsa_port Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 04/17] net: dsa: mt7530: Use vlan_filtering property from dsa_port Vladimir Oltean
2019-04-02 20:47 ` Andrew Lunn
2019-03-31 17:42 ` [PATCH net-next 05/17] net: dsa: Add more convenient functions for installing port VLANs Vladimir Oltean
2019-04-02 20:54 ` Andrew Lunn
2019-03-31 17:42 ` [PATCH net-next 06/17] net: dsa: Call driver's setup callback after setting up its switchdev notifier Vladimir Oltean
2019-04-02 21:03 ` Andrew Lunn
2019-04-03 9:58 ` Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 07/17] net: dsa: Optional VLAN-based port separation for switches without tagging Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 08/17] net: dsa: Be aware of switches where VLAN filtering is a global setting Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 09/17] net: dsa: b53: Let DSA handle mismatched VLAN filtering settings Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 10/17] net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch Vladimir Oltean
2019-04-02 21:55 ` Andrew Lunn
2019-03-31 17:42 ` [PATCH net-next 11/17] net: dsa: sja1105: Add support for FDB and MDB management Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 12/17] net: dsa: sja1105: Add support for VLAN operations Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 13/17] net: dsa: sja1105: Add support for ethtool port counters Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 14/17] net: dsa: sja1105: Add support for traffic through standalone ports Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 15/17] net: dsa: sja1105: Add support for Spanning Tree Protocol Vladimir Oltean
2019-03-31 17:42 ` [PATCH net-next 16/17] Documentation: networking: dsa: Add details about NXP SJA1105 driver Vladimir Oltean
2019-04-02 21:24 ` Andrew Lunn
2019-04-03 10:09 ` Vladimir Oltean
2019-04-03 15:07 ` Florian Fainelli [this message]
2019-03-31 17:42 ` [PATCH net-next 17/17] dt-bindings: net: dsa: Add documentation for " Vladimir Oltean
2019-04-02 21:38 ` Andrew Lunn
2019-04-03 9:53 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8af0493-064a-2ef7-722c-79d1ac8cb6c7@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=georg.waibel@sensor-technik.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome