From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA32C77B75 for ; Wed, 17 May 2023 14:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232152AbjEQOsk (ORCPT ); Wed, 17 May 2023 10:48:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjEQOsi (ORCPT ); Wed, 17 May 2023 10:48:38 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99CF240C0 for ; Wed, 17 May 2023 07:48:36 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-510d9218506so162688a12.1 for ; Wed, 17 May 2023 07:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684334915; x=1686926915; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=elvq0HJ66cNTWAPxUlVMN+GA2+ufgNIYZmKlf1bKE8k=; b=jmxWX2Hqep6vnItCfquyL4U0/eXi1cZdZsjpxkc1mZ8b0gd9rHAG0PWwAF9MTFi032 dFnf3vhPW4W7KF3nmL36359po+98NHdO7P72IyggzX2g+z5qBZ2WUFt7DyVEs6OfyJtG uXvZL0ZoWSM0wxX5nkvM+spVf6bTID6yhMXs3lLsE7r0HcVoUEIHvMAwIreOvSFPFp7q e45BhCbAqJszQd6nFsfu7D0xQrRvgXsuKC+O9Rog7D38WESf/XyxcMhozRi+PTMV2S/c tAxMVehKJ19ocmLDMZxZ6kZp/vjvp10QwatUHMen9Yx5XDp09mJom+0OjuDWArXVwptw nR+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684334915; x=1686926915; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=elvq0HJ66cNTWAPxUlVMN+GA2+ufgNIYZmKlf1bKE8k=; b=fpQ8EHjoq5kySIGN5rfwVQBqXOqrw4VOZxaorKu1Eu5JZtvc77d/zg5XMw9GuXssj2 ok/LP0stQLXwFa+xti5PioutALwOhOSAfbQ/u+GrfNoU99Y1kcNO7lixgp1jzg9z0oeo ZmEBJmfA6RG/izpbfXyH7bXhL8BiosmpbJ5NR26cLuJwcHQYOrRN4soRxuI27eINAbPC 8q+/fF/KJfvE90WHoWNCTaMk1basN+QEtiCQkPeMSMppYx3WTo2lG8p8SACwseMIXTOh ofp4/gOVEpF3Nr/FqsmagDslb4/wu582SEvWHiI7DvHJ9feZiwLPVr+8Oq1h8b0R1q5x 8wkg== X-Gm-Message-State: AC+VfDx0TyVgI7JtwGy1WFhYCjKkuNt88ZoL6FCSDhDVYNtZNzSfctgs i6WhUvCDgY1cE2pbxlrdpevlag== X-Google-Smtp-Source: ACHHUZ7u2N7bCmDcp4Y15qBMsgz6bSdlw0qZZSEJUJZGSKF0JWiEAQtQGmDA7ZrNlC5N0a2zBmn3kw== X-Received: by 2002:a05:6402:35c2:b0:4fc:97d9:18ec with SMTP id z2-20020a05640235c200b004fc97d918ecmr2062220edc.21.1684334915088; Wed, 17 May 2023 07:48:35 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:c9ff:4c84:dd21:568d? ([2a02:810d:15c0:828:c9ff:4c84:dd21:568d]) by smtp.gmail.com with ESMTPSA id s13-20020aa7c54d000000b00506b2af49fbsm9257750edr.81.2023.05.17.07.48.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 07:48:34 -0700 (PDT) Message-ID: Date: Wed, 17 May 2023 16:48:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net-next V3 1/3] dt-bindings: net: xilinx_axienet: Introduce dmaengine binding support Content-Language: en-US To: "Gaddam, Sarath Babu Naidu" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "linux@armlinux.org.uk" , "Simek, Michal" , "Pandey, Radhey Shyam" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Sarangi, Anirudha" , "Katakam, Harini" , "git (AMD-Xilinx)" References: <20230510085031.1116327-1-sarath.babu.naidu.gaddam@amd.com> <20230510085031.1116327-2-sarath.babu.naidu.gaddam@amd.com> <95f61847-2ec3-a4e0-d277-5d68836f66cf@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/2023 14:06, Gaddam, Sarath Babu Naidu wrote: >>>>> + dma-names: >>>>> + items: >>>>> + - const: tx_chan0 >>>> >>>> tx >>>> >>>>> + - const: rx_chan0 >>>> >>>> rx >>> >>> We want to support more channels in the future, currently we support >>> AXI DMA which has only one tx and rx channel. In future we want to >>> extend support for multichannel DMA (MCDMA) which has 16 TX and >>> 16 RX channels. To uniquely identify each channel, we are using chan >>> suffix. Depending on the usecase AXI ethernet driver can request any >>> combination of multichannel DMA channels. >>> >>> dma-names = tx_chan0, tx_chan1, rx_chan0, rx_chan1; >>> >>> will update the commit message with same. >> >> I expect the binding to be complete, otherwise you get comments like this. >> Add missing parts to the binding and resend. > > Binding is complete for current supported DMA (single channel). We will > extend when we add MCDMA. What doe sit mean "current supported DMA"? By driver? or by hardware? If the former, then how does it matter for the bindings? If the latter, then your hardware is going to change? Then you will have different set of compatibles and then can use different names. > > We will describe the reason for using channel suffix in the description as > below. > > dma-names: > items: > - const: tx_chan0 > - const: rx_chan0 > description: | > Chan suffix is used for identifying each channel uniquely. > Current DMA has only one Tx and Rx channel but it will be > extended to support for multichannel DMA (MCDMA) which > has 16 TX and 16 RX channels. Depending on the usecase AXI > ethernet driver can request any combination of multichannel > DMA channels. No, because I don't understand what is "will be extended". Bindings should be complete. If they are going to be extended, it means they are not complete. If they cannot be complete, which happens, please provide a reason. There was no reason so far, except your claim it is complete. Best regards, Krzysztof