From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: tsbogend@alpha.franken.de, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, keescook@chromium.org,
hns@goldelico.com, ebiederm@xmission.com,
dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com,
rick.tyliu@ingenic.com, yanfei.li@ingenic.com,
sernia.zhou@foxmail.com, zhenwenjin@gmail.com
Subject: Re: [PATCH] MIPS: CI20: Update defconfig for EFUSE.
Date: Fri, 7 Aug 2020 23:55:18 +0800 [thread overview]
Message-ID: <d8b28bac-8995-23db-816e-31ba1f8d02f3@wanyeetech.com> (raw)
In-Reply-To: <PIR6EQ.G22CDHRT7D5O@crapouillou.net>
Hi Paul,
在 2020/7/28 下午11:40, Paul Cercueil 写道:
> Hi Zhou,
>
> Le sam. 25 juil. 2020 à 16:02, Zhou Yanjie <zhouyanjie@wanyeetech.com>
> a écrit :
>> Hi Paul,
>>
>> 在 2020/7/23 下午4:47, Paul Cercueil 写道:
>>> Hi Zhou,
>>>
>>> Le jeu. 23 juil. 2020 à 15:19, 周琰杰 (Zhou Yanjie)
>>> \x7f<zhouyanjie@wanyeetech.com> a écrit :
>>>> The commit 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>>>> controller use NVMEM to find the default MAC address") add EFUSE
>>>> node for DM9000 in CI20, however, the EFUSE driver is not selected,
>>>> which will cause the DM9000 to fail to read the MAC address from
>>>> EFUSE, causing the following issue:
>>>>
>>>> [FAILED] Failed to start Raise network interfaces.
>>>>
>>>> Fix this problem by select CONFIG_JZ4780_EFUSE by default in the
>>>> ci20_defconfig.
>>>
>>> Does it actually fix it on a clean 5.8-rc kernel?
>>>
>>> From what I know, the efuse driver cannot probe, because the nemc
>>> \x7fdriver requests the complete memory resource, so the efuse driver's
>>> \x7fdevm_platform_ioremap_resource() fails.
>>>
>>> I did send a patch to fix this
>>> \x7f(https://lore.kernel.org/lkml/551a8560261543c1decb1d4d1671ec4b7fa52fdb.1582905653.git.hns@goldelico.com/),
>>> but it's hard to have somebody merge it, because nobody maintains
>>> \x7fdrivers/memory/.
>>>
>> You are right, I cleaned up the changes made to support X1000's EFUSE
>> and rebase to clean 5.8-RC6, it still does not work properly, I think
>> we should drop this fix patch.
>
> The patch I mentioned was merged, so starting from 5.9-rc1 the efuse
> driver should work. Please resend this patch after 5.9-rc1 then.
>
Sure, I will resent when 5.9-rc1 is released.
Thanks and best regards!
> Thanks,
> -Paul
>
>>
>>>> Fixes: 19c968222934 ("MIPS: DTS: CI20: make DM9000 Ethernet
>>>> controller use NVMEM to find the default MAC address").
>>>
>>> That shouldn't be a fix IMHO - the devicetree was updated in one
>>> \x7fcommit, the config should be updated in another. The "bug" here is
>>> \x7fthat it wasn't done right away.
>>>
>> Okay.
>>>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>>>
>>> Btw - when you add a Fixes: tag to fix a commit that is not for the
>>> \x7fkernel currently in RC phase, you need to Cc linux-stable as well.
>>>
>> Sure, I will pay attention next time.
>>
>> Thanks and best regards!
>>
>>
>>> Cheers,
>>> -Paul
>>>
>>>> ---
>>>> arch/mips/configs/ci20_defconfig | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/arch/mips/configs/ci20_defconfig
>>>> \x7f\x7fb/arch/mips/configs/ci20_defconfig
>>>> index f433fad16073..ba26ba4de09a 100644
>>>> --- a/arch/mips/configs/ci20_defconfig
>>>> +++ b/arch/mips/configs/ci20_defconfig
>>>> @@ -140,6 +140,7 @@ CONFIG_INGENIC_OST=y
>>>> CONFIG_MEMORY=y
>>>> CONFIG_PWM=y
>>>> CONFIG_PWM_JZ4740=m
>>>> +CONFIG_JZ4780_EFUSE=y
>>>> CONFIG_EXT4_FS=y
>>>> # CONFIG_DNOTIFY is not set
>>>> CONFIG_AUTOFS_FS=y
>>>> --
>>>> 2.11.0
>>>>
>>>
>
prev parent reply other threads:[~2020-08-07 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 7:19 周琰杰 (Zhou Yanjie)
2020-07-23 7:19 ` [PATCH] " 周琰杰 (Zhou Yanjie)
2020-07-23 8:47 ` Paul Cercueil
2020-07-25 8:02 ` Zhou Yanjie
2020-07-28 15:40 ` Paul Cercueil
2020-08-07 15:55 ` Zhou Yanjie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8b28bac-8995-23db-816e-31ba1f8d02f3@wanyeetech.com \
--to=zhouyanjie@wanyeetech.com \
--cc=aric.pzqi@ingenic.com \
--cc=dongsheng.qiu@ingenic.com \
--cc=ebiederm@xmission.com \
--cc=hns@goldelico.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@crapouillou.net \
--cc=rick.tyliu@ingenic.com \
--cc=sernia.zhou@foxmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=yanfei.li@ingenic.com \
--cc=zhenwenjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®