From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A403A13BAE7 for ; Sat, 26 Oct 2024 07:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729927268; cv=none; b=Tcd1BLMdBoRmk2dEN1Kurs36F+Hp30hGNnEznN3DDNlkQ3DYlNGpill2UqKTrn2n0sR3YBvHgD4/xRmIxP6ACNMNEPKZ+ZXxfBsHCRjlWxxfzGWSWYtvFJWxMRBlBxWnZOa5L1OdawfiIWgvQslUv2Btoch2wwW9Z4w4qPpwc+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729927268; c=relaxed/simple; bh=xRWUfV4bMhGm5rXBJ3/cfEQLUElemKl2Z3XinKeAE4M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NQYq5GJM0W7hfE8A/KL86z6aAuS8Fr7B4Q1V7/QtOiaeRM3HtGpQ8Am+y+k+axOoB3h5yblTlGGLtI20qfoN0JbbpqZZI88g3lH3pUfIMy0/M+D5yrrVlEimwH9b0OeF68mbK7Ydk1nvh0nZKHz47Riy+zhHPFFm90RSyPVzrwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=i1OpSz5m; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i1OpSz5m" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-37d41894a32so2035927f8f.1 for ; Sat, 26 Oct 2024 00:21:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729927265; x=1730532065; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HPedWigh3naXCh3blfYtrbUjkwvZYaZCeb63vBk9Lkc=; b=i1OpSz5mOAIOtp5aXHqgupgAa6Vgklo5yO9XivszrZGiMihjujzNG2A62vdJ5ruRCX 9fXu7QSCc6Hz+yNJ86gf1BgVMTwps/PuHbt8lYg+L25chv+oh9BOaC6+e3xstQxhSDd3 nr0q/Veb7dGpn7EYVGlrpTa8YR3U9/nbVPXofXFYeUbJPhGt8dxtO6VcUdHT+oqE4E0U WHjh/5k8YFr2eQOWTe3O32kokX3De8NnyXXTfNvE7XEBhDG/DfeaNH1l4sghX2qlKTPX Kj8sA01Hzied7e8y3b+rXYIEIXzhoAMH8ljoYy9FVb1Zmm4VsT+Dzx76bovTly+U1MgM YEkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729927265; x=1730532065; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HPedWigh3naXCh3blfYtrbUjkwvZYaZCeb63vBk9Lkc=; b=TBXQwFPoiX5ZEWfeZy9z+cTu9R6d2pqiXaM6GYMVLK3wTODot1CfNj5OXIPhAnrhLV zhX+7pxkTiBgEpBtjQY501a3DODjoO1uJOMdygv1ZpY9u1D27vpUl86WuUQgx8hTYtI1 86zrhyCC7PQHZu72Pda8PHqMQrYeq120uC3JPBrmndOPcgjxRbJay+ucS3UjjjqBdBTf 1vDrMIRsqkqs8xFfEVKC6OCtsOaHWr+oMXrSe6+wqwcYjyvCHuZsm9OsVR3zsdey9QhJ dAaV9/0qiq8dcAhH0UIsX97yjmsSzSZZzjz7uTwsAa6a7IOAmAWnwno+vfvQjfbzHgwK fs6g== X-Gm-Message-State: AOJu0YwTbhxt2Ib08m60n5o2EmBqQ9WPpTPgQppg/0/BAAoCho2cYsW5 bRJhzjSYPsTGMDKfjVjMvjbe3xm0cyzvTk1rP1D48YzSPsYSjVWKVqMQkvD4iw55EVsK7CRgOaR nbrQ= X-Google-Smtp-Source: AGHT+IG6PK2ZTy2JhkgdSJ0N8HMtlr8YOWZIDu1LZe0bSYjtnk5No8OeJmfP2aH2IOP2aTxU73p9sg== X-Received: by 2002:adf:e611:0:b0:37d:2e74:2eea with SMTP id ffacd0b85a97d-38060ea6542mr1738098f8f.5.1729927264600; Sat, 26 Oct 2024 00:21:04 -0700 (PDT) Received: from [192.168.68.111] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-38058b3af02sm3529093f8f.25.2024.10.26.00.21.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 26 Oct 2024 00:21:04 -0700 (PDT) Message-ID: Date: Sat, 26 Oct 2024 08:21:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvmem: core: Check read_only flag for force_ro in bin_attr_nvmem_write() To: Marek Vasut , linux-i2c@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Thorsten Leemhuis References: <20240713154001.107439-1-marex@denx.de> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Apologies, some how I missed this email. On 26/10/2024 00:15, Marek Vasut wrote: > On 9/25/24 12:42 AM, Marek Vasut wrote: >> On 7/13/24 5:39 PM, Marek Vasut wrote: >>> The bin_attr_nvmem_write() must check the read_only flag and block >>> writes on read-only devices, now that a nvmem device can be switched >>> between read-write and read-only mode at runtime using the force_ro >>> attribute. Add the missing check. >>> >>> Fixes: 9d7eb234ac7a ("nvmem: core: Implement force_ro sysfs attribute") >>> Signed-off-by: Marek Vasut Applied with CC stable. --srini >>> --- >>> Cc: Srinivas Kandagatla >>> Cc: linux-kernel@vger.kernel.org >> It seems this bugfix is not even in next, any news ? > > This is still broken, bugfix is available for three months now, but not > picked up. Any news?