From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A74A1624E9 for ; Sat, 6 Dec 2025 16:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765039458; cv=fail; b=gznZBswUed/gJRI8iedVCVdfwRiAhpTscJbURAEBDfh8qKTqhxF8EbhUAEgh3xhUmbvHJ3BEIPCXQEkDj8+ptwcXSZQOJJSlqqgQ1VVd3Zk98a3WVuzIXreCtjca9r5mEg+SnfmSAsT12R2b46FVB+ND+yulBfhyyVjTKj+4KGs= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765039458; c=relaxed/simple; bh=gNxx8uAoi9agKD1BlrqB46+ZQOGQ3+t37E9wNhO7vAE=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=ki/yM1NLJRywG61OJcvtae1+9nUcWSy886VwIKGVIpW4C0QeamQGIKHBs/66/3bm9cknUZNC6RnNGHr49rH7/3w9og/VR4tkYTo6zaDuBU7hW1iYzpCtd9KZZIwTsfjW+YbeHo9BYp1U/uYVrkFoKI88sOhDDjyMaUlg6ZOQlWA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=q78rJGBm; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=W5UwyVb2; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="q78rJGBm"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="W5UwyVb2" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B6GbU072432293; Sat, 6 Dec 2025 16:44:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2025-04-25; bh=ncDLu5fKgabJdhrNgc Xskh7G979sZWdZ7JtlQ/hQ/TA=; b=q78rJGBmfDNLSODS+i5HQzNHoQdIcczvjm sB8A4qW2PSlvh5WjSXKWDidjKFVdET3gL/NDbQtpqquA7SAZblYs3hyRRO1t82Yj df5P7C0srdp/pY3YhHBsHqESyp19o3zZS8uXHTmAvTqcdWvkDIGx5zzR1rNpowlE AtHUpjkfmECH9EmZnaRxXezyhryoYjFLNeuEmod69T9wzlRDCRiQsNXfOaKCr2wF EHtmHYMsvv487Jky8P9rsFm5tIKG7WMpBIECjOYbklQRSXGIJ18UTq+d7HpAPQvI CUkLgHOjD9RS9rbBumj4Hn3D2iRkQx/YsDs6g81qL1aW2wf2F/zg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4avr5e0033-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Dec 2025 16:44:03 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 5B6CFsKg039838; Sat, 6 Dec 2025 16:44:02 GMT Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012026.outbound.protection.outlook.com [52.101.48.26]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 4avaxg530w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 06 Dec 2025 16:44:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=P5NKYyUBkban9S/bhZEWX8MYPCRC86ry9+Z+0kDc4fE2Xwsu7qgRG45cvnMzxo5Qx9TNO6ZPzuD6XFk981t9MDFbnXYkp0q2a9CORi6ESpXuH4OCJje4M70/MQ4RzGQJKsNLRQfx5j4MNtbZmYz8JzY6cTNuwWyHmINF8Q6fq5riD6LSt4feRp9GQFkF7NXKm/gw7wKIhbtKubDt0/kD0cV41gR2mYaLrqywshiP5qCNtRZ/abI+mvZg7ANEDvGWBuwQ81IHAImINnQ9sGlrhkCiPLi8P8+qonnjXOXs6GBOnef0iB7Oqpb2PCC4eI8bnXhDP3zqSquQoIrYvYiXgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ncDLu5fKgabJdhrNgcXskh7G979sZWdZ7JtlQ/hQ/TA=; b=UWGrWCWw2VLJ3y1PD4pmGulybp/IRfBvu+Kw5frqMeMkkmYf96dYaa544WZBACzhA9O5yEhbgMF1h6mOd3Mh4QoDgpIE5WUkY9UsT44vgZ0KX7hlPJyxLP/XRZAu18QzEPWucdmRS4ny76h7KB6BCf57fuYVh7m2YQsgIqB6pDqTwCbsY2347tfEIxeUW5hTgaIBPp7xcoBV1ZnVt2Vn6GWHEYLDRFCwLFJXEOgJFc0GpguFX4pe9WhS0pLcj/iO8avjrvghzyoO0smPw9ujbMdCaYwMGBuwESAGmE33vsm4UqnhA/M1o/6i5QGNd/dRMGK87d4TQUDhcqvoLbaYJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ncDLu5fKgabJdhrNgcXskh7G979sZWdZ7JtlQ/hQ/TA=; b=W5UwyVb2WknKIYRhUEulcGYKf0TD054a/7jHscitzF+q4WNWBAu8h6TKWcPhsD1blh+Xgq+izT+LmPADCQ1y5mDdSkiaJwPtu27F0oe3tO3fONeXRBYgs4mj4+NA/gIq+7KInUf910W7eSSBxFgfzXaVldfFXBaDqmHRPLSx8TE= Received: from DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) by CH4PR10MB8075.namprd10.prod.outlook.com (2603:10b6:610:236::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.13; Sat, 6 Dec 2025 16:43:59 +0000 Received: from DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2]) by DM4PR10MB8218.namprd10.prod.outlook.com ([fe80::2650:55cf:2816:5f2%7]) with mapi id 15.20.9388.003; Sat, 6 Dec 2025 16:43:59 +0000 Date: Sat, 6 Dec 2025 16:43:57 +0000 From: Lorenzo Stoakes To: David Laight Cc: Andrew Morton , David Hildenbrand , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , oliver.sang@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: avoid use of BIT() macro for initialising VMA flags Message-ID: References: <20251205175037.1287366-1-lorenzo.stoakes@oracle.com> <20251205184342.2cfcc73e@pumpkin> <4eea9138-3853-457d-9113-e3caa7f00437@lucifer.local> <20251205213449.12bf4819@pumpkin> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251205213449.12bf4819@pumpkin> X-ClientProxiedBy: LO4P123CA0672.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:351::10) To DM4PR10MB8218.namprd10.prod.outlook.com (2603:10b6:8:1cc::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR10MB8218:EE_|CH4PR10MB8075:EE_ X-MS-Office365-Filtering-Correlation-Id: dac60c7e-8522-487b-e35c-08de34e6a77a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|366016|1800799024|7416014|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7lUTkhL+stSTzuvMH9wHjJ0AUyOPP8ByJm5xmedD+efra7hHxQmhne8zU91V?= =?us-ascii?Q?VZ9cxG2P2vy3NRaVNy2DXaFfXSbuAFNsBF/Avll7qZXHKTtHBsb5MsjZd9ud?= =?us-ascii?Q?bhCZsSUmwt3vKsqZ4tQcHQJ1DKRxdaHssoyspKqVRPcNTlzIFt25/WSQN3eP?= =?us-ascii?Q?qR3JkrpVSw7irGj+eOCckwzRN12kJl/eodDK071o6eJl0ZPXjwR+e7DCGQlP?= =?us-ascii?Q?uy3VgzK33hA64ox8te6gCie42s4QbOgCJZDaq3L4A+ggx9o+N5GoGsTyxhbr?= =?us-ascii?Q?b3SlcrZqIjcOp7pmnOB0dfu1I4DuRBxNx2XlBwhvDI6ISIc5MqP8E1G3EgR/?= =?us-ascii?Q?boL3NO39g7yHSmC+/tHmVVQ57Z32igyFcNHIUNVpE9rLf3gKJBmTQLu6ojJn?= =?us-ascii?Q?AI0HUimuSyS7blDCh/xA5Zm2emljYNwFUQSbcMAkcXdXh+rmFnQUvgSzrFVz?= =?us-ascii?Q?+JER34ADuDBlMONbqADqfqDKWjyDwCKr2kqLAjXLp7kEcX31VSOMYMhatSN1?= =?us-ascii?Q?XSTJ50kMm3DH+Yvl2fs7VuBfLb/snmombaBStQng777JxDWSv1yvMotTsZu7?= =?us-ascii?Q?nB3j4DLIlLzvQi8JGw/qv1TGoFn8GUfPab7EJq725lZESK9PHAvUddk07NIh?= =?us-ascii?Q?Hp2gX8FUyrwhG/fk6bJn3jIAcj7xmq7YBUOrnUDEiMFH+LMKUYciSg/IZ6DF?= =?us-ascii?Q?1UGxS5AaZMvQTBBoH9bnanWzT6O1Ya7ZvyGv9LjBNiU6PzLdPSNOLD250EIN?= =?us-ascii?Q?n6fe1HXMRS5qgm8QEaUgEGXVWjqGcaP2oSEWbq9INXpIcZnz/LdmrYnqzGKf?= =?us-ascii?Q?k47lbFHYUIY04xSQVAimbNktaXQ8KKJVxym3P52DfjVXMGwJaK74b/5YVFFR?= =?us-ascii?Q?89g9eSHsifd8wKMyv6H+eJnW0PBCvZH3qYVB+GQ2IUFrDwB8O52bZHXlelvC?= =?us-ascii?Q?aH5WVQLtll0Yc7xW3XJr+hQ3eoyy5idVHQqkyJy1qJUW/6WzgIHbfwJ+Jspm?= =?us-ascii?Q?qm8KainkV3MAGhD1vAbLmyfnVZgDqLlfgHWUBrnh3b95aVJ2u3SxvyTybhhx?= =?us-ascii?Q?rNlwpvxTI6DaCZPfbaZwcq1XTQuUntzUiuC3vS3FftRIfEzMPK+XnNu3NdJP?= =?us-ascii?Q?PEc+wm6jqyiaSaCzwbM/JZuj3aFef3IUhADMVJC/YwFyivJ9wyYdxWWHutOr?= =?us-ascii?Q?wt+0nRCNcs36y/cY/1JyxHojuNWRIYh64igkYpEAURXygVZh2BNv11R6rvSr?= =?us-ascii?Q?+Lbs4RFzgvpEjzWDwK6jSY31C1CSk4egWi4ggX43n9hxVbfeOOKLrhm4q0UG?= =?us-ascii?Q?Qu43V/CfScJipgm5Mj4Y/eLX0NL4B9LH6B0580HLbuWd7Q3XhKts29Zun+6W?= =?us-ascii?Q?uZUUJ/dTRMElExe2eHaJJj4Z2os1GZcIDkb/RN+8g+m0sg9sYZqUAlcqqz6C?= =?us-ascii?Q?14hv9hYCbf/LXCMb3HStLQnr6UndIVmX?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR10MB8218.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(1800799024)(7416014)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lzuiNjUEKlhyN1kyi0wYH6du4Urmd1KsV/BJAhQOBs9Nc5bwBa+glY7Y7nrg?= =?us-ascii?Q?ctKFPIFSwu4etsDBfDN90Hny4HYAr+n7Cw2K9q3TBAV+4sot/RDQPD85Dls3?= =?us-ascii?Q?ErfZ985nCvo8IXwyrXafAk4jHoR2QRHT4Ar14mrBs6zOzSr7cgom99BFReUZ?= =?us-ascii?Q?b6Z7IDDSKRjzuyHGId5Y284ferPMm+/J4ZAapPW7oOn4ol7VLgqQ/dRmLXna?= =?us-ascii?Q?liHmEEZgydVcM4eMgJakhLJEnVIh3KuE00Ci4u4+3hr6h4vTern/6jLOcNj5?= =?us-ascii?Q?uFPLDOvFDHjBYlidj0wYmdhJsvPurHSyYvWa7bDOzBYxqmhVYfbGJrMumVhw?= =?us-ascii?Q?EkYIx3zs6CE2tbHRzU4fp6O/4vNZp5oIKEDZUfJbDZOBi5idr5T1s7RW/W2W?= =?us-ascii?Q?NJpQaS9SwsAoPx4USwnjzQlbpSBWunZqFK5TNmW0mDTOLwaMFa3EAiR/SviK?= =?us-ascii?Q?3ILz2LezTa8PR/Tihr+zEhgMMUUe7hUvTgcU5srkMtwrbCW7rODtt1CYBVZP?= =?us-ascii?Q?TpTZIP9XBmcB3u1SKGOdrtEw7wUNB70B4yDpDnD7WYqoKMPx9AP8iba6a3M/?= =?us-ascii?Q?Befli8AZZtKCUGHbh8d14oq7yxvvJj26JLtcorEE+R7zIYkdoStYTxYHuldb?= =?us-ascii?Q?8NTR372ShEtl9COrYif1KdGwgtL7kJciKDIStyHcl8/d3ajZ/q6nYMGeyZnH?= =?us-ascii?Q?pf54q8Mjr8FVVwKcXLBs7cnVw+3ZUvusw17K6A86yZQGeUgYGRyM/oZF+2Kx?= =?us-ascii?Q?Ju2tkRIqpRYg5qyn+7VT8GFv1jZgPeUXxaiwQmFUPHu/EGaFmvKEz2IRowcO?= =?us-ascii?Q?r48OTmhXr2T8jw9tPuaxvLv1tldmq1gdbb2+8372lJbaSfgB8TGDJVk5bZ1c?= =?us-ascii?Q?mN+qeRW4Z/pxowNBVBag6n6AyV34p+8V/jEpjpK+2BgRfs8M1ZI4jCSl6EOx?= =?us-ascii?Q?glwsglkgO5/KlueUZB8GW5Wx/ipIimQtQfWvNFDi6iz/KErttdqLIJAUzNBj?= =?us-ascii?Q?2PWllo1Zg+HrceLTt/mrRTeXtzvwHQ3W2IymjkD/A/8aLHocL0i61MD9mZZc?= =?us-ascii?Q?ntsnEzVyMEbi7fm7G4edNeGuNwKdRfkqCr6RMd+NyoeUa9KljLYOf4asvu7/?= =?us-ascii?Q?/PryBqJGVorHOdLOAPnVyadv7hDJHew2kNgM9+yhlTzxMeGl4Twh3NYMHgii?= =?us-ascii?Q?3i3RLc4ZMF+u9D/XU6/m51+YUbkJWUo2+RPOKzb2I11EGTZ9p2cGxcMa9vG6?= =?us-ascii?Q?SXn9GSRItYdbcnyRAR985v5Y/vYno2FgN0JmulUi8dqLDUL5VBTRwy2/zn40?= =?us-ascii?Q?4NygTVJoPTx9YcRfkeons4RAlh/tjyVbfibjp2P2yZFURia/NbYXqVJwlEgE?= =?us-ascii?Q?VDe5VNvPyCFCrw4GQqxGkl0cgvVZLDqscVi+23/eaUaZWl+dYiKUMvsyqZ1O?= =?us-ascii?Q?1cyRHRQzIlatNHn+Ww2UWcufrgxGBj43oOK6+Baie6Qbk7BfPYOpHRwI1BKZ?= =?us-ascii?Q?0X2zD0Al7Gz2SfIi3E4GgX69WbcLrQ2S6+XzgOn3wgecbIA+7sH/+b3BfvEe?= =?us-ascii?Q?SOOnZClIL/lwEYxVHy/2SXAN8xyeOYHWK8Y2J32oUXjd6HpyOt+T+EOlhnzP?= =?us-ascii?Q?czHpNq+Tt3jcoUKhmyAC8e1vtZRDvY2VKzNmR24qSRXBgh/fw1fNqJlO580Q?= =?us-ascii?Q?TNa/3A=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: uYCah5aGb/hXoUWjVejjYBGW7eQ//g13JgQ2usv1am4Fg025alD7YGHz85V1NGbwhABA+H9fDWZtpW03NQkX2o/6tPvssTh55FlPDltdEAKAaGRahMv711dkq9rfur/CeHDvVYDEmBjERoQYp7LAo6x4WkvL0err3RkrBE7B73iu+5piPvh6LNaF09eGsGab/zvktlnwd9/xQ241roLpeEZ7M0P7QBzb7irN7KYZj2ZI9ecr+xkTI5faGHBmkIZnvyuklVDM20qw2KYIKJZJERSBXsjBdml07dAumZ5nnZ4HteDSb4ox0SochOWgRdzOQzHlJoeyqF9tZNvsavisMC0k6clF6wHWNeG8Alj9GjNAuIfSBeiD07g6ge5b1c1gdVIxCM4qRisRJHglA4+oeH3ir/Lhy+kOq1mp+f8UULCUwAaFNy8YKbatGUekwhcPJCmRBNsFlWOHi2FKev5SXmoW3j9zLqC/DbULi2zJz5bxJW1Bj8gKVe/K0Os6GZztZNGs38A875ibhm+vDpiOjQ2cz7s7+GmANgVfNWhAOKqeB/tVjSrMsVvbvBHNi3T4Rlm+8JF5jth+ENWWnFya3ot6TD4vJgQZaVpG/uUO/N4= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: dac60c7e-8522-487b-e35c-08de34e6a77a X-MS-Exchange-CrossTenant-AuthSource: DM4PR10MB8218.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2025 16:43:59.0680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OhA47ghVa+obOHSbPXn9Nn9/vXcE5nmHglJCylJXx42OBoS3AnY25mkLWLcBU+1GyXu8phNLU5ym9/FlZUUKBY6ps9VjvBcvRST1UGb8YzM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR10MB8075 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2510240000 definitions=main-2512060137 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA2MDEzNiBTYWx0ZWRfX/n11We7F5wRT Rv4RQO0Kpz43kSqSUNkTvxJrKfMdd5NU/2ygiwtKrWhXfoUsL5azTa/aq8rzEyTOanaLebv71HR KsMHIGiawHlM1pLgbQdXbgPcbzZd0LDiwDHbA5g49gluHKL9F/FzP/mqoE8Gaz1FtCh2kp9tYne hWlykta7oBAs+MI0WLWboZxiLqRSAhK8hrZpZwK8l1ao+D9j4eaUOzMUwHYyl0Gpbewqymciip1 81FPOf30KIfm0zXkbhiRkMOhdPO3WrW5hnjWdVuvYLjUPOxKq3WgxRXSkscrrZl0A3diDySvCrV vTK1+YBwbZNmUMMI8nWv4eAoeuYklfehgX/8zqoXIP8rcy47frCFcYLzsECLqLGbiDmqd6lzTZN NBTl5D/jPoTL+Vlyqx+8ETLN6pssamjmA8Q+qnJD/DHUh4+XvB8= X-Proofpoint-ORIG-GUID: QbaTcTAsEJ14eQmojQVPRLFoG_H941gG X-Proofpoint-GUID: QbaTcTAsEJ14eQmojQVPRLFoG_H941gG X-Authority-Analysis: v=2.4 cv=MfVhep/f c=1 sm=1 tr=0 ts=69345d53 b=1 cx=c_pps a=e1sVV491RgrpLwSTMOnk8w==:117 a=e1sVV491RgrpLwSTMOnk8w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=wP3pNCr1ah4A:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=Up1whnIK-If5Cw_EK5EA:9 a=CjuIK1q_8ugA:10 cc=ntf awl=host:13642 On Fri, Dec 05, 2025 at 09:34:49PM +0000, David Laight wrote: > On Fri, 5 Dec 2025 19:18:56 +0000 > Lorenzo Stoakes wrote: > > > On Fri, Dec 05, 2025 at 06:43:42PM +0000, David Laight wrote: > > > On Fri, 5 Dec 2025 17:50:37 +0000 > > > Lorenzo Stoakes wrote: > > > > > > > Commit 2b6a3f061f11 ("mm: declare VMA flags by bit") significantly changed > > > > how VMA flags are declared, utilising an enum of VMA bit values and > > > > ifdef-fery VM_xxx flag declarations via macro. > > > > > > > > As part of this change, it uses INIT_VM_FLAG() to define VM_xxx flags from > > > > the newly introduced VMA bit numbers. > > > > > > > > However, use of this macro results in apparently unfortunate macro > > > > expansion and resulted in a performance degradation.This appears to be due > > > > to the (__force int), which is required for the sparse typechecking to > > > > work. > > > > > > Does sparse complain if you just add 0? As in: > > > #define INIT_VM_FLAG(name) BIT(VMA_ ## name ## _BIT + 0u) > > > > > > That should change the type without affecting what BIT() expands to. > > > > Thanks, checked that and unfortunately that doesn't satisfy sparse :) > > > > I don't think it's too crazy to use 1UL << here, just very frustrating (TM) > > that this is an issue. > > I might use some of my copious spare time (ha) to see why BIT() fails. > I bet it is just too complex for its own good. > Personally I'm fine with both explicit (1ul << n) and hex constants. > The latter are definitely most useful if you ever look at hexdumps. Thanks :) yeah I just didn't want to go down that rabbit hole myself as I seemed to have the answer and wanted to get it fixed, but obviously am quite curious as to what on earth is causing that. > > At the moment I'm trying to fix bitfield.h so you don't get compile errors > on lines that are 18KB long. :) > > Found a new version in linux-next - has its own set of new bugs as well > as more of the old ones. > > David > > > > > > > > > Cheers, Lorenzo > Cheers, Lorenzo