From: "Leon Romanovsky" <leon@kernel.org>
To: "Jason Gunthorpe" <jgg@nvidia.com>
Cc: "Marek Szyprowski" <m.szyprowski@samsung.com>,
"Andreas Larsson" <andreas@gaisler.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"David Miller" <davem@davemloft.net>,
"Geoff Levand" <geoff@infradead.org>,
"Helge Deller" <deller@gmx.de>, "Ingo Molnar" <mingo@redhat.com>,
iommu@lists.linux.dev,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
"Jason Wang" <jasowang@redhat.com>,
"Juergen Gross" <jgross@suse.com>,
linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Matt Turner" <mattst88@gmail.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
sparclinux@vger.kernel.org,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
virtualization@lists.linux.dev, x86@kernel.org,
xen-devel@lists.xenproject.org,
"Magnus Lindholm" <linmag7@gmail.com>
Subject: Re: [PATCH v1 3/9] parisc: Convert DMA map_page to map_phys interface
Date: Mon, 06 Oct 2025 07:03:49 +0300 [thread overview]
Message-ID: <d8c1e548-ebc5-4a07-8bf5-d98e9f2e6587@app.fastmail.com> (raw)
In-Reply-To: <20251005233133.GL3360665@nvidia.com>
On Mon, Oct 6, 2025, at 02:31, Jason Gunthorpe wrote:
> On Sun, Oct 05, 2025 at 04:22:59PM +0300, Leon Romanovsky wrote:
>> @@ -582,7 +582,7 @@ ccio_io_pdir_entry(__le64 *pdir_ptr, space_t sid, unsigned long vba,
>> ** Grab virtual index [0:11]
>> ** Deposit virt_idx bits into I/O PDIR word
>> */
>> - asm volatile ("lci %%r0(%1), %0" : "=r" (ci) : "r" (vba));
>> + asm volatile ("lci %%r0(%1), %0" : "=r" (ci) : "r" (pba));
>
> Don't know how I missed this, but this is the virtual address for the
> cache invalidate James mentioned
>
> So the optimal is to drop the lpa() and to use phys_to_virt() to get
> vba for this instruction.
The optimal is to keep parisc arch code as I did in v1 and don't change it too much.
>
> Jason
next prev parent reply other threads:[~2025-10-06 4:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 15:02 [PATCH v1 0/9] Remove DMA .map_page and .unmap_page callbacks Leon Romanovsky
2025-09-28 15:02 ` [PATCH v1 1/9] alpha: Convert mapping routine to rely on physical address Leon Romanovsky
2025-09-28 17:35 ` Magnus Lindholm
2025-10-03 14:47 ` Jason Gunthorpe
2025-09-28 15:02 ` [PATCH v1 2/9] MIPS/jazzdma: Provide physical address directly Leon Romanovsky
2025-10-03 14:48 ` Jason Gunthorpe
2025-09-28 15:02 ` [PATCH v1 3/9] parisc: Convert DMA map_page to map_phys interface Leon Romanovsky
2025-10-03 15:01 ` Jason Gunthorpe
2025-10-03 17:18 ` John David Anglin
2025-10-03 17:26 ` Jason Gunthorpe
2025-10-03 20:28 ` John David Anglin
2025-10-05 14:29 ` James Bottomley
2025-10-05 13:22 ` Leon Romanovsky
2025-10-05 23:31 ` Jason Gunthorpe
2025-10-06 4:03 ` Leon Romanovsky [this message]
2025-10-05 14:22 ` James Bottomley
2025-09-28 15:02 ` [PATCH v1 4/9] powerpc: Convert to physical address DMA mapping Leon Romanovsky
2025-10-03 16:35 ` Jason Gunthorpe
2025-10-04 6:19 ` Christophe Leroy
2025-10-04 20:02 ` Jason Gunthorpe
2025-09-28 15:02 ` [PATCH v1 5/9] sparc64: Use " Leon Romanovsky
2025-10-03 15:16 ` Jason Gunthorpe
2025-09-28 15:02 ` [PATCH v1 6/9] x86: Use physical address for " Leon Romanovsky
2025-10-03 15:16 ` Jason Gunthorpe
2025-09-28 15:02 ` [PATCH v1 7/9] vdpa: Convert to physical address " Leon Romanovsky
2025-10-03 15:58 ` Jason Gunthorpe
2025-09-28 15:02 ` [PATCH v1 8/9] xen: swiotlb: Convert mapping routine to rely on physical address Leon Romanovsky
2025-10-03 16:18 ` Jason Gunthorpe
2025-09-28 15:02 ` [PATCH v1 9/9] dma-mapping: remove unused map_page callback Leon Romanovsky
2025-09-28 15:17 ` Sam Ravnborg
2025-09-28 15:20 ` Sam Ravnborg
2025-09-28 15:31 ` Leon Romanovsky
2025-09-28 15:28 ` Leon Romanovsky
2025-10-03 16:18 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8c1e548-ebc5-4a07-8bf5-d98e9f2e6587@app.fastmail.com \
--to=leon@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=andreas@gaisler.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=geoff@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=jgross@suse.com \
--cc=linmag7@gmail.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=m.szyprowski@samsung.com \
--cc=maddy@linux.ibm.com \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=mst@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=sparclinux@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=virtualization@lists.linux.dev \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®