From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86984EEAA53 for ; Thu, 14 Sep 2023 16:22:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238342AbjINQWk (ORCPT ); Thu, 14 Sep 2023 12:22:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234922AbjINQWj (ORCPT ); Thu, 14 Sep 2023 12:22:39 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41CE81FC0; Thu, 14 Sep 2023 09:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694708555; x=1726244555; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Ne10332tLXxVYP5I0FRwMxBk1f5aF0fngK2Siw6b0Ts=; b=WvwWtUxbZ30PCkjs+2ieGNpzyhOczh2y6bEO5fF7b6DbcpeuxS0Jg62w M1gaD1+nS8KhTGE1npWlocU+Otko4T6H5+D2mWV8pnunVfDDczMa41K4F uZ1iWEK9wT9QW53kFzcxNMmT46vgwYJr1DPeROr+F82NiPn55qv/u7dc2 gbY06HNmHtdjg1ZDpaZ5L1lKk3/NHjIVh46kfs7VXrVHEOjiDR8Fpi1d3 DMpQsxMVrJrlqaRZpn8lB2wutISX8QRxPKbGqqD5r3S6vm8iOmvF9X1Fa ahmyJWEXtUzwScvmfpr/H285NDMfMoR8ZCQzxeAEVSXm2CBDeJMuOhAIe A==; X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="358421814" X-IronPort-AV: E=Sophos;i="6.02,146,1688454000"; d="scan'208";a="358421814" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 09:22:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="887881863" X-IronPort-AV: E=Sophos;i="6.02,146,1688454000"; d="scan'208";a="887881863" Received: from spswartz-mobl.amr.corp.intel.com (HELO [10.209.21.97]) ([10.209.21.97]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 09:21:51 -0700 Message-ID: Date: Thu, 14 Sep 2023 09:22:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v6 05/25] x86/fpu/xstate: Remove kernel dynamic xfeatures from kernel default_features Content-Language: en-US To: Yang Weijiang , seanjc@google.com, pbonzini@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: peterz@infradead.org, chao.gao@intel.com, rick.p.edgecombe@intel.com, john.allen@amd.com References: <20230914063325.85503-1-weijiang.yang@intel.com> <20230914063325.85503-6-weijiang.yang@intel.com> From: Dave Hansen In-Reply-To: <20230914063325.85503-6-weijiang.yang@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/13/23 23:33, Yang Weijiang wrote: > --- a/arch/x86/kernel/fpu/xstate.c > +++ b/arch/x86/kernel/fpu/xstate.c > @@ -845,6 +845,7 @@ void __init fpu__init_system_xstate(unsigned int legacy_size) > /* Clean out dynamic features from default */ > fpu_kernel_cfg.default_features = fpu_kernel_cfg.max_features; > fpu_kernel_cfg.default_features &= ~XFEATURE_MASK_USER_DYNAMIC; > + fpu_kernel_cfg.default_features &= ~fpu_kernel_dynamic_xfeatures; I'd much rather that this be a closer analog to XFEATURE_MASK_USER_DYNAMIC. Please define a XFEATURE_MASK_KERNEL_DYNAMIC value and use it here. Don't use a dynamically generated one.