From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750897AbdAMAbG (ORCPT ); Thu, 12 Jan 2017 19:31:06 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:38306 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750760AbdAMAbE (ORCPT ); Thu, 12 Jan 2017 19:31:04 -0500 Subject: Re: [PATCH V2] usb: dwc2: host: fix Wmaybe-uninitialized warning To: Nicholas Mc Guire , John Youn , Felipe Balbi References: <1484238806-13977-1-git-send-email-hofrat@osadl.org> CC: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: John Youn Message-ID: Date: Thu, 12 Jan 2017 16:30:58 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484238806-13977-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.9.138.255] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/12/2017 8:32 AM, Nicholas Mc Guire wrote: > Uninitialized char* causes a sparse build-warning, fix it up by > initializing it to NULL. > > Signed-off-by: Nicholas Mc Guire > --- > > V2: add missing change-log as requested by Greg Kroah-Hartman > > > Problem reported by sparse > drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info': > ./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used uninitialized in this function [-Wmaybe-uninitialized] > __dynamic_dev_dbg(&descriptor, dev, fmt, \ > ^ > drivers/usb/dwc2/hcd.c:4492:8: note: 'pipetype' was declared here > char *pipetype; > ^ > Patch was compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m + > CONFIG_USB_DWC2_VERBOSE=y > > Patch is against 4.10-rc3 (localversion-next is next-20170112) > > drivers/usb/dwc2/hcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c > index 911c3b3..9f66777 100644 > --- a/drivers/usb/dwc2/hcd.c > +++ b/drivers/usb/dwc2/hcd.c > @@ -4489,8 +4489,8 @@ static void dwc2_dump_urb_info(struct usb_hcd *hcd, struct urb *urb, > { > #ifdef VERBOSE_DEBUG > struct dwc2_hsotg *hsotg = dwc2_hcd_to_hsotg(hcd); > - char *pipetype; > - char *speed; > + char *pipetype = NULL; > + char *speed = NULL; > > dev_vdbg(hsotg->dev, "%s, urb %p\n", fn_name, urb); > dev_vdbg(hsotg->dev, " Device address: %d\n", > +Felipe Acked-by: John Youn John