Re: [PATCH net] net: phy: clear phydev->devlink when the link is deleted

[Andrew Lunn <andrew@lunn.ch>]

On Thu, May 22, 2025 at 01:57:20PM +0000, Wei Fang wrote:
> > On Thu, May 22, 2025 at 02:42:53PM +0800, Wei Fang wrote:
> > > The phydev->devlink is not cleared when the link is deleted, so calling
> > > phy_detach() again will cause a crash.
> > 
> > I would say crashing is correct. You have done something you should
> > not do, and the crash helped you find it. phy_attach() and
> > phy_detach() should always be in pairs.
> > 
> 
> phy_attach() and phy_detach() are called in pairs in my case. When
> re-enabling the network port, if an error occurs in the phy_attach_direct(),
> For example, if phy_init_hw() returns an error, it will jump to the error
> path and call phy_detach(). Because phy_detach() did not clear the
> phydev->devlink pointer when the network port was disabled,
> device_link_del() will access a NULL pointer and cause a crash. And this
> crash may cause the CPU to hang. I don't think it is reasonable to cause
> the CPU to hang.

Ah, now i get it...

phy_attach_direct() runs, but fails early, before the call to:

phydev->devlink = device_link_add(dev->dev.parent, &phydev->mdio.dev,
						  DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS);

So it has its old value, from a previous attach/detach cycle. At the
error: label, it calls phy_detach(phydev), which does a
device_link_del(), using the old value...

Please improve your changelog message, add more details.

    Andrew

---
pw-bot: cr