From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752331AbdAFGU4 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Jan 2017 01:20:56 -0500
Received: from mail-pf0-f195.google.com ([209.85.192.195]:34193 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750896AbdAFGUs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Jan 2017 01:20:48 -0500
Subject: Re: [v1] i4l: act2000: act2000:- Do not use 'asm/io.h' directly, use
 'linux/io.h'.
To: Greg KH <gregkh@linuxfoundation.org>
References: <1483612764-29543-1-git-send-email-arvind.yadav.cs@gmail.com>
 <20170105114617.GB8859@kroah.com>
 <54dd4d9a-7561-8c8a-bc36-2e082fe88725@gmail.com>
 <20170105120523.GA23872@kroah.com>
Cc: devel@driverdev.osuosl.org, isdn@linux-pingi.de,
        linux-kernel@vger.kernel.org, arnd@arndb.de
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
Message-ID: <d8cc0b56-b6e4-0d7d-c7f8-e3d2ac7e78dc@gmail.com>
Date: Fri, 6 Jan 2017 11:50:35 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170105120523.GA23872@kroah.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks for your suggestion :).
I have done the changes as per your concern . Please review it.

Thanks :)
-Arvind

On Thursday 05 January 2017 05:35 PM, Greg KH wrote:
> On Thu, Jan 05, 2017 at 05:25:05PM +0530, Arvind Yadav wrote:
>> Please find my comment below.
> Where?  What happened to your email quoting?
>
>> Thanks
>> -Arvind
>>
>> On Thursday 05 January 2017 05:16 PM, Greg KH wrote:
>>> On Thu, Jan 05, 2017 at 04:09:24PM +0530, Arvind Yadav wrote:
>>>> Make uniform definition of ioremap, ioremap_wc, ioremap_wt and
>>>> ioremap_cache, tree-wide.
>>> That doesn't make much sense, and doesn't match the subject: or the
>>> patch itself.
>>> -- Please refer the commit which is already in main-lined.
>>> commit 2584cf83578c26db144730ef498f4070f82ee3ea
> Ah, here it is, please quote stuff correctly.
>
> If you are referring to something else, great, then say so in the commit
> itself.  Every commit should be self-explanatory, how am I supposed to
> know this.
>
> And this text still doesn't make sense to me, please fix.
>
>>> And what is with the "[v1]"?
>>> ---V1 is stands  for patch set version 1
> Please read Documentation/SubmittingPatches for how to properly label
> patches, don't make new things up, we have too many different developers
> (i.e. 4000+) for everyone to do their own unique thing.  :)
>
> thanks,
>
> greg k-h