mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Pablo Mazzini <pmazzini@gmail.com>
Cc: Lee Jones <lee@kernel.org>,
	Alistair Francis <alistair@alistair23.me>,
	Andreas Kemnade <andreas@kemnade.info>,
	linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/5] hwmon: sy7636a: fix negative temperatures
Date: Sun, 8 Nov 2026 07:59:46 -0800	[thread overview]
Message-ID: <d8cc9a82-eb55-46fa-8632-c6ced9cb8d9c@roeck-us.net> (raw)
In-Reply-To: <20261108093602.329554-3-pmazzini@gmail.com>

On Sun, Nov 08, 2026 at 09:35:59AM +0000, Pablo Mazzini wrote:
> The thermistor readout is a signed 8-bit value in degrees Celsius.
> 
> Fixes: de34a4053250 ("hwmon: sy7636a: Add temperature driver for sy7636a")
> Signed-off-by: Pablo Mazzini <pmazzini@gmail.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/sy7636a-hwmon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/sy7636a-hwmon.c b/drivers/hwmon/sy7636a-hwmon.c
> index d51daaf63d63..f01f368d68e5 100644
> --- a/drivers/hwmon/sy7636a-hwmon.c
> +++ b/drivers/hwmon/sy7636a-hwmon.c
> @@ -29,7 +29,7 @@ static int sy7636a_read(struct device *dev, enum hwmon_sensor_types type,
>  	if (ret)
>  		return ret;
>  
> -	*temp = reg_val * 1000;
> +	*temp = (s8)reg_val * 1000;
>  
>  	return 0;
>  }

  reply	other threads:[~2026-11-08 15:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08  9:35 [PATCH v3 0/5] sy7636a: power the panel only during updates Pablo Mazzini
2026-11-08  9:35 ` [PATCH v3 1/5] regulator: sy7636a: don't wait for power good if already on Pablo Mazzini
2026-11-08  9:35 ` [PATCH v3 2/5] hwmon: sy7636a: fix negative temperatures Pablo Mazzini
2026-11-08 15:59   ` Guenter Roeck [this message]
2026-11-08  9:36 ` [PATCH v3 3/5] regulator: sy7636a: bind to the I2C device directly Pablo Mazzini
2026-11-08 16:02   ` Guenter Roeck
2026-11-08  9:36 ` [PATCH v3 4/5] hwmon: sy7636a: read the temperature only while the rails are on Pablo Mazzini
2026-11-08 14:50   ` Guenter Roeck
2026-11-08 15:40     ` Pablo Mazzini
2026-11-08  9:36 ` [PATCH v3 5/5] ARM: imx_v6_v7_defconfig: drop the SY7636A MFD option Pablo Mazzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8cc9a82-eb55-46fa-8632-c6ced9cb8d9c@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=alistair@alistair23.me \
    --cc=andreas@kemnade.info \
    --cc=lee@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmazzini@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®