From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Shuah Khan <shuah@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Kees Cook <kees@kernel.org>
Cc: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Willy Tarreau" <w@1wt.eu>,
"Andy Lutomirski" <luto@amacapital.net>,
"Will Drewry" <wad@chromium.org>,
"Mark Brown" <broonie@kernel.org>,
"Muhammad Usama Anjum" <usama.anjum@collabora.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 00/14] kselftest harness and nolibc compatibility
Date: Sat, 10 May 2025 08:54:24 +0200 [thread overview]
Message-ID: <d8d36e51-9456-49a3-88c4-44cffdcc5c0a@t-8ch.de> (raw)
In-Reply-To: <20250505-nolibc-kselftest-harness-v4-0-ee4dd5257135@linutronix.de>
Hi Shuah and Kees,
On 2025-05-05 17:15:18+0200, Thomas Weißschuh wrote:
> Nolibc is useful for selftests as the test programs can be very small,
> and compiled with just a kernel crosscompiler, without userspace support.
> Currently nolibc is only usable with kselftest.h, not the more
> convenient to use kselftest_harness.h
> This series provides this compatibility by removing the usage of problematic
> libc features from the harness.
I'd like to get this series into the next merge window.
For that I'd like to expose it to linux-next through the nolibc tree.
If you don't have the time for a review or issues crop up, I will drop
the patches again.
Are you fine with that?
The issues reported by Mark have been fixed and tests have been written
for them.
> Based on nolibc/for-next.
> The series is meant to be merged through the nolibc tree.
>
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
> ---
> Changes in v4:
> - Drop patches for nolibc which where already applied
> - Preserve signatures of test functions for tests making assumptions about them
> drop 'selftests: harness: Always provide "self" and "variant"'
> add 'selftests: harness: Add "variant" and "self" to test metadata'
> adapt 'selftests: harness: Stop using setjmp()/longjmp()'
> - Validate test function signatures in harness selftest
> - Link to v3: https://lore.kernel.org/r/20250411-nolibc-kselftest-harness-v3-0-4d9c0295893f@linutronix.de
>
> Changes in v3:
> - Send patches to correct kselftest harness maintainers
> - Move harness selftest to dedicated directory
> - Add harness selftest to MAINTAINERS
> - Integrate harness selftest cleanup with the selftest framework
> - Consistently use "kselftest harness" in commit messages
> - Properly propagate kselftest harness failure
> - Link to v2: https://lore.kernel.org/r/20250407-nolibc-kselftest-harness-v2-0-f8812f76e930@linutronix.de
>
> Changes in v2:
> - Rebase unto v6.15-rc1
> - Rename internal nolibc symbols
> - Handle edge case of waitpid(INT_MIN) == ESRCH
> - Fix arm configurations for final testing patch
> - Clean up global getopt.h variable declarations
> - Add Acks from Willy
> - Link to v1: https://lore.kernel.org/r/20250304-nolibc-kselftest-harness-v1-0-adca7cd231e2@linutronix.de
>
> ---
> Thomas Weißschuh (14):
> selftests: harness: Add kselftest harness selftest
> selftests: harness: Use C89 comment style
> selftests: harness: Ignore unused variant argument warning
> selftests: harness: Mark functions without prototypes static
> selftests: harness: Remove inline qualifier for wrappers
> selftests: harness: Remove dependency on libatomic
> selftests: harness: Implement test timeouts through pidfd
> selftests: harness: Don't set setup_completed for fixtureless tests
> selftests: harness: Move teardown conditional into test metadata
> selftests: harness: Add teardown callback to test metadata
> selftests: harness: Add "variant" and "self" to test metadata
> selftests: harness: Stop using setjmp()/longjmp()
> selftests: harness: Guard includes on nolibc
> HACK: selftests/nolibc: demonstrate usage of the kselftest harness
>
> MAINTAINERS | 1 +
> tools/testing/selftests/Makefile | 1 +
> tools/testing/selftests/kselftest_harness.h | 175 +-
> .../testing/selftests/kselftest_harness/.gitignore | 2 +
> tools/testing/selftests/kselftest_harness/Makefile | 7 +
> .../selftests/kselftest_harness/harness-selftest.c | 138 ++
> .../kselftest_harness/harness-selftest.expected | 64 +
> .../kselftest_harness/harness-selftest.sh | 13 +
> tools/testing/selftests/nolibc/Makefile | 15 +-
> tools/testing/selftests/nolibc/harness-selftest.c | 1 +
> tools/testing/selftests/nolibc/nolibc-test.c | 1715 +-------------------
> tools/testing/selftests/nolibc/run-tests.sh | 2 +-
> 12 files changed, 313 insertions(+), 1821 deletions(-)
> ---
> base-commit: 2051d3b830c0889ae55e37e9e8ff0d43a4acd482
> change-id: 20250130-nolibc-kselftest-harness-8b2c8cac43bf
>
> Best regards,
> --
> Thomas Weißschuh <thomas.weissschuh@linutronix.de>
>
next prev parent reply other threads:[~2025-05-10 6:54 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 15:15 Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 01/14] selftests: harness: Add kselftest harness selftest Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 02/14] selftests: harness: Use C89 comment style Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 03/14] selftests: harness: Ignore unused variant argument warning Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 04/14] selftests: harness: Mark functions without prototypes static Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 05/14] selftests: harness: Remove inline qualifier for wrappers Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 06/14] selftests: harness: Remove dependency on libatomic Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 07/14] selftests: harness: Implement test timeouts through pidfd Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 08/14] selftests: harness: Don't set setup_completed for fixtureless tests Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 09/14] selftests: harness: Move teardown conditional into test metadata Thomas Weißschuh
2025-06-10 6:49 ` Nicolin Chen
2025-06-10 11:38 ` Thomas Weißschuh
2025-06-10 12:09 ` Jason Gunthorpe
2025-06-10 18:48 ` Nicolin Chen
2025-06-10 23:46 ` Jason Gunthorpe
2025-06-11 7:05 ` Nicolin Chen
2025-06-11 8:04 ` Thomas Weißschuh
2025-06-11 17:19 ` Nicolin Chen
2025-06-11 21:47 ` Nicolin Chen
2025-06-11 23:43 ` Nicolin Chen
2025-06-11 23:51 ` Jason Gunthorpe
2025-06-12 6:59 ` Nicolin Chen
2025-06-12 13:58 ` Jason Gunthorpe
2025-06-12 14:27 ` Thomas Weißschuh
2025-06-12 14:58 ` Jason Gunthorpe
2025-06-12 15:23 ` Thomas Weißschuh
2025-06-12 15:42 ` Jason Gunthorpe
2025-06-12 17:53 ` Nicolin Chen
2025-06-12 18:53 ` Nicolin Chen
2025-06-12 18:56 ` Jason Gunthorpe
2025-06-12 19:03 ` Nicolin Chen
2025-06-12 23:31 ` Jason Gunthorpe
2025-06-13 5:55 ` Nicolin Chen
2025-06-11 6:53 ` Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 10/14] selftests: harness: Add teardown callback to " Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 11/14] selftests: harness: Add "variant" and "self" " Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 12/14] selftests: harness: Stop using setjmp()/longjmp() Thomas Weißschuh
2025-06-10 6:40 ` Nicolin Chen
2025-06-10 12:21 ` Thomas Weißschuh
2025-06-10 23:13 ` Nicolin Chen
2025-05-05 15:15 ` [PATCH v4 13/14] selftests: harness: Guard includes on nolibc Thomas Weißschuh
2025-05-05 15:15 ` [PATCH v4 14/14] HACK: selftests/nolibc: demonstrate usage of the kselftest harness Thomas Weißschuh
2025-05-06 5:59 ` Mark Brown
2025-05-10 6:54 ` Thomas Weißschuh [this message]
2025-05-12 21:32 ` [PATCH v4 00/14] kselftest harness and nolibc compatibility Shuah Khan
2025-05-13 5:33 ` Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8d36e51-9456-49a3-88c4-44cffdcc5c0a@t-8ch.de \
--to=linux@weissschuh.net \
--cc=broonie@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=thomas.weissschuh@linutronix.de \
--cc=usama.anjum@collabora.com \
--cc=w@1wt.eu \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®