From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48A1E3B19CF for ; Wed, 29 Jul 2026 08:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785313423; cv=none; b=p+ajfUyK29Ci4O2MIaEQdaFOWC7+/xLy1LqTk+uz1APjNgiScMWZCTPjSmuPmCamqhy+P1QD/Nouc6XN0tPstJ4ASGGCHQPlqIC56wqU3GI50GUkymttPeLOlqLHyNSlZmLBcbqhPOEZh+MbnTAAUeHYP9LTXjDRm4go1PDclyY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785313423; c=relaxed/simple; bh=e8PJfKrLrCG9U8WWK4qTGA5AcNgKgTa7lLIOwkt5u2Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KRoK2a5gDHS9MKW7PjJGi3Amz229dYx3qVzRjGg18xl3Y1+tE64p2zkzphWnv9OJThgCkkhzfiKEnd6TRenrA62qrVe4jQS7Iap6C4a3vlLXDPlyGbkYTAFQN3yjFqENrtHQgxfxEgZfo7my5CY5+dm1BKH5QCTHepZl1xdKSEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=n5+cS/MQ; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="n5+cS/MQ" Received: from [192.168.88.20] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D113819C; Wed, 29 Jul 2026 10:22:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785313340; bh=e8PJfKrLrCG9U8WWK4qTGA5AcNgKgTa7lLIOwkt5u2Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n5+cS/MQMafsM+2y43ydIVKYbUyFsEr/yd+cly5bsbqGbwDwAy7vyMsEVgbLCOP9v wI7IX/nPLChgDeIZqrN21GPZfzioF7L02tgKsHroEbqQ8k4zzQ1v4383QKfCEfd5NL zn6/sG2Ohafc4/8DEXDsx6l7BOKpniTmQQHWi0AU= Message-ID: Date: Wed, 29 Jul 2026 11:23:21 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/omap: dsi: do not copy isr table To: Andreas Kemnade Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter References: <20260702-dsi-uaf-v2-1-dbb4aa0f0b8e@kemnade.info> Content-Language: en-US From: Tomi Valkeinen In-Reply-To: <20260702-dsi-uaf-v2-1-dbb4aa0f0b8e@kemnade.info> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 02/07/2026 18:27, Andreas Kemnade wrote: > To te able to unregister stuff from isrs, the corresponding table was > copied. Nobody seems to unregister stuff that way, so it does not help. > But there are stack-allocated objects passed to these isrs giving chances > of UAF of these objects if irqs are unregistered while they are handled, > so better do not copy that table. > > Fixes: 4ae2ddddf44cd ("OMAP: DSS2: DSI: Add ISR support") > Signed-off-by: Andreas Kemnade > --- > If this gets backported, it should be re-checked that > no isr unregisters itself in older kernel versions`. > --- > Changes in v2: > - remove variable definition (Sashiko) > - Link to v1: https://patch.msgid.link/20260629-dsi-uaf-v1-1-a5e894f4e4d1@kemnade.info Looks good to me, applying to drm-misc-next. Tomi > To: Tomi Valkeinen > To: Maarten Lankhorst > To: Maxime Ripard > To: Thomas Zimmermann > To: David Airlie > To: Simona Vetter > Cc: Tomi Valkeinen > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 7 +------ > drivers/gpu/drm/omapdrm/dss/dsi.h | 2 -- > 2 files changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > index 27fe7bca9e2c..70cfb779d6ae 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -455,15 +455,10 @@ static irqreturn_t omap_dsi_irq_handler(int irq, void *arg) > timer_delete(&dsi->te_timer); > #endif > > - /* make a copy and unlock, so that isrs can unregister > - * themselves */ > - memcpy(&dsi->isr_tables_copy, &dsi->isr_tables, > - sizeof(dsi->isr_tables)); > + dsi_handle_isrs(&dsi->isr_tables, irqstatus, vcstatus, ciostatus); > > spin_unlock(&dsi->irq_lock); > > - dsi_handle_isrs(&dsi->isr_tables_copy, irqstatus, vcstatus, ciostatus); > - > dsi_handle_irq_errors(dsi, irqstatus, vcstatus, ciostatus); > > dsi_collect_irq_stats(dsi, irqstatus, vcstatus, ciostatus); > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.h b/drivers/gpu/drm/omapdrm/dss/dsi.h > index 601707c0ecc4..2b25247ea893 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dsi.h > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.h > @@ -379,8 +379,6 @@ struct dsi_data { > > spinlock_t irq_lock; > struct dsi_isr_tables isr_tables; > - /* space for a copy used by the interrupt handler */ > - struct dsi_isr_tables isr_tables_copy; > > int update_vc; > #ifdef DSI_PERF_MEASURE > > --- > base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482 > change-id: 20260629-dsi-uaf-71bfbf3553bf > > Best regards, > -- > Andreas Kemnade >