From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754437AbcGZG01 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 26 Jul 2016 02:26:27 -0400
Received: from mout.web.de ([212.227.17.11]:50277 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752969AbcGZG0X (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 26 Jul 2016 02:26:23 -0400
Subject: Re: staging: wilc1000: Reduce scope for a few variables in
 mac_ioctl()
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
References: <1c4cac35-dded-ea88-45aa-3f8ac098289d@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Steve Caldwell <Steve.Caldwell@microchip.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <d8d9729c-6d65-a901-1b29-c0b031e143d2@users.sourceforge.net>
Date: Tue, 26 Jul 2016 08:25:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <1c4cac35-dded-ea88-45aa-3f8ac098289d@gmx.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:n/tWQ8jvEWFu2kpb01foyGi/X1itb8jYLpS60Ju0GYOoLupW+8y
 pyzgUn8eK28aAAVrHCuEEkuxk1mhe+rv9TnLJFOa62ecy1uTAs5N4/T0MqNbIKDtRIOexfk
 IkKQnC6GF/yeiAhS3xYtr8pXMyD+S9FiOJzGQmVfknG5LmDTNNxzyuB6fICp0CU6ilKOEi1
 Uwt+qVAAKo4hZKEpuX4hg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:GoiokHnewLw=:3qcUODTzVzksEUTrKIIoT7
 moY9bOhd3NO8WvoyifVsYCrDjr74V/+qbr1Y/2jyf3cizoojESGbKtjWI2gqWTuszrkFLeR2w
 UfPJNvz/Pr7mb8qg3mbCfOQk4tUXY5OjCZvyPOC0waG0mJResFsapjuQht5Ci+/q3nH1VAEoC
 bqqhikvibmGohg952WPeowZtCLQyJxryZjsVv+CCXmkvDH6n4ZjGB1MrjxdPy5X82PREmQgD1
 lgQWC1FF4q2FF72yEj0E3/uFxLZCAHk6AthKMDS4acHzu4rA3HujrbuEUjIuUO+u/Lsizx/nb
 ur8C0bxp2jao+3ybX5gaxEJLz2SrqmcC9Yiz1e4Yd3mfLsvuiYyJqtxbPEBPYHTvIkB3GeUsd
 KsE5RgRnS3/Oi5SxyK6c+F8yxP5s//j9ECM+EF8h+K9rz828DBqQdoAQ8JaLl4dEMB5aT/gFP
 ZqjtZxee5Wkc6VdXOB0fvIG3sUJyP/noIqiaLymbkDtddcyZolJH8FGDNX1lNZ/Q9nKoOgUUq
 lx1GgzohkWF0l5n7GnPtzeJHFR7Iw4+/J9nO8xGdr9jMb9EWeuBwY21coCsTVnO5Zm4Sgz9jZ
 8chlU3mGjrLtAm6ALXpQwv8pssnDrcA0DWMAMqxd+4XCrUQ+vWnVRjvDX6hIXp1Nu7ONbwOH0
 PK8xPxZ6HipMUjX/jJDWTi6b/svk1yOjJuaBmG3YvdvuxV929sEWllqVRIPCnuqfsyzgWSuJd
 0u1eGAnNKyV7raUVJXflrCWKsPjGSJl4ZZ5FKGQXHqWOfUKHfLeW1jxBaetlKvcuGXy8xvYEz
 ot6mg4c
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> -			if (strncasecmp(buff, "RSSI", length) == 0) {
>> +			if (strncasecmp(buff, "RSSI", 0) == 0) {
>> +				s8 rssi;
>> +
> 
> Um, please think a second about if it makes any sense at all to compare 
> zero chars of two strings.

Under which circumstances should the variable "length" contain an other
value than zero?

How can this open issue be fixed better?

Regards,
Markus