From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3537F12BF24 for ; Wed, 15 Jan 2025 15:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.177.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736953860; cv=fail; b=aYvF14rYhXrD0na9OkpBX+fQsDIkDrAuXPUwuPINCKJEdijPPOvwAVC+13brtADOeein7Cp446o7OHwE56qBjuxw306ZHXdwWpB1a28rOPvZKD/xUmdG/Kyw/83+f/43Ai0xr094+zbLVxQ0jnDHJCyaU92qyx5SIkbc3X7I90o= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736953860; c=relaxed/simple; bh=qByGRCzKtdcqBYrj5goC7EiqFLOiy7gI6g3exJX9Nnw=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=OQFs6chjtWIFzwK3eyHAyu4HufzMD9u892eLYRFU7WZUV3KIyIwKDV6bB+PLxcDJFHwO4fmbo9Edw9r+p+PA8cphK0exhGZFFCyQC1Mz/Se5rN0yQQI3vOZ5x1vIg9USr0swm18XvckEnXQiW6qlg4kEfAWIJKXDkBFgNa+C96U= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=BIeFIiCr; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=cnsFyGBv; arc=fail smtp.client-ip=205.220.177.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="BIeFIiCr"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="cnsFyGBv" Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50FCimDK019490; Wed, 15 Jan 2025 15:10:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=NmD6hB2VlW5mmBrHCBnQanX2Ac2Kf+PyuA9wKv1r/tM=; b= BIeFIiCrClxfQhS+zN98iq0AgvahxbqQO9GObDmZv+c4Q4Z/3ZcQBC/m68+8wtHG 3X669p72viPHmwxhQqNPAfycgs3SEsylArPH+98nb3A5DvVnTUKfVTlK8ZCMy8GX xm4nVgYtGalYNbVeW/pcm9Asj/tlaux8SxDn2CN6SYJEwzPX7XI/0s1q05KGdU7y FRUBRjdws5jlT5IiVOMozOMw+S4rgwM7+bBhnHrBgRUU5avDSXcAw3PlvZ/t8JYA Ct5tv6e9/1l3+p1M4UtQfo9gTCOdgwoHN3mVFK2rQLiUP/uWAd62vXsOuKi0+9if 2rY9wodqgVVCsTPD87Yyxg== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 443fe2gb8d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jan 2025 15:10:53 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50FF5hA1036362; Wed, 15 Jan 2025 15:10:53 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2045.outbound.protection.outlook.com [104.47.66.45]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 443f3a46tg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Jan 2025 15:10:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=onmLk/zFDpOrjN1/JouVvp96CwAA/hJJYqTgMSoqOO78l/lpJ+xynM739K3EfNjvGlCIR4J0N+4/wygBJvUuAR7jqmayGR+OAUNjdP8T4ZTYDO9DAjUFkrwLYXQ+gxq9VQrb0XGEoHxefV29ICKx9LEYwwh14zRgFBOg65ou/d6LDogFUslbqUhLn8nlHGtXcuYAw+/TJ0PW/6+5hzyyBJRARmOfFTaam1nrGN+SMu8eTT8zAoEuWb/yy5SiFedMvaVyxdCFV/X/2N1ADS/JIooSpd7frOPIdkfAqp/QS67xh7N0UCbqDwE656dC6q1A6U4IbXMGwpBejhs6TvCquw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NmD6hB2VlW5mmBrHCBnQanX2Ac2Kf+PyuA9wKv1r/tM=; b=DIncStlBa3IVFbTFlJL5ha25HhEgbw7xwHl4Wm77Mu9z0ofl8dx1M0oo/Ldhd2D4BKynYqxnRSBHIwyxRYxWG4rO1aifzp+M/tSB5NGHaQXQgVeL/38R5jVIaSusbuFvL23bryXBLRhjEWqesBMhffP/duLGyOHhziKNvpoKzhmXm97bJUN4TpMwr6115eWRw2rAMGhrSSxwM/DTL1U7zmbYDyuxqbWQCOOdVxDAXwirkeLVZ3ASDyQ2elKWO2j8YROwpzK4RAGOzlzmFDPi3W3+O9g1zftigTWSAhAy+dDzpRjzGOYoV+t0IGDQx20OscSXuILuw2qu7RyOLmPSBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NmD6hB2VlW5mmBrHCBnQanX2Ac2Kf+PyuA9wKv1r/tM=; b=cnsFyGBvmEasYIg+2J3lkxbSSB2gvUS5zRYmCsFXcMY6KAn3Lr4HPu3IVoB/nFGfcCVMbAx4OHHxuXZ6V7mE7oO1+wa0JT7Dt3lJJLHpZxexxDpNx0cTWQ/EahU18d3sQ/X8u+xs6JsQrhTF36SJAFCDodPUU+XCQK0dXDoXZEU= Received: from CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) by LV8PR10MB7798.namprd10.prod.outlook.com (2603:10b6:408:1f7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8356.13; Wed, 15 Jan 2025 15:10:50 +0000 Received: from CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562]) by CO1PR10MB4468.namprd10.prod.outlook.com ([fe80::485e:729e:c0a4:e562%5]) with mapi id 15.20.8356.010; Wed, 15 Jan 2025 15:10:50 +0000 Message-ID: Date: Thu, 16 Jan 2025 02:10:44 +1100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] timers: WARN if add_timer_on is used with offlined cpu. To: Thomas Gleixner , anna-maria@linutronix.de, frederic@kernel.org Cc: linux-kernel@vger.kernel.org References: <20250115134111.2703089-1-imran.f.khan@oracle.com> <20250115134111.2703089-2-imran.f.khan@oracle.com> <87wmewb0p8.ffs@tglx> Content-Language: en-US From: imran.f.khan@oracle.com In-Reply-To: <87wmewb0p8.ffs@tglx> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BLAPR03CA0153.namprd03.prod.outlook.com (2603:10b6:208:32f::19) To CO1PR10MB4468.namprd10.prod.outlook.com (2603:10b6:303:6c::24) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR10MB4468:EE_|LV8PR10MB7798:EE_ X-MS-Office365-Filtering-Correlation-Id: d7054bd1-5b03-4d9d-945a-08dd3576cc2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y3ozQkYyUXlJeFJ4OWtlY2o1amxPYWFqU2poSjFKQ1dxVkMySERJZVE0eE5C?= =?utf-8?B?ZEFGMi9LTE5sbVprZ2NJVTNGekhsb09UaFB0U2FRQ3VCRnEycFo2WlowVDBG?= =?utf-8?B?RDMrSllSRG4zdzJEeE55OUJYQmRwUmhNOHg3NnVpcXZKN0FHc0tRb21CNVVN?= =?utf-8?B?UjBDZEE4aTdlUksxVU5MQXcvWEgrVm5ieVF1bmhHREZhMUZmRFlGWG9NMzh3?= =?utf-8?B?K0c0enZUV2JoRjBmYnpBeC9SSS9pUDM0NFIza2Z0cGhXdFJvQ0JGdDVzcHFG?= =?utf-8?B?NkNGQy95cmp6SkNuUUdxS3NTdUJ6Mk1JUGZjbSs2ZWJaNXYweFlBbm5IU3d4?= =?utf-8?B?M3paZEFWOWFXWUtwWkFzWTFoN0tSUWJKZHZpQnlUSm5oUTJBWFVwTFVVdmho?= =?utf-8?B?NlV5cTJCZ1E0SlpzMCtJVy81ZTVvMmo2M3FZV1h3dHMrYnltZGwrY0I4KzVC?= =?utf-8?B?eHlpZ0dtNjZhQUJRUUh4RGNlemY2OG5pUXFnYVErcnJ2NmFpV2hkZDV3TmY5?= =?utf-8?B?NGw2OHYzSk8zbDlCbWZsdHVLYnJTYzc1ZXkrTEJvNzcxTVQyVjJ4ZjVqUHZE?= =?utf-8?B?N3Z1NkdjZXBqVEhRejhJcXdkcHhDTkY4WUh6OGR5ZHpkK0ZVR1N0R2dnQWhu?= =?utf-8?B?enRONnN0Y2FDOFR3NWtsQlNwQlRNeHZVelduYnE3RGhBZzhxK25FRWw4dE5u?= =?utf-8?B?WDZjM1p6NzBwUEFqcEtOdXNYb0pKbHVzUmQyWVFFemYrRk1uWTBGSVNaMW4z?= =?utf-8?B?MUk4SExST0l1c2oweVV1N1FjSFllSkw4SDFXVHpINjNlL1ZXLy9Qa2FDMmlq?= =?utf-8?B?SGlvbVMrdkdVU3dVdmp6TEZJSXVjVXhKMVZhU250ZHBBeS8valcrMEllTmdk?= =?utf-8?B?NXdFMmQ4eXNTS01MN3VPYWFPWGtKTU9uNlprVzVEZGtFNTV1VGlxWjhLRGMv?= =?utf-8?B?RHNSeHVCbG5SaHNTMGNDRXhBRm9RZTJuUjRGN0RkNnNVLzgvOE00Wnk5bDVw?= =?utf-8?B?bDM2TGVXVHVlQUZ0cWh6TDBqajZlRDRTeEZCVDlVK1ozMk4rOWpDbmhoNk4y?= =?utf-8?B?MlkyellETjFhT25jT0RMZGxOdGJ1Snkwc2xhRTJENFhmbzZKcHMxOFErT2xZ?= =?utf-8?B?THp6ZVZDUUM3TlR0OGovUklSVytBV3g2dGVUbS9JUG5pN3NRM3FZcnlhbG5h?= =?utf-8?B?VUltOFBEK0NaUXhuakY0UlhzeVZEOTRjNDIzaWp4NldaMERtRHl3eDZETXZm?= =?utf-8?B?amttMis5V01iY2NON2pTVlZrMXROVzlqdjhUU3d5eFVDb0gxamlIemlTSTF0?= =?utf-8?B?QmU1MFB4UnNTMytlMDlYMllDSHRzeGFOTlE1a2R2eHhEb3d2dytLZUQyTGQ0?= =?utf-8?B?NnByL2w1bUhySzlYZXg1UXhiRkErYzhORDJUYkJDTC81NjFWeUpIWjRLWHhs?= =?utf-8?B?VkF1L0duZ3JVQ1AxRk80SU1NdS8zVGVtK1d5QTRGZ28wWnNmdVFHZ3lBSFFk?= =?utf-8?B?cWIrM0dnNkVhZm8yc1ErUGJoeE9STVA4R3d1bzh6WTV4UHVjZm53dm8wYklB?= =?utf-8?B?QzBXQ2hYTHhpTjQ0cEQwQit0dEk5SDhPeEswWjVha2twNFNTWWRoYnNEVmZn?= =?utf-8?B?KzBkRS9jVmlsRnprMXZpZXNya1dLZGljdk9HWE55eWdCaDhWdFpvMEdKbkFO?= =?utf-8?B?aXVORGErVUtVZWlhUmpOTmI2UzlNVG8xSU5mbWhJQ0tqTVEvRjkwaVR1cUZI?= =?utf-8?B?VVdxODZIVkNmWVgyY1ViMjFxQnhyeTMxRHhhUmJaYTUvakYvY0FxUmtVV2wz?= =?utf-8?B?bzdqT092QlhVdWlhSmVNTjBqMzUzenh1N2hGZjJ5M00wL2NSaVpqOGlVMjZP?= =?utf-8?Q?2/FoRgqz7uq1E?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4468.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dnpyTmdsVmNRNnZLZnZ5aWo5L3FybExlYmdFWlZXanI3eU1wVjYwcUJxanhS?= =?utf-8?B?dWZyUzdQMnFoeE5aUzRkazZ5NkdXV3dKZzhCMmF5ZENPVXdkQWZYYnpqekFJ?= =?utf-8?B?YjVhSUdNbkpkcnhuRTRGR0NJYzBVUVhnTzhMRm84R1VrYWxxZHlaYzRGNVY5?= =?utf-8?B?cSszdGRTNkZabS82RXd3ZkhHdzdpZjVlWGg3QUVjU2p3MjNZdStQRDZVMUFr?= =?utf-8?B?eHZMa3llQTAramV4dUZtQ25mcDVJeEFwU0h2MFVkMzVzbTAvdWkrTWJFSTRl?= =?utf-8?B?UzUzazY4V2ZYWG93Si94U1M5alFFU3JucTdZV0lZQ3J6V3lFeGo4aXprVDd2?= =?utf-8?B?Y3ZqalVYSk1MSWlBK2twQi8rUlFPTnlFYlkyeG9mMkZrY2haa0NoanZuOXZx?= =?utf-8?B?eGJtaWJXamRYSlVFNGdHUFlxYzdRTHJIUXlMU3VxNCtldkZwRURReHJYa0xs?= =?utf-8?B?V1V2TnM4YmFJVExPWC9TU3ZGL1o3REdJdzAzK0JNYzV6TUs0L3NRTU5KSHlF?= =?utf-8?B?TWJjcXVHdXEzQ0dSTG40QmloR3R6Ni9YbW1CYW91WDJrWWE4TGkzMUw4TGJB?= =?utf-8?B?SDdzVEVWSzNCZUJsU0FpZm5JcGoyZDB2R2p6RDFUYVVlVE1ZWHplL01pekVC?= =?utf-8?B?ODRrdkJucEdDeG4xSkRIeDlMUnhiNWNzbCswQi8vVkVtalJySXkrSUZtOHBG?= =?utf-8?B?QnVvazF4cDRuUm8rTVRZT1hWbE5LNHprY1B1VWI3ZDZxUDdZL0ZOaTNYS09p?= =?utf-8?B?Q2RwVjFCY01nSTFsem5uRmQ0YTZReWY3YzdvSTFMUVhtS1JSalZNUHJERkIy?= =?utf-8?B?NytiblNLYTBRUWhQMnFFTmJERW96M3RjVzZoSkNqSXA1dXR0SDIycW5Ua3Fr?= =?utf-8?B?Tll3dHpaNXVsL2NBMWdmQURub0VuVVlRbHlwWlpjWUZneTdjMnQ4TE9kbnJr?= =?utf-8?B?Vml5eWRhRVd2NmVzMkhHOUdrUlZISjhPNkFacG9zM3ZCRGNFL01iMXc5MHpZ?= =?utf-8?B?ZE1tRkxlSnE5WlFoUTl0WWdxRXJ2STYxaUFqKzFyUVc5aDhaMHNuVFZGTkdF?= =?utf-8?B?eUFZRkIwaVN2Ym1FQVBLc0ovVUh2Ykx1VFJRR0IrVXFid25MSjhnZE1pWm81?= =?utf-8?B?eG1ycFI2V0lyWHNZR2dTRXNuYVJRR0dERVFid0lBYUJwaUdNSmM0VENUei8r?= =?utf-8?B?T1NMMitlcDFWUVExdFBQdUhBTUhicXN1TUVDWnVzSzVxUXYzNTBDMjBrYUJx?= =?utf-8?B?NlNvbGJFN1AzaXRidDJKcGNpcXhlTWJlOGNsRWI3aGd5Tm9PTGdwbUZqREhk?= =?utf-8?B?R1dYQllURTY0dUFWTS9YK0txNUtLTCtmMlpJSHVPVm9TUkRCbTFwMGNKdnd4?= =?utf-8?B?UTBKNjJ4RWV4RTdZN0pWK3JaWUNlWWI5dks1bDRXeVgyVXduWWlGWWJTYmth?= =?utf-8?B?Z3lxMU9MazY1TlhKaENzSlhGMTVneWNVSW53MC9QYmVYTys3b05KMW9hNFNs?= =?utf-8?B?ME9EVmV4bnVQcmxiR1VLZmNRcGkrbzh0aE9CL0Nna0JRVjBHazE0cm9CdkZq?= =?utf-8?B?VmFSaElMZmdjc21ySGw1S2U0UGQzYVRVU2grSG5HOXE5QllBZnByL3JHUkxN?= =?utf-8?B?VWVyYkpUS1ZLcHJYVlg5ZUZySVJDUWUwK3ZuM081akxQZ0grcUlZUlRocmRv?= =?utf-8?B?eE55UmxPdTdMUmw0V2RMWjBxMmVmVlpnZFNxNWl0bDNsRGpHQmVRZlBCRXFr?= =?utf-8?B?OG12VTJRZFJGcW5TcDErZVVBQ2RjT1I2ZHJ2TTR3aldSbDNlZmt3bUVJZTl2?= =?utf-8?B?UmIvK0RFSlQ0Y1N2ckQ3S0VjbkhiZ1c1WStPRkxLY3NkTDhpYTJqUk1aMysy?= =?utf-8?B?TEtMZDRSZk1EcTI5RTQ3SkkyUThyNEt4cFlTRlFoWTN3TGFNa0tVVkoyTTRT?= =?utf-8?B?NmVQaWNJOVRCQVZDNzBuN3ExYlFRT1cwUms4OC9uWXF5TG91Qm5zOXFWcG9Z?= =?utf-8?B?QUR4bUlJZ0JER3BJeGdEWXZ1WkM1ak9xQmZpWWJVRUVjTC94WVpIdG42Y2lM?= =?utf-8?B?MW9Oa0dscGZGbW1kemhSRkM4NWw0aERSK1RPS1N5WkVadzJ5djNreUl5NmQv?= =?utf-8?B?R2J1cEFJTHRkSUI3eXRrOVJwcy9GcGlGcmZVY25NSjNHVmdzaVlka1J1SkxO?= =?utf-8?B?MWc9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qqvILUcRwby8W8z7oiD7T7HqVAzEbOHmlYhEcjyffVig6jDfQUuyPTE+egTR5pDch41fHTYDOTtmnWHvmMpcwdnDxj9adnk83G4sIcbZ2WvQe0HmnFas8DdG8CN/OcmDySti+8AZ0AZDNTqfBH5jI25/H/qmubhloZoQcd3LL5LMTM/0l+RUprpPuyylTC6y890DB5uGLPKbLxzq86DJCHAdE7821OBqhNfG3/QSbIqTSpDmTEVXjJJAbccb3Rvy0Ar09GmX/QYk7rtqaez1PT8sWZMNirs9SEde1cplCQ6WHPSccGDaz/fP+7C9YhoES5RFd4m1o1zwnqU+lDLQ0wnTTFXDdHfEJ835vhNuy/KNtHze+JZSfLBl1HvmsTyDq4H3qHS1BAV2x6VP3D7GwSImDth0w/UoVCtrrTpNxmPmBoiWERtg/PahHjKJyLjOgbFRcBslHQSknyCp99YzRhXEiTOi11sNRVNK9sNISauuWWuaLozeb7fdIFn78vIa8peiyGrEVE+S4839FkmGjQiNBGcn52jo15iCpPYrH0OaUcb7O/4UHThpUHnEtLVWNWLIB0PWKC0Lp9cXkmM0Bqq+3eGuWu8T/Piu9Lja6Ac= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7054bd1-5b03-4d9d-945a-08dd3576cc2b X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2025 15:10:50.6328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OSNDS4nJKaUmZd/B5EksbM67MsJkNBFnQJs3Co0EfGUp89Y2MywtGCAHDqIxwyE0GznFPvu8EJoRzTj8+GYG/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR10MB7798 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-15_06,2025-01-15_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501150114 X-Proofpoint-ORIG-GUID: mCHlbI_e2HlzhjeGPAWAlHjbT3oRudEh X-Proofpoint-GUID: mCHlbI_e2HlzhjeGPAWAlHjbT3oRudEh Hello Thomas, On 16/1/2025 1:39 am, Thomas Gleixner wrote: > On Thu, Jan 16 2025 at 00:41, Imran Khan wrote: >> timer started on an offlined cpu will not fire after >> its expiry time and may never fire if that cpu remains >> offline. >> So add a WARN_ON_ONCE in add_timer_on, to indicate >> if any of its users are (wrongly) starting a timer >> on an offlined cpu. >> >> Suggested-by: Thomas Gleixner >> Signed-off-by: Imran Khan >> --- >> kernel/time/timer.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/kernel/time/timer.c b/kernel/time/timer.c >> index a5860bf6d16f9..ec9eb58e45241 100644 >> --- a/kernel/time/timer.c >> +++ b/kernel/time/timer.c >> @@ -1370,6 +1370,12 @@ void add_timer_on(struct timer_list *timer, int cpu) >> if (!timer->function) >> goto out_unlock; >> >> + /* >> + * WARN if specified cpu is offline, because on offlined cpu >> + * timer will not fire even after its expiry. >> + */ >> + WARN_ON_ONCE(!cpu_online(cpu)); > > Then why queueing the timer in the first place? > The queueing is for the case, if the cpu becomes online again. Warning tells that timer is being put on an offlined cpu so may never fire, if the cpu remains offline. But if the cpu becomes online, the timer will fire. Or should I just return after warning, like currently being done for timer_pending. In that case I can move the warning before lock_timer_base. Thanks, Imran > Thanks, > > tglx