From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Doug Anderson <dianders@chromium.org>, Nikita Travkin <nikita@trvn.ru>
Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, konrad.dybcio@linaro.org,
quic_srivasam@quicinc.com, judyhsiao@chromium.org,
mka@chromium.org, cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v5 3/4] dt-bindings: arm: qcom: Add Acer Aspire 1
Date: Fri, 7 Apr 2023 21:33:34 +0200 [thread overview]
Message-ID: <d8de5632-09f9-565a-ec06-814cc23c12ea@linaro.org> (raw)
In-Reply-To: <CAD=FV=VQKS1J42qx-Zk9JKwRUeX1evQjZzs_RMAMFby-gaNDXw@mail.gmail.com>
On 07/04/2023 18:23, Doug Anderson wrote:
> Hi,
>
> On Fri, Apr 7, 2023 at 8:14 AM Nikita Travkin <nikita@trvn.ru> wrote:
>>
>> Acer Aspire 1 is a laptop based on sc7180. Document it's compatible.
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Changes in v2:
>> - Merge with IDP (Krzysztof)
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index f8d29b65f28b..db97a61e8ccb 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -367,9 +367,9 @@ properties:
>> - qcom,qru1000-idp
>> - const: qcom,qru1000
>>
>> - - description: Qualcomm Technologies, Inc. SC7180 IDP
>> - items:
>> + - items:
>> - enum:
>> + - acer,aspire1
>> - qcom,sc7180-idp
>> - const: qcom,sc7180
>
> If Krzysztof is happy then I have no real objections here. That being
> said, I personally would have updated the description to be more
> generic and not say "IDP" anymore. Something like "Non-Chromebook
> sc7180 boards".
I am fine with both - dropping the description or changing it to
something meaningful.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-07 19:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 15:14 [PATCH v5 0/4] " Nikita Travkin
2023-04-07 15:14 ` [PATCH v5 1/4] arm64: dts: qcom: sc7180: Don't enable lpass clocks by default Nikita Travkin
2023-04-07 16:22 ` Doug Anderson
2023-04-07 15:14 ` [PATCH v5 2/4] arm64: dts: qcom: sc7180: Drop redundant disable in mdp Nikita Travkin
2023-04-07 16:23 ` Doug Anderson
2023-04-07 15:14 ` [PATCH v5 3/4] dt-bindings: arm: qcom: Add Acer Aspire 1 Nikita Travkin
2023-04-07 16:23 ` Doug Anderson
2023-04-07 19:33 ` Krzysztof Kozlowski [this message]
2023-04-07 15:14 ` [PATCH v5 4/4] arm64: dts: " Nikita Travkin
2023-04-07 16:23 ` Doug Anderson
2023-04-07 16:46 ` Nikita Travkin
2023-04-07 17:06 ` Doug Anderson
2023-04-08 7:50 ` Nikita Travkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8de5632-09f9-565a-ec06-814cc23c12ea@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=judyhsiao@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nikita@trvn.ru \
--cc=quic_srivasam@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®