From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f97.google.com (mail-yx1-f97.google.com [74.125.224.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5076400E0F for ; Thu, 11 Jun 2026 16:58:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781197121; cv=none; b=If7gdANLu/PU1ZFyL3x9pzI6jCk3SV0yMwMxddNZ5fBOZzYxR7IhFvV11BicZ5bB9jT+ck91RkgUaaLQyjV7I18UokZe8rPrcRYRN4aR5ODnBItadrr0SGcijOW93qqskPErf0RMQHKoEnkOXO87cTLnUMrP2WaxCyGZp4qaMxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781197121; c=relaxed/simple; bh=MtH5MrqfJ0innke6B507gEspNv/Po+C6OSD5D0FLWHU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JRztd1vh+W5M0ybDFOvwrb0OuYp2NwSpkn8AOW9IazdUtjwqzBDqPvCol8a2QzubR483KayzOebGtsQ5NPa3ZlFOR3WNoPO04+/6i05ggh1YPIgAUQsqIY/vKGrV+nauVt55G9X8wnxkD4RqL0CIladYPSVJTvB98WBKHw1Ppac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=hxVxaaVz; arc=none smtp.client-ip=74.125.224.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="hxVxaaVz" Received: by mail-yx1-f97.google.com with SMTP id 956f58d0204a3-6605469c263so29689d50.2 for ; Thu, 11 Jun 2026 09:58:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781197119; x=1781801919; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z9ksOv65wdintddQvv5k0AzyLLccSaifyeuockXa2a8=; b=nhRtU7P93KI74TAmh4isKOYh6BXeU+ajz8fNbcS3Guqh2i7EnIAzzS9sgWfzdQ4pUA FRXCo1EgqGmoqEZ7f9HjaQDy2Uh4n92AELBPloPLsWQ4TytJSzZiq9D+HDx3hD1vvwjb ZRTJ/Uuda8PgfRF0c0Llf/PBca0pwnVlU5X1BIyOXPo115tO/MmVKbr6yCAWRJtM3zGy q43VgebIHoinaillwNINWkIdlbVASU3b/+yxHIw075Q+NaeQH7XoJdMc6dnN7DbkVmaB u2jGoFwRPIkMQcYKspWZAD7SLbbbbkjD6LGmm0OQ3eX4gnY8HHJIp+d1/YVpC18tsQX6 TWWA== X-Forwarded-Encrypted: i=1; AFNElJ9TZE7/4YZJYkU/cKW4Rd2XAt90CFLTKU5pgD1GSnv6Ps6qTrv2V0jyGtEjgGxIMuvzRsnK8JjsKe5WnHM=@vger.kernel.org X-Gm-Message-State: AOJu0YzBAUdBJfhsuqdA79HGSlHr1a/sASvxG5HKb66fsD9CPsNMAE3+ 14qnBfIHYscpA81K7fvFVVsKbqnbXysTiQ/Fd21ZURQQxelHxYHKZ//ANi+BOmka25pNei11/3G VivUe4Nsr03NntWpJDHYHGKSStJee0YTRJ/Ept3OLdQxuOC7B9UPBsdOCwMZPMGPzqH3aR5HZvq mmdSVu293AJ54BLsFdUPaUWxwga95p1UEs6iPpb+3tnk+6c3n62LsSlBkSq4REf9Hol8U2lDQln o/E39U8EbKcynl+sw== X-Gm-Gg: Acq92OEc0m6+/oTJKpMJFJ2Nl6rj22BDMMJ4Pt0smdImzuyB7cJCMuqGtajR/H0niDp +hn+F4cWLhDpFvPvCHYXdNduK/ETxkOu/38OlqAJJcTVxzMpeRfS6EAeSrspsPzAOJGgbVsG3Ui TURs5Pz+9fVPCu1rZO4vXnzECheEq+OddHJKOJTHUknFxQBqrlXexqJTUOUl64o1yjbxb0+QGx+ JT9q7MtUq5HEHM0EbDQHfIY1gB7njzaqmjxW5L98rtMgrQP8qF0Y7aJCGPPDbzmYVd9q+tA4+h3 u8PXfORQEMUOI1jw/FRJQACqxAci3Fn/D0BhYHtg4pRT4gU910U4UnwWHCTztRrgMDO3kOj59k0 mxoPx4TCvEkTy+wvTIjtMdRnzeiz4YkDlvwwnU21SWcM1Ryqwg2MsCkqqnPJMvhv2jg2eySNKk5 h6lWh5mm/wpKTeQbtnZB+6Q7iowGs5QcZ5oSihJ0KMsEXhXo0fzWgvxsBF4Q== X-Received: by 2002:a05:690e:d58:b0:65c:47ad:26c2 with SMTP id 956f58d0204a3-6626962cc11mr2845350d50.15.1781197118682; Thu, 11 Jun 2026 09:58:38 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-66274d8607asm3393d50.14.2026.06.11.09.58.38 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jun 2026 09:58:38 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8cebec24b12so1995136d6.3 for ; Thu, 11 Jun 2026 09:58:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1781197118; x=1781801918; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z9ksOv65wdintddQvv5k0AzyLLccSaifyeuockXa2a8=; b=hxVxaaVzM/qeI2pr+Jz1g0nnEz1Ta2Db/tkBXQG4vscYSwaVWRj1bfN454HPtHsY1N S/3yj7VIwamXTGrQcLCqofD/hHbF9MR1sFy1h6V0DvYa7Q13qLaRt1uQGqw1mZfz5ZlM 08xBZxWNuWxyWEBINEs1PkKA7TkT5fns+vUT0= X-Forwarded-Encrypted: i=1; AFNElJ8ZK/ZRfQNYz9+mDxNXi+gOklkdw199rl0phU4PCYjjwx9IzSMQ8G6MGNxH0zn3DOLRb68LT23oqSQPFIg=@vger.kernel.org X-Received: by 2002:a05:6214:5708:b0:8cc:d765:4fb7 with SMTP id 6a1803df08f44-8d1dc1a5579mr63985846d6.35.1781197117736; Thu, 11 Jun 2026 09:58:37 -0700 (PDT) X-Received: by 2002:a05:6214:5708:b0:8cc:d765:4fb7 with SMTP id 6a1803df08f44-8d1dc1a5579mr63985216d6.35.1781197117239; Thu, 11 Jun 2026 09:58:37 -0700 (PDT) Received: from [10.14.7.225] ([192.19.161.248]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d1e838f3a5sm23064766d6.18.2026.06.11.09.58.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jun 2026 09:58:36 -0700 (PDT) Message-ID: Date: Thu, 11 Jun 2026 09:58:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2] net: bcmgenet: convert RX path to page_pool To: Nicolai Buchwitz , opendmb@gmail.com, florian.fainelli@broadcom.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: phil@raspberrypi.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260610114835.2225423-1-nb@tipi-net.de> Content-Language: en-US From: Justin Chen In-Reply-To: <20260610114835.2225423-1-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 6/10/26 4:48 AM, Nicolai Buchwitz wrote: > Replace the per-packet __netdev_alloc_skb() + dma_map_single() in the > RX path with page_pool. SKBs are built from pool pages via > napi_build_skb() with skb_mark_for_recycle() so the network stack > returns pages to the pool, and DMA mapping happens once per page > instead of once per packet. > > Reject HW-reported lengths smaller than the RSB so a runt cannot > underflow the SKB build path. > > Drop the now-unused priv->rx_buf_len field and the rx_dma_failed soft > MIB counter (nothing increments it after the conversion). This > removes the "rx_dma_failed" entry from ethtool -S, which is a > user-visible change for monitoring tools that key on stat names. > > Signed-off-by: Nicolai Buchwitz Reviewed-by: Justin Chen Tested-by: Justin Chen