From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D09B226E709 for ; Mon, 9 Mar 2026 09:21:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773048100; cv=none; b=dj6Uk0+mxtPHGxlKlspfpQ80KyNW8j2PNH0L1aoFBmLnO96XiWsgGn17LRi2Etp4PJNQr6FcYFjEYvujzotTvCn+/hxl3mLobUvV3PATUooa3IpJSTaEtZHUGt8HNbu9XEI1HltcQ7wYJDrzomZg/O8VLp05IwikNX0j8L4qCfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773048100; c=relaxed/simple; bh=pNVASGNKTkVHmMv/3r/pFQp0I95m8g288bnL/FyxU30=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=tjImc6/VjnEAlbXJ9Mck0mT4/HOQHWj8qzJT2AwFK0zusJviooYusqk/jrlrypkUzLkHrZzatgu+tdpxwFSjXqeuMUef9AZSIqN1ODRubp0WVC0q9RkmPrLp6LdVwSbVdYRSjPmX+EhEcA/JAE0ieDOdqTpfqvxKsmw8TRbMVAE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1vzWnp-0002kR-Dm; Mon, 09 Mar 2026 10:21:29 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vzWnn-004VUn-0x; Mon, 09 Mar 2026 10:21:28 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1vzWno-000000004NG-2PF3; Mon, 09 Mar 2026 10:21:28 +0100 Message-ID: Subject: Re: [PATCH v3 05/14] reset: warn on reset-gpio release From: Philipp Zabel To: Bartosz Golaszewski , Krzysztof Kozlowski , Jonathan Corbet , Shuah Khan Cc: linux-kernel@vger.kernel.org, brgl@kernel.org, linux-doc@vger.kernel.org Date: Mon, 09 Mar 2026 10:21:28 +0100 In-Reply-To: <20260306-reset-core-refactor-v3-5-599349522876@oss.qualcomm.com> References: <20260306-reset-core-refactor-v3-0-599349522876@oss.qualcomm.com> <20260306-reset-core-refactor-v3-5-599349522876@oss.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Fr, 2026-03-06 at 18:22 +0100, Bartosz Golaszewski wrote: > While we implement an empty .release() callback for reset-gpio (driver > core requires it), this function will never actually be called as nobody > ever removes the device and the last reference is not dropped anywhere. >=20 > This is by design - once created, the reset-gpio device stays in memory. > Make the .release() callback emit a warning, should it ever be called > due to a programming bug. >=20 > Reviewed-by: Philipp Zabel > Signed-off-by: Bartosz Golaszewski > --- > drivers/reset/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/reset/core.c b/drivers/reset/core.c > index 954df36a242e804b639027384700b8d988be0e90..3e55f794d539e4edc99104cb5= 396cac72ba30618 100644 > --- a/drivers/reset/core.c > +++ b/drivers/reset/core.c > @@ -820,7 +820,7 @@ static void __reset_control_put_internal(struct reset= _control *rstc) > =20 > static void reset_gpio_aux_device_release(struct device *dev) > { > - > + WARN("reset-gpio device %s should never have been removed", dev_name(de= v)); I'll change this to WARN(1, "reset-gpio device %s should never have been removed", dev_name(de= v)); when applying. regards Philipp