mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: yonggil.song@samsung.com,
	"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
	"linux-f2fs-devel@lists.sourceforge.net" 
	<linux-f2fs-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND][PATCH] f2fs: avoid victim selection from previous victim section
Date: Thu, 24 Nov 2022 23:09:56 +0800	[thread overview]
Message-ID: <d8e36305-1f0a-092d-2286-76f40e91e19a@kernel.org> (raw)
In-Reply-To: <20221122090320epcms2p2e5df6f7bb1c2d80ae69fd5e4f84b08be@epcms2p2>

On 2022/11/22 17:03, Yonggil Song wrote:
> When f2fs chooses GC victim in large section & LFS mode,
> next_victim_seg[gc_type] is referenced first. After segment is freed,
> next_victim_seg[gc_type] has the next segment number.
> However, next_victim_seg[gc_type] still has the last segment number
> even after the last segment of section is freed. In this case, when f2fs
> chooses a victim for the next GC round, the last segment of previous victim
> section is chosen as a victim.
> 
> Initialize next_victim_seg[gc_type] to NULL_SEGNO for the last segment in
> large section.
> 
> Fixes: e3080b0120a1 ("f2fs: support subsectional garbage collection")
> Signed-off-by: Yonggil Song <yonggil.song@samsung.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

      reply	other threads:[~2022-11-24 15:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221122090320epcms2p2e5df6f7bb1c2d80ae69fd5e4f84b08be@epcms2p2>
2022-11-22  9:03 ` Yonggil Song
2022-11-24 15:09   ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8e36305-1f0a-092d-2286-76f40e91e19a@kernel.org \
    --to=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yonggil.song@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®