From: Markus Elfring <Markus.Elfring@web.de>
To: Zhihao Cheng <chengzhihao1@huawei.com>,
linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
Yi Zhang <yi.zhang@huawei.com>
Subject: Re: [PATCH] afs: Fix memory leak in afs_put_sysnames()
Date: Mon, 1 Jun 2020 13:18:18 +0200 [thread overview]
Message-ID: <d8e5aa79-3f83-a5de-5aa8-7bd4a287646e@web.de> (raw)
> sysnames should be freed after refcnt being decreased to zero in
> afs_put_sysnames().
* I suggest to use the wording “reference counter”.
* Where did you notice a “memory leak” here?
> Besides, it would be better set net->sysnames
> to 'NULL' after net->sysnames being released if afs_put_sysnames()
> aims on an afs_sysnames object.
* Would you like to consider an adjustment for this information?
* How do you think about to add an imperative wording?
* Will the tag “Fixes” become relevant for the commit message?
Regards,
Markus
next reply other threads:[~2020-06-01 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 11:18 Markus Elfring [this message]
2020-06-01 12:35 ` David Howells
-- strict thread matches above, loose matches on Subject: below --
2020-06-01 9:21 Zhihao Cheng
2020-06-01 12:31 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8e5aa79-3f83-a5de-5aa8-7bd4a287646e@web.de \
--to=markus.elfring@web.de \
--cc=chengzhihao1@huawei.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome