From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbdARH6K (ORCPT ); Wed, 18 Jan 2017 02:58:10 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:34444 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbdARH6I (ORCPT ); Wed, 18 Jan 2017 02:58:08 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EBFFE607C0 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=riteshh@codeaurora.org Subject: Re: [RESEND RFC 1/3] mmc: sdhci: Add platform_dumpregs callback support to sdhci_ops. To: Shawn Lin , adrian.hunter@intel.com, ulf.hansson@linaro.org References: <1484030515-16722-1-git-send-email-riteshh@codeaurora.org> <1484030515-16722-2-git-send-email-riteshh@codeaurora.org> <7cfc2b6c-fa3f-a8cb-d684-472c3dbacf2f@rock-chips.com> Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, georgi.djakov@linaro.org, asutoshd@codeaurora.org, stummala@codeaurora.org, venkatg@codeaurora.org, pramod.gurav@linaro.org, jeremymc@redhat.com From: Ritesh Harjani Message-ID: Date: Wed, 18 Jan 2017 13:27:53 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <7cfc2b6c-fa3f-a8cb-d684-472c3dbacf2f@rock-chips.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shawn, On 1/10/2017 2:45 PM, Shawn Lin wrote: > On 2017/1/10 14:41, Ritesh Harjani wrote: >> From: Sahitya Tummala >> >> Add new host operation ->platform_dumpregs to provide a >> mechanism through which host drivers can dump platform >> specific registers in addition to SDHC registers >> during error conditions. >> > > Although we have been preventing from adding new callback > for sdhci core, this one makes sense as there are more and more > vendor registers outside the scope of SDHCI spec. Sure thanks, shall I add your Reviewed-by on this patch 1/3. Would you be able to review other as well? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project