From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50BE9182C5 for ; Wed, 15 Jan 2025 01:17:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736903844; cv=none; b=QntTUHESziVCVZM81D965YFWdqYso4/NwfZiAg8vSJzhl5KIRvfgEwoyU+718u4dKi9N3l9AYoobfc47CyYBiakvlCNERhUdmQoEXOs+OoM9MQ6Y7c5YZDODi6Ce95R1UcG1NqPk2IiSKZyipIH+SNpDu2Iv/vu4gTgs0FggUdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736903844; c=relaxed/simple; bh=GTHQQFJXQu1CG26JlW0wcUFa40ANd922rkuoW6iWkYI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=S/EOa9Pwur9kx5CliXEqw5UU8sgb4YoM7sE4qrr1eRZZ9velWZAkITY8IExVe4xGKDUy+EwdlUYa5eDpuG5TiWXHK4myiW8mqrFf2vl0Gguabb5SFEAPL2loN4NPi5HB+QoyxKmDixcxCElSyAn/Xmv5cU2hIijM/SQXp8QTsDY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=xgVo55om; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xgVo55om" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4362bae4d7dso44025495e9.1 for ; Tue, 14 Jan 2025 17:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736903841; x=1737508641; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AYhWQj4ojjdJzbMmg6mMySnIdWhmXaZB7FNcuEIdeH0=; b=xgVo55omz19VHR+6NsB7hefw4ctBeIb54yyM/5on+gwJJOmRJO2ZPV3zg3z6jAEUdc VUqaEy54MlBxqNMeh7Xdez4xi213ggSEcxGhsv38FauL38N/bvUMAjx10L67vog3jyOo ipWdtw4Il/HSKTPfiT26r+M+mI1Ah/+IOCdVupSumC4hTy0c6eQ2yD/t15u5B3lMDifC Oriz1pV1CZOV4zXpyVlXw0Pjj/r9q9QTM9739zmLGtMgrHPcsl52JzlSxgbwivyB2qXJ ycV3uFPmJLmmFxndGqrWUTDWrw6zD0ISL9r6vrALGqtEOG7YjA5J+R/086MYBVQ64JwU NCag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736903841; x=1737508641; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AYhWQj4ojjdJzbMmg6mMySnIdWhmXaZB7FNcuEIdeH0=; b=lwMx2khJYlpRn7l3RG+ggRxPhz4oNvG375XYcV4d6DMp1YlS7jvDK+xXFyu+4+wIGc QVrE5NYcrRLOXm69KpHXQOPPYScL/w37A8lFbDmFuSO32SD3knMDzW9tbySQ3OoZ/ViX m5XcWgFXnXeWMUl2K9lTNOSDe3vpgm6Ksjb3R8i6qEyoDNHLLyn/biFeSSkSPrYrtnpo HQrUU0wIcIjgdPwdr+Cb3suzZ07G5eQfdHT/IwA4OYyuVrh3lSW0sJSXhiRyM0k16c92 gRAxHv2laCdGvWb8qeWOkSw/4AiScP0pSleGqSOWrR2NvJXq2PUuNdPh6m4PyzLlfv7d iUZg== X-Forwarded-Encrypted: i=1; AJvYcCVUFQqsFClmmGw6qMLkywiiZrx7BZMXXfjGUubebuouFIT/PDps1EdYrNvyHJFi0QpEI0PcTjXPFKUfCxg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4eMwbt6AwsZamCMRbidO039+Vfy1IJd0ZAxqHkP0/N179bAk9 PzBnVb/qHLv4s2rIJ23G1TBb162U3wSwSJApaCPKdLzs+MZgeqP2/etNPxLESwArq4lgx0eovDZ J X-Gm-Gg: ASbGncvx1q4RtUglkQDly+ddcXH8baW4jv2LyAzJboa8PGtwjd0guF8gIq7zmu9RO+v KDaXJLDe/z6AJc86yiN9vcllZQpyto84dL5GJKPtzHxfba3BomPRSzmv8ZouVUmsl98aOQlLPRz 2pfr6t5NjedlapQKbwQjS8Qazxoe/vXmNXKtXy8ZDXNnv0+tXep+2pYe45Ogz+kuLVY/UlJmpjz Wf5ribBb4Fwx7m0ZIgmjBepx9STZU9gq1YJRFX/acZN7Ax2K1Px8uHuQDH8vVySPwBczA== X-Google-Smtp-Source: AGHT+IGnaNr/+mB36vB8scdAb6zytw+YYCxL2h9EazlDijzabttMubxcv8HGRYtwJ0DaPUQkf+HZVg== X-Received: by 2002:a05:600c:a41:b0:434:eb86:aeca with SMTP id 5b1f17b1804b1-436e269a9e5mr278706015e9.10.1736903840774; Tue, 14 Jan 2025 17:17:20 -0800 (PST) Received: from [192.168.0.35] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e4b80b2sm16005256f8f.80.2025.01.14.17.17.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 17:17:19 -0800 (PST) Message-ID: Date: Wed, 15 Jan 2025 01:17:18 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/6] media: venus: vdec: Make the range of us_per_frame explicit To: Ricardo Ribalda , Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20250111-fix-cocci-v6-0-1aa7842006cc@chromium.org> <20250111-fix-cocci-v6-6-1aa7842006cc@chromium.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20250111-fix-cocci-v6-6-1aa7842006cc@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/01/2025 09:55, Ricardo Ribalda wrote: > Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame. > There is no need to do a 64 bit division here. > Also, the driver only works with whole fps. > > Found by cocci: > drivers/media/platform/qcom/venus/vdec.c:488:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Ricardo Ribalda > --- > drivers/media/platform/qcom/venus/vdec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c > index e160a5508154..aa9ba38186b8 100644 > --- a/drivers/media/platform/qcom/venus/vdec.c > +++ b/drivers/media/platform/qcom/venus/vdec.c > @@ -484,8 +484,7 @@ static int vdec_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) > do_div(us_per_frame, timeperframe->denominator); > > us_per_frame = max(USEC_PER_SEC, us_per_frame); > - fps = (u64)USEC_PER_SEC; > - do_div(fps, us_per_frame); > + fps = USEC_PER_SEC / (u32)us_per_frame; > fps = min(VENUS_MAX_FPS, fps); > > inst->fps = fps; > Tested-by: Bryan O'Donoghue # qrb5615-rb5 Reviewed-by: Bryan O'Donoghue