From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85F50C76196 for ; Mon, 22 Jul 2019 07:18:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B99C21BE6 for ; Mon, 22 Jul 2019 07:18:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727640AbfGVHSw (ORCPT ); Mon, 22 Jul 2019 03:18:52 -0400 Received: from relay.sw.ru ([185.231.240.75]:59268 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbfGVHSw (ORCPT ); Mon, 22 Jul 2019 03:18:52 -0400 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.92) (envelope-from ) id 1hpSav-0000Fm-TZ; Mon, 22 Jul 2019 10:18:50 +0300 Subject: Re: [PATCH] fuse: cleanup fuse_wait_on_page_writeback To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Miklos Szeredi References: <64e2db3a-cf58-0158-e097-1a504a8bb496@virtuozzo.com> From: Vasily Averin Message-ID: Date: Mon, 22 Jul 2019 10:18:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <64e2db3a-cf58-0158-e097-1a504a8bb496@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I forget to add this patch was used in OpenVZ kernels last few years. On 7/22/19 10:17 AM, Vasily Averin wrote: > From: Maxim Patlasov > fuse_wait_on_page_writeback() always returns zero and nobody cares. > Let's make it void. > > Signed-off-by: Maxim Patlasov > Signed-off-by: Vasily Averin > --- > fs/fuse/file.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/fuse/file.c b/fs/fuse/file.c > index 5ae2828beb00..e076c2cf65b0 100644 > --- a/fs/fuse/file.c > +++ b/fs/fuse/file.c > @@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index) > * Since fuse doesn't rely on the VM writeback tracking, this has to > * use some other means. > */ > -static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index) > +static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index) > { > struct fuse_inode *fi = get_fuse_inode(inode); > > wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index)); > - return 0; > } > > /* >