From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD9AE39B4A0 for ; Tue, 17 Mar 2026 22:20:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773786044; cv=none; b=uu4jvDEG3b2tDXdDXP7ILc9gzl1h3EE0W+xj/90Z85mJp930AKUBbKWGLtR/nen06QxJ/6t9JnZ5vbd5EiQsX2cwWwRZD1uJV2EW7cMCcbxyteNrD5SBEUxmuUm21m+IU394JyMooN8JWK1bdQufTjKNDjY6EGDdTS38/k7DOdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773786044; c=relaxed/simple; bh=2AezpX9nMJN7fXejlohfhk6Hee7s312vEjqngOxROR0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=l2RtkpMoZcnxM1G/F7Q0VBUitl1H/TOHlKj6idbx1N6eqLI4633LOoOV1hLCGXRzaQbRKAA1TNVpOBu+JvUyXtCXQdSHRdDbTesPLq8fkPCR0FCCfXHcdRCnIgO0zYmCP/BytSbcANOmJBVt0Yiw/ts3spTPeKVkpMBlQM/T9AQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XnCIIiz6; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XnCIIiz6" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2c0bcd8f194so4479884eec.1 for ; Tue, 17 Mar 2026 15:20:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773786041; x=1774390841; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=PFphyAt9r7cEETWzy9hJGoIRqUIBOhHfjBLEm5UlK6c=; b=XnCIIiz6/vMy7IIog1KOuzecaaDMFEkjM74OCevsO2fVh0E6vtN0YqisiLXARWCfal sXgLXxkxnzCPeNvwQYl5ubaTwaTVIKBv4/KSNESpd+Em3wE9Ya4Xm9p5zOCChUjJ6A8r 8rur20n2TL95795ZH1Bq+Ycz86Jb3x7hc6pQhQjR2DMKwttkGGJmZCy1xuCf7hhrsQqQ JmvAuqkkbr+DCFrrI7QJAgBFfcEzjK+t0GL9fvIuDXE7yOtMP5qUqtQoSy7ZIvYxEXV2 LXcmJGiiYMtfXLowCBVyDtA1rw+mw6RTSWXcllG58yRPl9pcN+Z6UUzff1tjBtUTwl7c 823A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773786041; x=1774390841; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PFphyAt9r7cEETWzy9hJGoIRqUIBOhHfjBLEm5UlK6c=; b=YE4cdiEDPZ13f8RKlSVva0chYls4UR1XGKFDCDuifHoktZbeKrgZRVj9zJsDEa/HAZ IoiGQIYbN6AMJu/gQTVyEfOnqV6KpbvTwaTniKC5K/m6ELqU+W3RAqvNBSFRjshoiypt emLQZVX8nCiyOJQH+ZcE9aEZM9hpGd6DzRVEfrOp4mk8s8qFpkHxeU5Icbu1rnfS+Ik4 ofPl+of1AbYDvjxgvZAEnSn4QpPEyzV0a++/HtMzz4VVyFtihsr8Fen7NWUxjA7ORY3v YCOzIySaPWokGHEPM0sQ8bfpc2VwEInNytVg9+35hdWF9mhvQpROrSdh3VRdNpoDvjSy WLXw== X-Forwarded-Encrypted: i=1; AJvYcCWJPdlAzuX0PcP2pxiVOjZisuc4uhZkkkj/XqxjxNDUX6SrGqbRJv+ya1W6aKx//5wgS/Ss9t4pDIuX4mw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxslc9l+Ak19pXidCQVULz/wQnVNMdNhg2Yq86hRitPRIJePai3 i/rWKfCnjHjYQUBmXYEjwZW3k0FAKqwEC/e60Z8l4APD/+NQ6BB4WXTT X-Gm-Gg: ATEYQzyW2TuAHkvC5ibLu7j2OThu7yTfcbunpbrO7oT54mupD3uidI745gjqzyvCuYG IizYgsGnEH4Xq6lB9VYYLgQtIPNZ/kAbT2WGSZ3L5YAp9T7juiQgADOO/PfpT7YkXn8nB8oN82o LBzivWRbRcM4CUIz9YZKBmrb9Av7XetYjEpTmgKOOex83K8J7J5PX9e33hNT0QKhyk/WxySHhkS JgohYeGaVa2YZF8a17MkYwwbDRXpp7haciMPF4wySgSqY8zUKofATXgulyTDmVOGpNe9aS1j6ST Fj/Ocv+jrsOZlRHd1KJQnk4XAhw6uV8Hg/k+keFJeoLv6ReryoPILoLkjQ2SmbQhyvaEXDcOu0+ /eXjlzKz+7XNLQdvozZJ+W31B2FyVRjiGw0ax+dSQIb1m11Qw9ljC6CLXZMdiHphO/mWPR8BU+L x20+6e+7vh8Ni4fhfB+jb5dOHwp74GwrJwyi7ydQNazw4aRoE= X-Received: by 2002:a05:7022:160c:b0:122:8d:3688 with SMTP id a92af1059eb24-129a712f3d2mr645312c88.22.1773786040671; Tue, 17 Mar 2026 15:20:40 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-129b3e8d34dsm1230176c88.7.2026.03.17.15.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 15:20:40 -0700 (PDT) Sender: Guenter Roeck Date: Tue, 17 Mar 2026 15:20:39 -0700 From: Guenter Roeck To: "Pradhan, Sanman" Cc: "linux-hwmon@vger.kernel.org" , "vasileios.amoiridis@cern.ch" , "leo.yang.sy0@gmail.com" , "wensheng@yeah.net" , "linux-kernel@vger.kernel.org" , Sanman Pradhan , "stable@vger.kernel.org" Subject: Re: [PATCH 2/5] hwmon: (pmbus/mp2975) Add error check for pmbus_read_word_data() return value Message-ID: References: <20260317173308.382545-1-sanman.pradhan@hpe.com> <20260317173308.382545-3-sanman.pradhan@hpe.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260317173308.382545-3-sanman.pradhan@hpe.com> On Tue, Mar 17, 2026 at 05:37:17PM +0000, Pradhan, Sanman wrote: > From: Sanman Pradhan > > mp2973_read_word_data() XORs the return value of pmbus_read_word_data() > with PB_STATUS_POWER_GOOD_N without first checking for errors. If the I2C > transaction fails, a negative error code is XORed with the constant, > producing a corrupted value that is returned as valid status data instead > of propagating the error. > > Add the missing error check before modifying the return value. > > Fixes: acda945afb465 ("hwmon: (pmbus/mp2975) Fix PGOOD in READ_STATUS_WORD") > Cc: stable@vger.kernel.org > Signed-off-by: Sanman Pradhan Applied. Thanks, Guenter