From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19745C433E0 for ; Wed, 10 Feb 2021 15:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D309A64E77 for ; Wed, 10 Feb 2021 15:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231801AbhBJPzk (ORCPT ); Wed, 10 Feb 2021 10:55:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:40468 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230160AbhBJPzf (ORCPT ); Wed, 10 Feb 2021 10:55:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612972448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/iXYwewC8ykR1ydcobsk8WlvcCmIoiMdSUj9YDWUA9Y=; b=D06wfyprQxi4lvL6Ck8XyhnvAkPc/rfumdHyD1gKvnxc2/VKvaVSZMm5YN41g5DJzt77MZ mZIOvssIYkMyYd12GXc8tGDlOP/yQUqKwdvW0PeVRESzGLTBPfQlcDNi4crfJqTY8bE9fZ +zHcWR+0khztV+7hTDkd9UZrdK/uIzc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-v1nJFLltNMG8bJ8KVCA-_Q-1; Wed, 10 Feb 2021 10:54:02 -0500 X-MC-Unique: v1nJFLltNMG8bJ8KVCA-_Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C2188801977; Wed, 10 Feb 2021 15:54:00 +0000 (UTC) Received: from llong.remote.csb (ovpn-115-20.rdu2.redhat.com [10.10.115.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 41D9A10013D7; Wed, 10 Feb 2021 15:53:59 +0000 (UTC) Subject: Re: [PATCH] locking/arch: Move qrwlock.h include after qspinlock.h To: Guenter Roeck , Peter Zijlstra , Ingo Molnar , Will Deacon , Catalin Marinas , Thomas Bogendoerfer , Chris Zankel , Max Filippov Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-xtensa@linux-xtensa.org, Naresh Kamboju , Ben Gardon References: <20210210144556.10932-1-longman@redhat.com> <401dbbe1-096c-8af5-4e21-e355e602272e@roeck-us.net> From: Waiman Long Organization: Red Hat Message-ID: Date: Wed, 10 Feb 2021 10:53:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <401dbbe1-096c-8af5-4e21-e355e602272e@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/21 10:05 AM, Guenter Roeck wrote: > On 2/10/21 6:45 AM, Waiman Long wrote: >> The queued rwlock code has a dependency on the current spinlock >> implementation (likely to be qspinlock), but not vice versa. Including >> qrwlock.h before qspinlock.h can be problematic when expanding qrwlock >> functionality. >> >> If both qspinlock.h and qrwlock.h are to be included, the qrwlock.h >> include should always be after qspinlock.h. Update the current set of >> asm/spinlock.h files to enforce that. >> >> Signed-off-by: Waiman Long > There should be a Fixes: tag here. If the SHA of the offending commit is not > stable, there should be a better reference than "The queued rwlock code". I originally have a Fixes tag when I was modifying the mips' asm/spinlock.h file. After I realize that there are more files to modify, I take that out. Anyway, the problem was exposed by Ben's qrwlock patch. So existing stable releases should still be fine without this patch. > > This patch fixes the build problem I had observed on mips. I also tested > xtensa:defconfig and arm64:defconfig with no problems observed. > > Tested-by: Guenter Roeck Thanks for the testing as I don't have a build environment to verify that. Cheers, Longman