From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbcL3QjY (ORCPT ); Fri, 30 Dec 2016 11:39:24 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:52060 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751280AbcL3QjX (ORCPT ); Fri, 30 Dec 2016 11:39:23 -0500 Subject: Re: [PATCH] iio: adc: TI_AM335X_ADC should depend on HAS_DMA To: Geert Uytterhoeven , Mugunthan V N , Peter Ujfalusi , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler References: <1481718624-7238-1-git-send-email-geert@linux-m68k.org> Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: Date: Fri, 30 Dec 2016 16:39:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1481718624-7238-1-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/12/16 12:30, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "bad_dma_ops" [drivers/iio/adc/ti_am335x_adc.ko] undefined! > > Add a dependency on HAS_DMA to fix this. > > Signed-off-by: Geert Uytterhoeven Applied to the fixes-togreg-post-rc1 branch of iio.git (will unwind this fun branch shortly now we are post rc1) and marked for stable with an appropriate fixes tag added. Thanks, Jonathan > --- > drivers/iio/adc/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 38bc319904c4c299..9c8b558ba19ecb03 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -561,7 +561,7 @@ config TI_ADS8688 > > config TI_AM335X_ADC > tristate "TI's AM335X ADC driver" > - depends on MFD_TI_AM335X_TSCADC > + depends on MFD_TI_AM335X_TSCADC && HAS_DMA > select IIO_BUFFER > select IIO_KFIFO_BUF > help >