From: Krzysztof Kozlowski <krzk@kernel.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Chen-Yu Tsai <wens@kernel.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Maxime Ripard <mripard@kernel.org>,
Richard Genoud <richard.genoud@bootlin.com>,
Boris Brezillon <bbrezillon@kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-rt-devel@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH v10 20/26] dt-bindings: mtd: sunxi: require the H616 AHB reset
Date: Fri, 6 Nov 2026 09:30:39 +0100 [thread overview]
Message-ID: <d8ffabec-fc40-4082-9c7f-8dccd16e1992@kernel.org> (raw)
In-Reply-To: <CADvTj4rYG01pNxZS3FAKzHw9yOO79W-zMdBzaXvV_hrMs+sp2A@mail.gmail.com>
On 06/11/2026 09:28, James Hilliard wrote:
> On Fri, Nov 6, 2026 at 1:19 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Thu, Nov 05, 2026 at 11:55:36AM -0700, James Hilliard wrote:
>>> The H616 NAND controller needs its AHB reset to stop internal DMA and
>>
>> So was the device working or not? Be explicit, because this is an ABI
>> break.
>
> Normal NAND reads and writes worked. The failure was in recovery after
> aborting an active internal DMA transfer: the controller's soft reset
> could leave the first subsequent read displaced, sometimes without an
> ECC error. I reproduced this through fault injection, not ordinary I/O.
>
Please place this in the commit msg.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-06 8:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 18:55 [PATCH v10 00/26] mtd: rawnand: sunxi: fix transfers and support randomized OOB James Hilliard
2026-11-05 18:55 ` [PATCH v10 01/26] mtd: rawnand: sunxi: centralize OOB handling James Hilliard
2026-11-05 19:13 ` sashiko-bot
2026-11-05 18:55 ` [PATCH v10 02/26] mtd: rawnand: sunxi: share the buffer transfer chunk size James Hilliard
2026-11-05 18:55 ` [PATCH v10 03/26] mtd: rawnand: sunxi: avoid duplicate chip setup before page commands James Hilliard
2026-11-05 18:55 ` [PATCH v10 04/26] mtd: rawnand: sunxi: reject pages exceeding the ECC step limit James Hilliard
2026-11-05 18:55 ` [PATCH v10 05/26] mtd: rawnand: sunxi: use the logical step's OOB length in PIO James Hilliard
2026-11-05 18:55 ` [PATCH v10 06/26] mtd: rawnand: sunxi: propagate page-setup and erased-check errors James Hilliard
2026-11-05 18:55 ` [PATCH v10 07/26] mtd: rawnand: sunxi: drain interrupts before reusing the completion James Hilliard
2026-11-05 18:55 ` [PATCH v10 08/26] mtd: rawnand: sunxi: stop failed program operations and disable ECC James Hilliard
2026-11-05 18:55 ` [PATCH v10 09/26] mtd: rawnand: sunxi: select the pattern ID for the current ECC step James Hilliard
2026-11-05 18:55 ` [PATCH v10 10/26] mtd: rawnand: sunxi: preserve synthesized zero-pattern data and OOB James Hilliard
2026-11-05 18:55 ` [PATCH v10 11/26] mtd: rawnand: sunxi: propagate buffer and column transfer errors James Hilliard
2026-11-05 18:55 ` [PATCH v10 12/26] mtd: rawnand: sunxi: avoid a second program confirm for OOB writes James Hilliard
2026-11-05 18:55 ` [PATCH v10 13/26] mtd: rawnand: sunxi: use page reads to reposition small-page NAND James Hilliard
2026-11-05 18:55 ` [PATCH v10 14/26] mtd: rawnand: sunxi: bound DMA batches by the user-data register bank James Hilliard
2026-11-05 18:55 ` [PATCH v10 15/26] mtd: rawnand: sunxi: send all address cycles in split operations James Hilliard
2026-11-05 18:55 ` [PATCH v10 16/26] mtd: rawnand: sunxi: propagate chip clock setup errors James Hilliard
2026-11-05 18:55 ` [PATCH v10 17/26] mtd: rawnand: sunxi: limit buffer transfers to the command byte count James Hilliard
2026-11-05 18:55 ` [PATCH v10 18/26] mtd: rawnand: sunxi: skip unavailable NAND child nodes James Hilliard
2026-11-05 18:55 ` [PATCH v10 19/26] mtd: rawnand: sunxi: scan all chips before registering MTD devices James Hilliard
2026-11-05 18:55 ` [PATCH v10 20/26] dt-bindings: mtd: sunxi: require the H616 AHB reset James Hilliard
2026-11-06 8:19 ` Krzysztof Kozlowski
2026-11-06 8:28 ` James Hilliard
2026-11-06 8:30 ` Krzysztof Kozlowski [this message]
2026-11-05 18:55 ` [PATCH v10 21/26] mtd: rawnand: sunxi: reset the H616 data path after DMA aborts James Hilliard
2026-11-05 18:55 ` [PATCH v10 22/26] mtd: rawnand: sunxi: reuse ECC status within each transfer James Hilliard
2026-11-05 18:55 ` [PATCH v10 23/26] mtd: rawnand: sunxi: avoid redundant column changes for extra OOB James Hilliard
2026-11-05 18:55 ` [PATCH v10 24/26] mtd: rawnand: sunxi: reduce user-data length register accesses James Hilliard
2026-11-05 18:55 ` [PATCH v10 25/26] dt-bindings: mtd: sunxi: Add randomized OOB flag James Hilliard
2026-11-05 18:55 ` [PATCH v10 26/26] mtd: rawnand: sunxi: support the Allwinner randomized OOB format James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8ffabec-fc40-4082-9c7f-8dccd16e1992@kernel.org \
--to=krzk@kernel.org \
--cc=bbrezillon@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=james.hilliard1@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=miquel.raynal@bootlin.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=richard.genoud@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=samuel@sholland.org \
--cc=vigneshr@ti.com \
--cc=wens@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®