From: Jens Axboe <axboe@kernel.dk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Tejun Heo <tj@kernel.org>, Josef Bacik <jbacik@fb.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: iolatency: avoid 64-bit division
Date: Tue, 10 Jul 2018 12:28:09 -0600 [thread overview]
Message-ID: <d9014b7b-2eca-97ba-7e04-4f7f99e88c9b@kernel.dk> (raw)
In-Reply-To: <20180710152146.2371336-1-arnd@arndb.de>
On 7/10/18 9:21 AM, Arnd Bergmann wrote:
> On 32-bit architectures, dividing a 64-bit number needs to use the
> do_div() function or something like it to avoid a link failure:
>
> block/blk-iolatency.o: In function `iolatency_prfill_limit':
> blk-iolatency.c:(.text+0x8cc): undefined reference to `__aeabi_uldivmod'
>
> Using div_u64() gives us the best output and avoids the need for an
> explicit cast.
Applied, thanks Arnd.
--
Jens Axboe
prev parent reply other threads:[~2018-07-10 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 15:21 Arnd Bergmann
2018-07-10 18:28 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9014b7b-2eca-97ba-7e04-4f7f99e88c9b@kernel.dk \
--to=axboe@kernel.dk \
--cc=arnd@arndb.de \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®