From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49A33218E81 for ; Fri, 20 Dec 2024 16:37:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734712623; cv=none; b=NYr2mFCuUueDk+gkoQilR30p2EXcC6opMyKxeVLCaMfyp6sgA6425H8yVaMb32wDxlB5c9m4tFWOVp3N2rqLq5EEL0mxws/ELENmHcXwo49/JMq4eZpm8SW852SKq2MGILIXeaOYcartqKbNfRVXgLh9y0TNjaAxLjoBJA5CbrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734712623; c=relaxed/simple; bh=bEWRU12WpWPIeMDN8FVOFQxbTCC7SXobuaxurF/0EsM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kvqhPoxWZDsTl1PAdZeqsi9oTWC0GaheWFEhEI3N3DNyhR+sRye9ny8xApuqPA0EDHJKEWHBlXann3GOa/kYSwWsnl3YPLx/nQKKFyJMKbg0bnk9P6MljtbSNCDm63XpQq7W1azdMWTTXiEJWvSZyCDKPkT6uiGIViA7CZfCjEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mWD4iOZw; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mWD4iOZw" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-53e395932c6so228353e87.2 for ; Fri, 20 Dec 2024 08:37:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734712618; x=1735317418; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d5A1L57IAweu5CryWVUj44bHWooyuzy3DJH86XpP5RM=; b=mWD4iOZwikC6/sY1fhaqYUMyt6tG1yL084IiXUTLp7SdweQRxL76A1KS33G1xlj72X yS/Szat3wBf+em2b0o06hBBoUzJZEaPt/J9I3Yfq6THuO5c2XEYL+VDFY91siGt/mFBR WFs2AbUlpUNGwmydSnBwCjb8u9sRlVxnX50vjS/qVY7jvD4Wj1L0u8k3DoUW/Ben7MID 2m3ME3hIapwVhETCT3UT9n8uUysu+/P3jTPcDIR1Z6Vuv8krC7vzzNWXiq5aJZ2ikmFS h+PjglAo9J7UjDuC3WbUDkQ7w5qPkpl//ROmBPMesrtWBXyMfq9UhdWYQ3IKBRWF76M8 nKvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734712618; x=1735317418; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d5A1L57IAweu5CryWVUj44bHWooyuzy3DJH86XpP5RM=; b=vppzjEfROaCgLQZCiMQ2UkhNPGCbIenhMxy5PR5Tw/ZAcTRNjkG/Pnww2GA7rzSYjp Fedu6CYDG0ccXqGm9Ro5x5h2boPTZvvwzamwU641EoCDQIhmCuxwz7oOrIlmcx3y4pob YZrBmxhSXf8nzo3z/J/pHiQN0av+186JDZisTjralYRRy4aP+zNB3FkOmLhDTEwPjXsW VWXJ0fw/uSVn/rTlbN+yIfxSDJgjJmcgbrkzVMppvSGm6DNXMgDAiadlNrtF1bgRBqcs MS7RvEMlMa/JqV2a/1IQbexXIK+S3IK8r9Rfybg4EF+IR/4TCePgWexCsTk9cIpeT7JG o2vg== X-Forwarded-Encrypted: i=1; AJvYcCUaSbSZLeWWqBBMju/Bmb3j2zK+Qzmvk/1B2jRi9YJrfSJI/XjFMfg7wx/CARNjDPBDnHi9ZJ5Alc0ujnM=@vger.kernel.org X-Gm-Message-State: AOJu0YwA6bacCY5N6F4pTjyYFa9VIw8I6ADnsqBVYtYqwYCbt+R2Hc0a 6f4dIBOy0i3mpIS2UkCCZuh5Gm3sDwbfM3MKFe7/FlnXDiYLH67t5Uee8TZjcOQ= X-Gm-Gg: ASbGncsLFS+VMk0Om+VtB4LTL1NexU2SA0ahzmG9ocfgqHu45Dj1+tbKHZYK8Ba7Oog uUtZphHeDqfJ05mp188wVimYOUor3xU/RxTLBYEQcIerc2gGXvg0G7d3y7POxHg+dadvkPqQERH Orrufdm/SlABNQGKluSxM3Ec57J7KvPUPHAWX7MWFjFGxb+3DAFC2ah3oaUuxfJr9M2HwZVUsr1 STl56SETkLZ5maiz0EAeSU6UMaBcTTAX1Qa+wf6HGLKCe4ycsIXvjdbOR07qVRrAFrqyWY19Lxl lWS2geh5dssm1yw4vnwwW/npymxuDggh0eI= X-Google-Smtp-Source: AGHT+IE8TnK9IvRiznibBWY6VYtR979POUMMCtyniJxLit34dsZxQlt2H0tfxRvYUQfhVYsRY4b0qA== X-Received: by 2002:a05:6512:1252:b0:540:22bd:e24f with SMTP id 2adb3069b0e04-54229567da6mr425163e87.12.1734712618376; Fri, 20 Dec 2024 08:36:58 -0800 (PST) Received: from [192.168.1.4] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54223832c1bsm511240e87.280.2024.12.20.08.36.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 08:36:56 -0800 (PST) Message-ID: Date: Fri, 20 Dec 2024 18:36:54 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvmem: qcom-spmi-sdam: Set size in struct nvmem_config Content-Language: ru-RU To: Luca Weiss , Srinivas Kandagatla , Greg Kroah-Hartman , Shyam Kumar Thella , Anirudh Ghayal , Guru Das Srinagesh Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20241220-sdam-size-v1-1-17868a8744d3@fairphone.com> From: Vladimir Zapolskiy In-Reply-To: <20241220-sdam-size-v1-1-17868a8744d3@fairphone.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/20/24 14:22, Luca Weiss wrote: > Let the nvmem core know what size the SDAM is, most notably this fixes > the size of /sys/bus/nvmem/devices/spmi_sdam*/nvmem being '0' and makes > user space work with that file. > > ~ # hexdump -C -s 64 /sys/bus/nvmem/devices/spmi_sdam2/nvmem > 00000040 02 01 00 00 04 00 00 00 00 00 00 00 00 00 00 00 |................| > 00000050 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| > * > 00000080 > > Fixes: 40ce9798794f ("nvmem: add QTI SDAM driver") > Cc: stable@vger.kernel.org > Signed-off-by: Luca Weiss Reviewed-by: Vladimir Zapolskiy > --- > Related, it would be nice to set sdam->sdam_config.type to an > appropriate value, the ones currently upstream are: > > enum nvmem_type { > NVMEM_TYPE_UNKNOWN = 0, > NVMEM_TYPE_EEPROM, > NVMEM_TYPE_OTP, > NVMEM_TYPE_BATTERY_BACKED, > NVMEM_TYPE_FRAM, > }; > > I don't know what would fit for SDAM and I couldn't find any info on > createpoint either, not even what the abbreviation SDAM stands for. > --- > drivers/nvmem/qcom-spmi-sdam.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvmem/qcom-spmi-sdam.c b/drivers/nvmem/qcom-spmi-sdam.c > index 9aa8f42faa4c93532cf8c70ea992a4fbb005d006..4f1cca6eab71e1efc5328448f69f863e6db57c5a 100644 > --- a/drivers/nvmem/qcom-spmi-sdam.c > +++ b/drivers/nvmem/qcom-spmi-sdam.c > @@ -144,6 +144,7 @@ static int sdam_probe(struct platform_device *pdev) > sdam->sdam_config.owner = THIS_MODULE; > sdam->sdam_config.add_legacy_fixed_of_cells = true; > sdam->sdam_config.stride = 1; > + sdam->sdam_config.size = sdam->size; > sdam->sdam_config.word_size = 1; > sdam->sdam_config.reg_read = sdam_read; > sdam->sdam_config.reg_write = sdam_write; > -- Best wishes, Vladimir