From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC49F354AC0 for ; Thu, 22 Jan 2026 18:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769108251; cv=none; b=KgLKYLoSbtcykm6YFaUE2V0hK9/j+84UedYkPoTcDVilueDNjnKGB9RCmJEOtQq04HSTWVnbVpv8ZPMlyuIRgTL7SP9U23YoAhIfKzSVQfz9htDtxKPWcZelmD0K+SBsaLq+Cp9UMnjBO4xYuYnC4abc435c80B0SYbe/D0qxWY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769108251; c=relaxed/simple; bh=QUeVYo+ICZjJILbIW9iYwEWfD5eoanHqZ9Els6Bjq3c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U7BCD6yLMeWXVAPSU28w3PjMqjAi/xLEMHxGpZNr/9b3iIyLvpQv4Y+cUGND42VcbLzqyuc7Q8WfvfDr6/e1UWatzUr0tsdzNpzlmPKeHisdiBEbdh2wfNCXlho5ZKmxcPNyHPxwjmsUaWxK/utDYoCmFp3EA6I3ong9i5pjsp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ejbrWJDo; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ejbrWJDo" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-383122fbc9bso10017641fa.1 for ; Thu, 22 Jan 2026 10:57:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769108240; x=1769713040; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+mScsg53i6ZoIWtfuaNxg8jLICt1p8GYZ/GGQUU3Wx0=; b=ejbrWJDojn6Mrn/TmzFdKWBuWBLOpD43KC7ip8P/nr2hrt/lid2atWFQJYKa2qsGMZ /rBkp4mtIJWy/5eaZwSHb7n8rre9QlSpcrwA98mfPpZGfTkbnM67RAaOsfsnh3oBW66R MrQYjUY1N2LMGc81/DBVuekKFqRzXVI9jENiCVn9jMfSRRmuaz0ZhfFVbmHmP4X7siiK RwoYdwghXgDZFh3/Sk4GJ/Xt0YCaayu8i71C6uigjYykFxnMr/SERJB5puQmpgsTpUko 9b2zGxvd+2w9HRttRjq9vywvXn2ybp60xrxiBwi8WO5nDAbhPrmu4RCHR2o1968TjlVv +eTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769108240; x=1769713040; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+mScsg53i6ZoIWtfuaNxg8jLICt1p8GYZ/GGQUU3Wx0=; b=pOVseuCNLxaOFSACEPbXRfHoK8B5KHx7rUfndVQ9o9V66FY4JDb7XUtt815gM3d86b /+Zo4Ze9jtngeKZpqLvvK6zXALbMc6UrNfblREYmo6l0BalmDpQe7Ug7B0OHVAx2cWUX RDg6un/4WITua1RcP+SiixO3zFEBniHhqt4HIatgrlT2GJRMkctC68LoRmMNbcU6ph+7 Vdav7a78M4wc9d0Q4JY/2cT5zvrgpG5lUzn8qjjbR4IL5jm3O5eiq60kyh4NZ3dHPrY5 FiSWOkxh2CYTC8EfCNTfQEvtEpu12I1xwD9auBvNRq29eCiro1s6RdsSTxwff4ky98LX fJbw== X-Forwarded-Encrypted: i=1; AJvYcCWAfLTV+8yzLAM27dh3Vam297Y5z0NJkfCrjlNH1wxj8z6WoJPayRQKTnrm6gkjuHK0ZokXBv3UkaYeTQc=@vger.kernel.org X-Gm-Message-State: AOJu0YzzxN4OMALYJ9c5R/nOKY4x55YuGMXTUstW/3PxdBaYb957BElm QvHf1Qw2snghZwongUJgPR72tzQas3ZqbIo1XsmTiSDUJ2uCqEBI6O4s X-Gm-Gg: AZuq6aIqxlqGXheMlhiLT4s/lqez69YzlA7n28asw+RcJiUgmo6IyokuuvBuVbAh/3a plrAMPx4LOI0k2oEfHG3jY0iiutC55f1YZG8bMVAlbZsYIZfmp/HqtXTfWGGNXkVLAHL2a1wHI7 uQ3+eli9hbkv7pq+ZqUSDy2TKtMIGuNBzGJI8bFCt9YZoQ+BZh4kP8g0/wmtesgkpzVGCPFDnq3 EeLL2nY2182xd1IO5wgmEI+ysUt3ioxOucRYIsf29DRXEvalkrq/W8UHK9iHbR3HEr/7qF4PXJu pB6PRZtwxzBlVqBNxW9ElnrqmYANIWPo9XtGKQe4Wl5gGKJ/Mov9Xg4j9FDG0kQaDaAAuulSwwF bqf876H9wYehf5fn5Ng2hGDLFyzvamLlUvGiFSOfHKwrt8F++j++B0OuVV4hsmwj05lwNuDn9B5 qbzSE18NwxSMhD7lyCO1mM/DpSCbdLmBEkUbbt4fMa12ZVsQokune/gix/OZ/ILZZSkXOAEw== X-Received: by 2002:a2e:a483:0:b0:37b:b8c0:b5e1 with SMTP id 38308e7fff4ca-385da007b4bmr684401fa.27.1769108239476; Thu, 22 Jan 2026 10:57:19 -0800 (PST) Received: from ?IPV6:2a00:1fa0:4677:d84c:4a53:d9f9:de83:6237? ([2a00:1fa0:4677:d84c:4a53:d9f9:de83:6237]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-385d9fec3c9sm645761fa.15.2026.01.22.10.57.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 10:57:19 -0800 (PST) Message-ID: Date: Thu, 22 Jan 2026 21:57:16 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] linux/interrupt.h: allow "guard" notation to disable and reenable IRQ with valid IRQ check To: Geert Uytterhoeven , Sebastian Andrzej Siewior Cc: Marek Vasut , linux-input@vger.kernel.org, "Peter Zijlstra (Intel)" , Cheng-Yang Chou , Dmitry Torokhov , Frank Li , Geert Uytterhoeven , Jinjie Ruan , Krzysztof Kozlowski , Marc Zyngier , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20260121232522.154771-1-marek.vasut+renesas@mailbox.org> <20260122162206.9wrHkrTZ@linutronix.de> Content-Language: en-US From: Sergey Shtylyov In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/22/26 7:31 PM, Geert Uytterhoeven wrote: [...] >>> @@ -242,6 +242,21 @@ extern void irq_wake_thread(unsigned int irq, void *dev_id); >>> DEFINE_LOCK_GUARD_1(disable_irq, int, >>> disable_irq(*_T->lock), enable_irq(*_T->lock)) >>> >>> +static inline void disable_valid_irq(unsigned int irq) >>> +{ >>> + if (irq > 0) >>> + disable_irq(irq); >>> +} >> >> | $ grep " 0:" /proc/interrupts >> | 0: 43 0 IO-APIC 2-edge timer >> >> in other words, interrupt 0 is valid. > > AFAIK, the x86 legacy timer interrupt is the sole remaining valid user > of interrupt number zero. > Nowadays lots of code assumes valid interrupt numbers are non-zero > positive numbers. Makes me remember this commit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ce753ad1549cbe9ccaea4c06a1f5fa47432c8289 > Gr{oetje,eeting}s, > > Geert MBR, Sergey