From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43B10304971 for ; Tue, 2 Sep 2025 13:16:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756818994; cv=none; b=FVLstTkORZCJTBdJl4wrchGm4ogn/0L2Sb4WF7wpw1ClpvIgfIfYydb1j/xBhM1bS9MRwyCWH8EMG3Qzrr1uHVxdkcr3RamAJppAHwBIJsWlNPJ8IBo+68jJaasuOOBi/d6b5wXJDyTi1+6dcZ14kPtTtZjrwtux5vsQgGneZoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756818994; c=relaxed/simple; bh=865tUZhf1nCUXelVgr9M9ObPk5g+lULXtZF7b04MICE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TWGV6oRab2/Nkze+cdopmP1R9n5f5urQyaezRe1j5isvi0NBsURWeQm5Oowqx0dwYHCVWoK078vgSvdK1bXxs2F2/NlxZ8RGAX4j0FsuulrLcQUP7LJfJTAxQW2AdaXJhZgeT9nAa0pX6/efRap0L1CJlcBm+6bVAzQI/uphXDo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nWrpJedp; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nWrpJedp" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 582Aiqiv016289 for ; Tue, 2 Sep 2025 13:16:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lD73ebiFfjAcSdwGcgODwG3ayziIi/umNKznbuOBrsc=; b=nWrpJedp4Xio8Y5X iVy5kIuCc+bYttZiZRD9qHjiE536+9bbUZg6wOzoxLhEFI0EDQ+5R5glgJ7cs6sX SWe4xSHLhhZR03C3tYnocEvok+qb+f1v4FhOLTuoi1MPG68pBSrLHgezLxg9e/pj 4/5Z25e6eybZ+nX/JAPj6PDPOqxYnv50UzqQCVLijqbha0IRbL5QhDbSmhfnsWof zkmaNAAkb8ZWnlJEwxsHBH+OlVCE+eLZHQrt5Yi0YnOh2kS1ategYuxk0dOEPpDC f1JCjhueCvhpRtoujzSRIksPTg34ODBl5enCbBIr3CepDVWJvc4k9HMI87NXphIH IXfvkg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48urvyyvxq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 02 Sep 2025 13:16:31 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-77267239591so1880335b3a.2 for ; Tue, 02 Sep 2025 06:16:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756818990; x=1757423790; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lD73ebiFfjAcSdwGcgODwG3ayziIi/umNKznbuOBrsc=; b=hVAGqCFH/Q6QhKh3CIU2gq8oeSOegv6HLqWVnz3sxvT/a7qQ7TC69wNFZS1ayC4XqY SCKp2Dac5jxwMq51jEX63CHGDPdecIAemdQt+kSwvftfWDC5RksAOf8oHJ6A06kBGrE4 1z3j50Wos8SYcWGGqyEXNkBgPsRFzSqvOHA5Xorh6VmG7xW5NbsQY+oizOD8FkkMiw8O Y6GdZGqcct53kLV9e9zYhso3V2XRCPiS/C8j8MYcXtZ7thJRv2eianJ3ElIGLXKawpep zlNo4YfjOMceNl10maXO7KAwmaG6WbYOLNNGPZMW6donpKdStYYeMXWVFDM6WD0Ba0Ie 3iaQ== X-Forwarded-Encrypted: i=1; AJvYcCW2iaWG4ncdGnGnmlTUTFCt5zUBZf+eribPzXHZaJxMU2ACSaaRZN7E1+LoUdI7QJw6PCSrwt1oCNoQe28=@vger.kernel.org X-Gm-Message-State: AOJu0YyMgvaRWXhU1lfeLQHbSMhNjWs2BW/Q1TQ2mrlVFs48VEfYxlDo NCJhkccJbkdYZLQVRSYCUZYAMsQI2t+lVruLCiCaDnA2vj7wy1AYIIeqyUXljpMu8rgdOdoWHep 8M0Upk7e/GffHiaGl5LoH92Dw2Vl6qF7Tyihf3PM3QLavH8OOalQZ3hsa6FfxxCzdJDU= X-Gm-Gg: ASbGnctwSon3Iy+E411UAPl3flVsb0XZCG71AUq3O8l5gBjY23KQXCkoY1clLxIeu++ AoehZsx7zKAzrQrirBF0HA78jznoeLqXoTk0956hl3EsVSlMycusEO8CxhOqxcibMZEQ6a+b1Da 7t2e/ewIH+fNDEEUgSAjd/v0lhVhcS4r/ZVTiE4tENUxY5QUKQGx6mOLc5jjHyK+73z1RjFl3X0 F5I2wmcPEPd5IAer0EnduhCKNfwHBA2L5Calkvc6LpF10bXFxUXyXNkaIa6Cr2i7clgdQZgex2l YyI4MucxG5ouk7997xh0wep/Uft2U3UJBNN7gpmF8o4ZoxY0U7Sk9DNSz7ihYQ== X-Received: by 2002:a05:6a00:2194:b0:772:7251:7148 with SMTP id d2e1a72fcca58-772725173a8mr2742438b3a.27.1756818989563; Tue, 02 Sep 2025 06:16:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFd4VwxuS1eGRypUe4kM4U6jYmO0Ezi3tIVq6bOYrcgkw40C61F2D+N3HvW7dh77+xCl7mZkA== X-Received: by 2002:a05:6a00:2194:b0:772:7251:7148 with SMTP id d2e1a72fcca58-772725173a8mr2742364b3a.27.1756818988929; Tue, 02 Sep 2025 06:16:28 -0700 (PDT) Received: from [10.91.118.43] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7722a26bc9csm13790790b3a.18.2025.09.02.06.16.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 06:16:28 -0700 (PDT) Message-ID: Date: Tue, 2 Sep 2025 18:46:22 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] drm/msm: Fix bootup splat with separate_gpu_drm modparam To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Konrad Dybcio , Jordan Crouse , Jonathan Marek , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250902-assorted-sept-1-v1-0-f3ec9baed513@oss.qualcomm.com> <20250902-assorted-sept-1-v1-1-f3ec9baed513@oss.qualcomm.com> <2mhq73sckc3x7rqvllbmfk3qwla2lqqidchecogytxyramoeu5@66j7zupcni2i> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <2mhq73sckc3x7rqvllbmfk3qwla2lqqidchecogytxyramoeu5@66j7zupcni2i> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: hoNWFKR9VrOrBH99qnX-RyBEW8RRo9I1 X-Proofpoint-ORIG-GUID: hoNWFKR9VrOrBH99qnX-RyBEW8RRo9I1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODMwMDAyNyBTYWx0ZWRfXxd5YjI8a8XZ/ vmE8SPL7GrfAa2E9ZHACoznP2H0sSUbli04DfT8PqgaHxETYS2WQqELRvNhrX9T0XhLA0cxCVV4 /2uMfwVjVBB+ru9zeE2s4XTeOpNEMXvSCGBBqCKs7GdIHxJ4lqko8yvoUIw0OxxNGC0LV+EwAGC K7RBUmqFidTX2QrZFLD4RvMOeFG4M7BpwK/pE9hn3N6ewyFord/NOv4/3v075ZvanM0m5+blayj bZseMJNyU1fUHCVO+aqw3TIHyQJoLlg+Kup1doPPcMIB4v9rXMNVZqoSFwMLcBw1hHy/RxfBlGh ubvidyc5+427nNNjD3YzmoZEAdOcrMyHrSVxR3zPjGgmV15rOQz/ASU0ej7LB+nAOiYXFOPmePK EL6Rkk5q X-Authority-Analysis: v=2.4 cv=NrDRc9dJ c=1 sm=1 tr=0 ts=68b6ee2f cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=gUvfbfcqA5cecSJ7q00A:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-02_04,2025-08-28_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 spamscore=0 bulkscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2508300027 On 9/2/2025 5:57 PM, Dmitry Baryshkov wrote: > On Tue, Sep 02, 2025 at 05:20:00PM +0530, Akhil P Oommen wrote: >> The drm_gem_for_each_gpuvm_bo() call from lookup_vma() accesses >> drm_gem_obj.gpuva.list, which is not initialized when the drm driver >> does not support DRIVER_GEM_GPUVA feature. Enable it for msm_kms >> drm driver to fix the splat seen when msm.separate_gpu_drm=1 modparam >> is set: >> >> [ 9.506020] Unable to handle kernel paging request at virtual address fffffffffffffff0 >> [ 9.523160] Mem abort info: >> [ 9.523161] ESR = 0x0000000096000006 >> [ 9.523163] EC = 0x25: DABT (current EL), IL = 32 bits >> [ 9.523165] SET = 0, FnV = 0 >> [ 9.523166] EA = 0, S1PTW = 0 >> [ 9.523167] FSC = 0x06: level 2 translation fault >> [ 9.523169] Data abort info: >> [ 9.523170] ISV = 0, ISS = 0x00000006, ISS2 = 0x00000000 >> [ 9.523171] CM = 0, WnR = 0, TnD = 0, TagAccess = 0 >> [ 9.523172] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0 >> [ 9.523174] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000ad370f000 >> [ 9.523176] [fffffffffffffff0] pgd=0000000000000000, p4d=0000000ad4787403, pud=0000000ad4788403, pmd=0000000000000000 >> [ 9.523184] Internal error: Oops: 0000000096000006 [#1] SMP >> [ 9.592968] CPU: 9 UID: 0 PID: 448 Comm: (udev-worker) Not tainted 6.17.0-rc4-assorted-fix-00005-g0e9bb53a2282-dirty #3 PREEMPT >> [ 9.592970] Hardware name: Qualcomm CRD, BIOS 6.0.240718.BOOT.MXF.2.4-00515-HAMOA-1 07/18/2024 >> [ 9.592971] pstate: a1400005 (NzCv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--) >> [ 9.592973] pc : lookup_vma+0x28/0xe0 [msm] >> [ 9.592996] lr : get_vma_locked+0x2c/0x128 [msm] >> [ 9.763632] sp : ffff800082dab460 >> [ 9.763666] Call trace: >> [ 9.763668] lookup_vma+0x28/0xe0 [msm] (P) >> [ 9.763688] get_vma_locked+0x2c/0x128 [msm] >> [ 9.763706] msm_gem_get_and_pin_iova_range+0x68/0x11c [msm] >> [ 9.763723] msm_gem_get_and_pin_iova+0x18/0x24 [msm] >> [ 9.763740] msm_fbdev_driver_fbdev_probe+0xd0/0x258 [msm] >> [ 9.763760] __drm_fb_helper_initial_config_and_unlock+0x288/0x528 [drm_kms_helper] >> [ 9.763771] drm_fb_helper_initial_config+0x44/0x54 [drm_kms_helper] >> [ 9.763779] drm_fbdev_client_hotplug+0x84/0xd4 [drm_client_lib] >> [ 9.763782] drm_client_register+0x58/0x9c [drm] >> [ 9.763806] drm_fbdev_client_setup+0xe8/0xcf0 [drm_client_lib] >> [ 9.763809] drm_client_setup+0xb4/0xd8 [drm_client_lib] >> [ 9.763811] msm_drm_kms_post_init+0x2c/0x3c [msm] >> [ 9.763830] msm_drm_init+0x1a8/0x22c [msm] >> [ 9.763848] msm_drm_bind+0x30/0x3c [msm] >> [ 9.919273] try_to_bring_up_aggregate_device+0x168/0x1d4 >> [ 9.919283] __component_add+0xa4/0x170 >> [ 9.919286] component_add+0x14/0x20 >> [ 9.919288] msm_dp_display_probe_tail+0x4c/0xac [msm] >> [ 9.919315] msm_dp_auxbus_done_probe+0x14/0x20 [msm] >> [ 9.919335] dp_aux_ep_probe+0x4c/0xf0 [drm_dp_aux_bus] >> [ 9.919341] really_probe+0xbc/0x298 >> [ 9.919345] __driver_probe_device+0x78/0x12c >> [ 9.919348] driver_probe_device+0x40/0x160 >> [ 9.919350] __driver_attach+0x94/0x19c >> [ 9.919353] bus_for_each_dev+0x74/0xd4 >> [ 9.919355] driver_attach+0x24/0x30 >> [ 9.919358] bus_add_driver+0xe4/0x208 >> [ 9.919360] driver_register+0x60/0x128 >> [ 9.919363] __dp_aux_dp_driver_register+0x24/0x30 [drm_dp_aux_bus] >> [ 9.919365] atana33xc20_init+0x20/0x1000 [panel_samsung_atna33xc20] >> [ 9.919370] do_one_initcall+0x6c/0x1b0 >> [ 9.919374] do_init_module+0x58/0x234 >> [ 9.919377] load_module+0x19cc/0x1bd4 >> [ 9.919380] init_module_from_file+0x84/0xc4 >> [ 9.919382] __arm64_sys_finit_module+0x1b8/0x2cc >> [ 9.919384] invoke_syscall+0x48/0x110 >> [ 9.919389] el0_svc_common.constprop.0+0xc8/0xe8 >> [ 9.919393] do_el0_svc+0x20/0x2c >> [ 9.919396] el0_svc+0x34/0xf0 >> [ 9.919401] el0t_64_sync_handler+0xa0/0xe4 >> [ 9.919403] el0t_64_sync+0x198/0x19c >> [ 9.919407] Code: eb0000bf 54000480 d100a003 aa0303e2 (f8418c44) >> [ 9.919410] ---[ end trace 0000000000000000 ]--- > > Nit: usually you can drop timestamps from the kernel log. Missed my eyes. Will update in v2. -Akhil. > >> >> Fixes: 217ed15bd399 ("drm/msm: enable separate binding of GPU and display devices") >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/msm_drv.c | 1 + >> 1 file changed, 1 insertion(+) >> > > Reviewed-by: Dmitry Baryshkov > >