From: Sebastien Boisvert <sboisvert@gydle.com>
To: Andi Kleen <andi@firstfloor.org>,
acme@kernel.org, linux-perf-users@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jolsa@kernel.org,
namhyung@kernel.org, eranian@google.com,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 03/11] perf tools report: Support nano seconds
Date: Mon, 25 Feb 2019 11:40:45 -0500 [thread overview]
Message-ID: <d90b76f2-8d53-05ac-1526-9f0ddc4a0328@gydle.com> (raw)
In-Reply-To: <20190224153722.27020-4-andi@firstfloor.org>
On 2019-02-24 10:37 a.m., Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Upcoming changes add timestamp output in perf report. Add a --ns
> argument similar to perf script to support nanoseconds resolution
> when needed.
Is this a ISO-8601 date with nanoseconds ?
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/Documentation/perf-report.txt | 3 +++
> tools/perf/builtin-report.c | 1 +
> tools/perf/builtin-script.c | 1 -
> tools/perf/util/sort.c | 1 +
> tools/perf/util/sort.h | 2 ++
> 5 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
> index 1a27bfe05039..51dbc519dbce 100644
> --- a/tools/perf/Documentation/perf-report.txt
> +++ b/tools/perf/Documentation/perf-report.txt
> @@ -477,6 +477,9 @@ include::itrace.txt[]
> Please note that not all mmaps are stored, options affecting which ones
> are include 'perf record --data', for instance.
>
> +--ns::
> + Show time stamps in nanoseconds.
> +
> --stats::
> Display overall events statistics without any further processing.
> (like the one at the end of the perf report -D command)
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 2e8c74d6430c..bb8918a747ba 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1147,6 +1147,7 @@ int cmd_report(int argc, const char **argv)
> OPT_CALLBACK(0, "percent-type", &report.annotation_opts, "local-period",
> "Set percent type local/global-period/hits",
> annotate_parse_percent_type),
> + OPT_BOOLEAN(0, "ns", &nanosecs, "Show times in nanosecs"),
> OPT_END()
> };
> struct perf_data data = {
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 261055302d08..628c04543974 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -59,7 +59,6 @@ static bool no_callchain;
> static bool latency_format;
> static bool system_wide;
> static bool print_flags;
> -static bool nanosecs;
> static const char *cpu_list;
> static DECLARE_BITMAP(cpu_bitmap, MAX_NR_CPUS);
> static struct perf_stat_config stat_config;
> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index 2b6c1ccb878c..d1010a966f9b 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -31,6 +31,7 @@ const char *field_order;
> regex_t ignore_callees_regex;
> int have_ignore_callees = 0;
> enum sort_mode sort__mode = SORT_MODE__NORMAL;
> +bool nanosecs = false;
>
> /*
> * Replaces all occurrences of a char used with the:
> diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
> index 2fbee0b1011c..98223d952404 100644
> --- a/tools/perf/util/sort.h
> +++ b/tools/perf/util/sort.h
> @@ -278,6 +278,8 @@ struct sort_entry {
> extern struct sort_entry sort_thread;
> extern struct list_head hist_entry__sort_list;
>
> +extern bool nanosecs;
> +
> struct perf_evlist;
> struct tep_handle;
> int setup_sorting(struct perf_evlist *evlist);
>
next prev parent reply other threads:[~2019-02-25 16:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 15:37 Support sample context in perf report Andi Kleen
2019-02-24 15:37 ` [PATCH 01/11] perf tools script: Handle missing fields with -F + Andi Kleen
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:49 ` Arnaldo Carvalho de Melo
2019-02-28 8:04 ` [tip:perf/core] perf " tip-bot for Andi Kleen
2019-02-24 15:37 ` [PATCH 02/11] perf tools script: Support insn output for normal samples Andi Kleen
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 12:56 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 03/11] perf tools report: Support nano seconds Andi Kleen
2019-02-25 16:40 ` Sebastien Boisvert [this message]
2019-02-25 17:34 ` Andi Kleen
2019-02-24 15:37 ` [PATCH 04/11] perf tools report: Parse time quantum Andi Kleen
2019-02-25 12:55 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 05/11] perf tools report: Support time sort key Andi Kleen
2019-02-24 15:37 ` [PATCH 06/11] perf tools report: Use less for scripts output Andi Kleen
2019-02-25 12:55 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 07/11] perf tools report: Support running scripts for current time range Andi Kleen
2019-02-25 12:55 ` Jiri Olsa
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:28 ` Andi Kleen
2019-02-25 13:35 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 08/11] perf tools: Add perf_exe() helper to find perf binary Andi Kleen
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:58 ` Arnaldo Carvalho de Melo
2019-02-28 8:05 ` [tip:perf/core] " tip-bot for Andi Kleen
2019-02-24 15:37 ` [PATCH 09/11] perf tools report: Support builtin perf script in scripts menu Andi Kleen
2019-02-25 12:57 ` Jiri Olsa
2019-02-24 15:37 ` [PATCH 10/11] perf tools: Add utility function to print ns time stamps Andi Kleen
2019-02-24 15:37 ` [PATCH 11/11] perf tools report: Implement browsing of individual samples Andi Kleen
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:33 ` Andi Kleen
2019-03-04 14:48 ` Jiri Olsa
2019-02-25 12:56 ` Jiri Olsa
2019-02-25 13:31 ` Andi Kleen
2019-02-25 13:35 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d90b76f2-8d53-05ac-1526-9f0ddc4a0328@gydle.com \
--to=sboisvert@gydle.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®