From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbdLGUVg (ORCPT ); Thu, 7 Dec 2017 15:21:36 -0500 Received: from mail-co1nam03on0080.outbound.protection.outlook.com ([104.47.40.80]:35680 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750828AbdLGUVb (ORCPT ); Thu, 7 Dec 2017 15:21:31 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, LKML , x86@kernel.org, bp@alien8.de, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Borislav Petkov , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v9 12/38] crypto: ccp: Add Platform Security Processor (PSP) device support To: Philippe Ombredanne References: <20171205010438.5773-1-brijesh.singh@amd.com> <20171205010438.5773-13-brijesh.singh@amd.com> From: Brijesh Singh Message-ID: Date: Thu, 7 Dec 2017 14:21:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR08CA0050.namprd08.prod.outlook.com (10.172.144.12) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5003d45c-0c51-4f66-8042-08d53db01944 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603286);SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;3:2TKf6pdiSW3O03bhU0f7VCS14dUtqiRpfM0dsUd2BdC/zJBq/F4k+p/b2D1c9C/vaXP3tyUfcp4rZm09lZkrnMj7T29b8oVnvUOxNlG9uU9OOhsHwzXyh8eixITmbkt9Rq1zokJob+kcI2zyxRU+ze04SvTsZRS80u9jFgHSHFL7DRlJuGkHsPXWYlSMoDbjgPgVd3sHjjVXW83Nd4WbIMumrYklbbYAHBhzqY0bIM2ZP+Kk0ZDfz/TiLFdMyfWh;25:x6eZa/YL3CaYWUfkPzH2Rz07e6Wt4ThpjyCBU3pEQBvyhaiLxxctkCTlkQCpHoeAbr+EfQGQ0PPD9+pcFyCEXfynDlhYqCTia31oCIE/xKQMcj82IJI7TywBW3Usd8pJLJxy4p433Jt0vjZwDpHbOGwmmh5Etb3/u0VNnX1C7IHGrViK++5YfAjbCpqUj0jz/rIXfAZ0jy4E8MxI1iBQoHnBwiQVvW83vJK0JFaNVnM33UW06py+WPDcOMxH4MMFZkiDtADtkSMeTXgCo9XvdwrLzM/k0FM0zgsQEGcOUTmB5WypG9iCmSfsW9zPtEWFmBtFeMOg0Fw2PfbE8v/ZFQ==;31:QSVg9DHun9qvxiEWSYHWTB3Gl82LYlLvQmm6vE2bsi7t7AXgSBdVKSqfevAigSuBlHxauLZJG1F3rRrxmcBGWA+tfSJ+7G+6tima6s2QuCUH5a8Wsv+t8IftYFcRadbsxXig2Od0CXsp7ic15D+l2l1HyxENeezzPVAL94p7beoUACmYAN3/IiPLTX5rIrwN9FmAr1wp0JmaMyQgDXYgtFkhQFP9o6AZ7PumrILGpFg= X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:MxYMJJr9T6TgI3MZsRoYoJhybt+s7lwKbjzrOWGXXgmQeOb7i6N/3NucUiNJvsvfHqU4SXcqm/Cjjs4IlD5C2E3bM9xuaQy40NW9tOGXSW4Ae2yBZONR7mghXtN0WrZM9LeMh+MXhYqqff/saAjLbO5lJRysvpP420CRck5IV6HtRQjyrbUILsvOBmDE7JbFlFFkaVZnCFWjome9UTGZvkCCKBOCyIupcGEm+QnCSxwOEdQSVH31Yzz/cpI/XR5VzKbgexrmJ+qpeWMY1mP8lw1lGws+DQq+iFsjYTPj72mJ0g1QyNV8i+ArEG+85aricyAEi5e+u1cEkl220vE1R5vwEMVsZJo7PqCj7fq+3kvswkyt6kK0qf+Y+J0/1JGYKTn7GQxo7djOJkRiwNVUzzQU85xTumojNBzl8kmuatVqtfmRtx7wnaOykYa4QbKE0k8HKZe7qVpFvG/rxSo4wlc9yty4aNrP8hSWfnbKCf6FCralnwNV2DWDrXMrl9wm;4:jl2x6cc97yLhYUpCllIKQRM7C9atMR7VZIWa9o+bRuM486+C1sjvgt3rQqeY4B7t6Gfl1AzS9PthahGs0pns9xZNRBqzVR3wMavz3FXn1pDJsTmv/hituKQADnib9VjDj9RjkqQWGuPttVk4FOXp2jgrshH34a+q1VXjQxXx4Vnr2pqpEbR8frLMcwJGLzqnVt4bcbFUReJ8q5Pw18VyDmEf/nX7PlNmEPSCQZA1+TMKZeeL6VzY2rkXNExe5vpBqIiRyY5Y8DgEZSwrOqeeq9gEmV+6E4Qq7Dmf5ehUDrj62VHa1TlOCs1l3EIqNZwrLyxHEI5VrDPRYXQCw4Xxaw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:SN1PR12MB0158;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:SN1PR12MB0158; X-Forefront-PRVS: 05143A8241 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(366004)(376002)(346002)(39860400002)(24454002)(199004)(189003)(6916009)(81166006)(81156014)(2950100002)(54906003)(6666003)(5660300001)(230700001)(65826007)(6116002)(31686004)(47776003)(68736007)(478600001)(25786009)(65956001)(65806001)(90366009)(15650500001)(229853002)(3846002)(2906002)(66066001)(67846002)(50466002)(83506002)(77096006)(6486002)(7416002)(8676002)(101416001)(105586002)(305945005)(4326008)(106356001)(7736002)(33646002)(36756003)(6246003)(16576012)(23676004)(53936002)(58126008)(76176011)(97736004)(52146003)(316002)(31696002)(86362001)(64126003)(52116002)(8936002)(2486003)(16526018)(2004002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0158;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOmtyN2JUUkpkejZWSlY1QnhpR2ZsSEZjRXh5?= =?utf-8?B?TWcrYWFEdjVWN0ppU0pUVC9VOXhvRmVoZTJTZnJraVVwYi9pa3dsQlJZK0Zq?= =?utf-8?B?djB4bmZ2K1JqY3VvbEFtaHhrYW53OUtHTFJJNmw1MDNLYkF6WW1UZ2dvTStq?= =?utf-8?B?RTN2cFdEWVlHUG0xTU5QNW9sQXh3YytFOTVvSWV0YVR1ak1LUXk1RGdzOVNN?= =?utf-8?B?R0p6RXQwWUZRRTNDbmFvMC9PaDNIeFQ4N04xUE5IQUM5QWdCc29EV1ZvUHU2?= =?utf-8?B?Rjd5TlZHZkdYbGJrTlE3OXpRMGlxcGZvTjJ1dCtHaGE2RC8rQUhsTXdNa3pr?= =?utf-8?B?L0JOc3JnNGhvelFKN3d3cVZsTDZBd2ZSbDlnaXlZV2pGT2VQT3d2OVRoMnYr?= =?utf-8?B?ZEorcGx2MnBOTU1hb0dQYTROeVFiUTFqTEhCOG56NUdhUklscVpqR1AzbHNM?= =?utf-8?B?TzB3MlBOMWFvNFJKRTFtaGxyWGs0bmtvUEFIbW8xUnI3eFQzWWNXNG44Zkxm?= =?utf-8?B?ZkVGUzd0WFJ2NzRoZlFOZXlMQlNMK1ZLWGd3Rm5hWmJiZDZreml4SGJlNFU5?= =?utf-8?B?RTVIUlphU21VeE5SOHphdXRZTmFuSGpxMGdLMW5JN0pLU3VCR0pyZlBQNllE?= =?utf-8?B?Z3pXdHZ5TUYzZnA5R2N5SUdubzhjdkhoeDFYdnhac3ZtS3B1cEhxaEk5TUdI?= =?utf-8?B?ellwd3IybW54M2NIb1VJck5pL3VyNTU2MXcxUzRXb2x5SjBzS1RZUCthMFp0?= =?utf-8?B?UUsraTVaQ2trN0F0UzFsVU5PRW05Q1F2S1ZHWFVGSTV0cjMwZDZIcEpXUzJI?= =?utf-8?B?QlYrTmlKSUNPNmpBUmFSOTZuZzM1SkkrR1FTQ01SV2M2SVFzWEM3WUdzS2JH?= =?utf-8?B?Myt2Z0ZGYStYZnQ0K3ZPSXNGVFVBYmFDb3RLTTBicXhvMWlWYmNFZHoySGZu?= =?utf-8?B?MXZUellxbzBIZkVhTXBOcEd3NXY0ZCtBVTM3Rk5sTUpxV3hSZ0c4YTlSSERr?= =?utf-8?B?WFNndlc4bkZJT3YwWGh2T09pVEYzQ20xTkFJb2dlUmZkTUdrZjE0SW13cTF2?= =?utf-8?B?WkQ5c1pWMkJsS2NvN1U5K1lNQTV4L2FIWkVyMTlqUEJ6QW12M25lbks0SUtR?= =?utf-8?B?MzFPQmxINGgyb1lXKzN4REt5TkFrQ2dvY3dIMXFlUjdNSzNFNWpXd0ZKdjRP?= =?utf-8?B?WjN0R1FLQ25zcmlpeFdkTFJvMUtaYlBtNjY5UXcvRzExSklTNHRYS0pzU1gv?= =?utf-8?B?VkExOXk2a3FPN254MGlhcGl2THBRM1BjQTlKSzVBZEoyU3BXTmU3eFM3KzNs?= =?utf-8?B?SG5XRlkwNFdPSThpNFRFV2hSNnFDbTJKbndQMUtEeFFaNGJNNGh3NlJ3ZFVL?= =?utf-8?B?RHZXaUlnNVpETUFSZjk0S0ZkYStEWHNxdStnMmZuQUMreDg0UUxaaFBFNXNS?= =?utf-8?B?NnJRY29ybkd3cWVRaG5PMmE5UWhQTUlJK2FCcFVkU1QySWdhTm9CTlRXenVk?= =?utf-8?B?MGpzUkRlRHVPQmFFSVV5ZjV5UEJ4S25KeXp3am9ub3NPYkc4RkN5SXAzNDhP?= =?utf-8?B?TWRULzFHTW1VZ3ZabUoyWlUxVHYxd202RXhENFFZTDFGWWwwYktvZXRGLzkz?= =?utf-8?B?dnpEaTNvUnU5ejVuOFhNSUc1OVAwU0FGRitTT2s5cWFGRkFrdE5xWThZaHJv?= =?utf-8?B?YkNNM3RkZTRXY0Y3eWRyc2c2VTNhQ0ZmajdWaFcvY29RZHRxRytlbUZGSVFs?= =?utf-8?B?U2Y5VFg5bTlhc1phd0VFTlJRZGlFQUtlQk1QNDlaaHBlQTkvc3lCU2ZJNEtz?= =?utf-8?B?d3FlTnpKcjQzZXJvbThLdittVXNtY0tsRmpVdTAyNmdLcDN1VUxLY05yVGND?= =?utf-8?B?VDJEeStDbXFiekdHT3ZvWnh0OHFYUEZ0TkJNTHlLZ1VWd01zQnI3c3gyMWFR?= =?utf-8?Q?l377pAKAvYBvlU8RJ5NVl0PZhyX2N8=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;6:AjqsnVHXXgDQNS5MSbTokTcmx+BeIqxEZtMy/JG3ALayGn3iegzfxm+iFEipp2Fe4nshPcwCbg4tnVDT1luxtru2ZZGhoPyeurZa5ECMBXo2IjWoj2Wn/C0j7BRKDYHDZ9jJJ96D5lrTRowUl1OSnQqmsdnsgmYPWyDkO+E0bCdkZ5W2Sgq94dM2QLNmQdK87NQLwyjTyZzTpYvfD7ox0aXMddkCLmWR30BypzTE2WV+lVs6tfRmEmE0cuGsU9tbUEm+cVWOJe9o1oqhZ/nV/Pdjq7h9u9ZtwnDmAyHraETDphde1RSNZ61YCzbAnAgat+MW/Sa63dz9FTwID9TBgw4woXN6SV0TM19QWZYKuvA=;5:x4qTXsu9bLiTMzupC102QAK7OJUJOSoZNYPzx6zThI1Bpnky6MaxzwH/gB0yJoW+dBsJ7X6iuhSxocZ7/gkU/bI3INh4VF0mhRmlpBaSK07Kup53JoUo39JfBVDDqtlfQoFzvdZWD4+DLEufoGpztNWDxH3Cfu9ne8baQH6fbDM=;24:a+/uCpRhxSqZjHMFabN5xQvwPkcJAA5GZSZT95iDuj4r2k5vUY9hjX0t94mk+x6ZL5CYSjQhQZI4B+85c0i0Gxt2sLZ2NKToIvZJXjs3H2c=;7:IqY0bi7KEBFhD7vu2PMK2zEddy1UBrq3MjZ2KdSBx5XkwhwNGwYtTs1u1m8fwt2R9YoSyB1mlY55O92RucwY0Y4eeFFTC3lAEyArgRXyiDfQtUq52woROZLrgchu00FNvUJV8KQCGdYJtY49FvvMjglTAymF2jsYkboHFMfIJTMCjju3mea5gWpxHSd71FckGc5JLL4dRKi0bfl11SL7D0j3Wi2bJ5vNJ6tXfzxRklPdy8s1vIhUtIdkO2jteaqM SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:ZnSDSwe2y4UDHfV2tMyPCl1AATKVFE/zWDklY+EIA5nPDwDiIPsAqe3NyN0Q/+8YaevMjxOfvst8Ygvy+VW7EOtY/y8zUqw5oqc+acrCZzM+YTUZn2stFXgDskEvrf9ehVw0NIErJ0Ew9OP0PlhaSzvnuLIJ7doZlJHj7vH1dcp5CaoLb2rOGsSJsxyARLsFUhkA02osxS0eE8zYj818mEGaVm44x5eNY9tEJ0s8L+gB2KZgjn0E37t/TuprZHFZ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2017 20:21:27.5564 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5003d45c-0c51-4f66-8042-08d53db01944 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2017 03:10 PM, Philippe Ombredanne wrote:>> diff --git a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c >> new file mode 100644 >> index 000000000000..b5789f878560 >> --- /dev/null >> +++ b/drivers/crypto/ccp/psp-dev.c >> @@ -0,0 +1,105 @@ >> +/* >> + * AMD Platform Security Processor (PSP) interface >> + * >> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc. >> + * >> + * Author: Brijesh Singh >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + */ > > Dear Brijesh, > > Have you considered using the new SPDX license ids instead? > > This would come out this way: >> +// SDPX-License-Identifier: GPL-2.0 >> +/* >> + * AMD Platform Security Processor (PSP) interface >> + * >> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc. >> + * >> + * Author: Brijesh Singh >> + */ > > It is much cleaner and simpler, right? > > For the C++ comment style and first line placement, please see Thomas > (tlgx) doc patches and Linus posts explaining his rationale of why he > wants it this way. > It would be awesome if this could be applied to all AMD contributions btw! > Hi Philippe, I was not aware of SPDX identifier, If v10 is needed for SEV series then I will certainly update the patches to use SPDX license identifier. thanks -Brijesh