From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pengpeng Hou <hppiscas@163.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Jingoo Han <jg1.han@samsung.com>,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: host: ohci-exynos: Propagate clock errors from resume
Date: Sun, 6 Sep 2026 08:36:32 +0200 [thread overview]
Message-ID: <d90c8bd7-8d6a-47f2-b425-ac868f64a48b@kernel.org> (raw)
In-Reply-To: <20260906034031.85248-1-hppiscas@163.com>
On 06/09/2026 05:40, Pengpeng Hou wrote:
> exynos_ohci_resume() ignores clk_prepare_enable() and proceeds to PHY
No, clk_prepare_enable() is not ignored. It is called.
What is ignored is the return status, because it does not matter. It
cannot possibly fail, it is simple MMIO access within internals of the SoC.
Anyway, please rephrase the commit msg.
> and OHCI restoration.
>
> Return a clock failure before enabling the PHY. The existing PHY failure
> path continues to undo a successfully enabled clock.
>
> The issue was found by our static-analysis tool and manually reviewed.
>
> Fixes: e864abed546f ("USB: ohci-exynos: add clock gating to suspend/resume")
IMO, I have doubts whether this is a fix, because actual error cannot
happen in practice.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-09-06 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 3:40 Pengpeng Hou
2026-09-06 6:36 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d90c8bd7-8d6a-47f2-b425-ac868f64a48b@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hppiscas@163.com \
--cc=jg1.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®