From: Mark Salyzyn <salyzyn@android.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.kw@hitachi.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Kees Cook <keescook@chromium.org>,
Tony Luck <tony.luck@intel.com>
Cc: linux-kernel@vger.kernel.org,
Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>,
Seiji Aguchi <seiji.aguchi.tr@hitachi.com>
Subject: Re: [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances
Date: Thu, 2 Feb 2017 14:17:38 -0800 [thread overview]
Message-ID: <d9166924-eb13-e7e1-f85e-7cc32f26c063@android.com> (raw)
In-Reply-To: <1485827915-9620-3-git-send-email-nobuhiro.iwamatsu.kw@hitachi.com>
On 01/30/2017 05:58 PM, Nobuhiro Iwamatsu wrote:
> diff --git a/include/linux/pstore.h b/include/linux/pstore.h
> index 0da29cae009b..7a5db4833b8a 100644
> --- a/include/linux/pstore.h
> +++ b/include/linux/pstore.h
> @@ -55,6 +55,7 @@ struct pstore_info {
> size_t bufsize;
> struct mutex read_mutex; /* serialize open/read/close */
> int flags;
> + unsigned int num_pmsg;
> int (*open)(struct pstore_info *psi);
> int (*close)(struct pstore_info *psi);
> ssize_t (*read)(u64 *id, enum pstore_type_id *type,
Before patch there was an implication that num_pmsg was 1, after patch
calloc leaves this at a value of 0. Please reconcile the functional
difference that this causes.
-- Mark
next prev parent reply other threads:[~2017-02-02 22:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 1:58 [PATCH v4 2nd 0/4] pstore: ramoops: " Nobuhiro Iwamatsu
2017-01-31 1:58 ` [PATCH v4 2nd 1/4] ramoops: Add __ramoops_init_prz() as generic function Nobuhiro Iwamatsu
2017-02-02 22:13 ` Mark Salyzyn
2017-02-07 8:51 ` 岩松信洋 / IWAMATSU，NOBUHIRO
2017-02-07 16:05 ` Mark Salyzyn
2017-01-31 1:58 ` [PATCH v4 2nd 2/4] pstore: support multiple pmsg instances Nobuhiro Iwamatsu
2017-02-01 20:28 ` Kees Cook
2017-02-07 8:44 ` 岩松信洋 / IWAMATSU，NOBUHIRO
2017-02-02 22:17 ` Mark Salyzyn [this message]
2017-02-07 8:47 ` 岩松信洋 / IWAMATSU，NOBUHIRO
2017-01-31 1:58 ` [PATCH v4 2nd 3/4] ramoops: " Nobuhiro Iwamatsu
2017-01-31 1:58 ` [PATCH v4 2nd 4/4] selftests/pstore: add testcases for " Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9166924-eb13-e7e1-f85e-7cc32f26c063@android.com \
--to=salyzyn@android.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=hiraku.toyooka.gu@hitachi.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nobuhiro.iwamatsu.kw@hitachi.com \
--cc=seiji.aguchi.tr@hitachi.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome