From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF992441021 for ; Thu, 22 Jan 2026 11:51:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769082694; cv=none; b=HlAy91SU6QegopGWy1mQtwvP+XfT0fKP3XMOcxCPC1ZbxB4UdssIL2UsdD5vzfggZSHL2Os2EpE6RxsiGKJxUrMXnXRxGezgfLxEWHz178QAQ6r7GxNwz2MieLpaIaeUfPYwLFPdF1FwIykhu2+cxiJKiVQJX+/8h8m/PZJ1614= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769082694; c=relaxed/simple; bh=7KL1VMVD3OFpbZXu6ToVT7ahy8hRxRMUgANKnvOVq7I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DoR3EqEMUooGESSiXAoluKrZ3WULmcA+h9fmMEosBcG7kWOvFTCjbvhbLrHq61kvPOLl/lvFRosybrFu/XyvLXth47UwSNAgmmLXb3vx04Mt9oUyLEER1DZYN8TT3jy2Xh8jkGlIKQezkK9F5Aq/jf2OKBxPSP1drX4sGvEmvOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=B3YJwLdg; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CNiGR02K; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B3YJwLdg"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CNiGR02K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769082691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7JTm3xpnzgFJS91sLL+soLriB/Qr5GTFc7WAwtsXhWA=; b=B3YJwLdgWu0sH03BtW89nqfch15u7M8VedXgRiUuPaAvYkI4ZafaU1nNt6+V9NTAAioUNK 2t1Pb3AyLvKARQMIWO3p680LXbsWrL9vVP54l3o82eOZHbRzGiCMUx/95JWW2vul6GbSMa 641uuwQr4Ha8+ls9659P2pO/vqAABNg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-628-O7pcN5sNM0G2KkYcJ65Vvw-1; Thu, 22 Jan 2026 06:51:30 -0500 X-MC-Unique: O7pcN5sNM0G2KkYcJ65Vvw-1 X-Mimecast-MFC-AGG-ID: O7pcN5sNM0G2KkYcJ65Vvw_1769082689 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-4325aa61c6bso531522f8f.0 for ; Thu, 22 Jan 2026 03:51:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769082689; x=1769687489; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7JTm3xpnzgFJS91sLL+soLriB/Qr5GTFc7WAwtsXhWA=; b=CNiGR02KxtXnSh+DoOi8sZI2ctNVylVd5kk1li9xKA7iSsGlfQdMlVYh47mwqeT9pl FsXzkcUhBZXNOpGyktU1AI8WbApeeUJ/P3qGrPO+RIa7aisOI/5StRW2dh7tTGWXMPCJ mgOyNok8d3kIAyMWP61S8jBYNvjhNr9mJD7Keei1rOE40Y7AaSQkiJHNzPL87y7fTtiI oMyRn3uy3lJcnhDxSUKc9CnPPKF4bDdV7n7p9L5xo0TuNIw/DhGzcGLcgtlQ8gf3p5Uq 4xydtgay+CGyewTqQlgpb6kgHuSNbG4Ry1mJyYy3TdQSver0OP5cKHpH0Qirkwhpi7PL bw/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769082689; x=1769687489; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7JTm3xpnzgFJS91sLL+soLriB/Qr5GTFc7WAwtsXhWA=; b=DjeU2FCmM5RBwxvw5OlJFxCNapR24q1V6kaLqxfAfhV1N1NS6Ju66m1d3wRakWiOPO qVnRexKIPrFwetfAxzeKdissPX5TQeqJAsHBeo1jMyzZSvCCsaKBqx8TaRC3DMTp+R1K Ij3WYQXQ5ujO/8eL8W/kMKElypdCobaRfccPuJ0GrBxdVrL+OkZaT/4RzHSwXXicdrrC BT0i/ol7/AtefTmL26FP0n6UZUnJVayqZm/krvd7PG3B8Pl5egsj6PLjYLYXQp+flNYo VTNF1hHMrgX8x9QLes0c7xePDT3+V24sNaw5xx0O0tovpOfGM7cKlu61u88JuThtbXVJ sbgw== X-Forwarded-Encrypted: i=1; AJvYcCU/X2ruHZ/8t/7wYY7ZmHb6Oin0tn8hRoclFUt7OUYZ9gEl7apdWAVfp6oPxdG7zCTwcXa2cPdMXdS8kmg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzx55VxT0VrBQCtvGlR7jS5B6m8uATjJr+flEk84t1U1G5esWsm 9Inzr4Co1xTNibcS/0iK50BnJX9vFwAyjkNYoI1iAwEVUcreKFW84P8d7D5ZF+YZyXytU05NTpc 3iTHSA0yCmOYb/UA/y2lrOidLMlddqRVUarpc7ZhqvFpyN1ukuu4fuGsn4hLiAkg8AA== X-Gm-Gg: AZuq6aJtROmFTnHYsdrTMpRJGGmVXVLbW5JmIdbpqKdr7QhIrpbgwbaMfh/tGcT+HLl RWGGBJY6Cs2jxO/lVPBRq+CX6mV+f8udzLw563sh663IjhEdc1sh4DIukaeJn4sTEonj3tRM+HN +zvt3pflNh/cJjjesORiIqjGGiaflPezdGVungQaa3gPzvVts7Y4RIoO+xgDTm/fNi7dOYlpzAC /M42w2MdJkSQQnfvMPCFkAqP0qxNkG7IyznTHZ6d5GhZhd15bpbhRzqj4XOMVpJkp28XIxto13n mhV7bmrU0BKIYu02BwKes6yjQdi+Pn7YLFQd+1bDZYHEB3mQ3mFj65tWQFP1rsuLIB5aftIDRAV ogW5feem5U4qF X-Received: by 2002:a5d:5d83:0:b0:425:769e:515a with SMTP id ffacd0b85a97d-4356a05c0bcmr32153859f8f.42.1769082689344; Thu, 22 Jan 2026 03:51:29 -0800 (PST) X-Received: by 2002:a5d:5d83:0:b0:425:769e:515a with SMTP id ffacd0b85a97d-4356a05c0bcmr32153818f8f.42.1769082688972; Thu, 22 Jan 2026 03:51:28 -0800 (PST) Received: from [192.168.88.32] ([216.128.11.175]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4358f12ee69sm21693720f8f.11.2026.01.22.03.51.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 03:51:28 -0800 (PST) Message-ID: Date: Thu, 22 Jan 2026 12:51:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: spacemit: Clarify stat timeout comments and messages To: Vivian Wang , Jakub Kicinski Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Yixun Lan , Chukun Pan , Michael Opdenacker , netdev@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260121-k1-ethernet-clarify-stat-timeout-v2-1-76ff1a1168d9@iscas.ac.cn> <20260121200439.64c22125@kernel.org> <5639ff0c-dfd1-4528-a0ce-92d3c457ce64@iscas.ac.cn> Content-Language: en-US From: Paolo Abeni In-Reply-To: <5639ff0c-dfd1-4528-a0ce-92d3c457ce64@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/22/26 11:39 AM, Vivian Wang wrote: > On 1/22/26 12:04, Jakub Kicinski wrote: >> On Wed, 21 Jan 2026 10:17:18 +0800 Vivian Wang wrote: >>> This patch isn't a fix for the problem per se, since it is hardware >>> behavior. The new message and comments, however, should direct those >>> running into this on new hardware towards a fix. >> Is it not possible to improve the situation? > > Maybe I should have made it clearer, but this comment and messages > improvement was proposed by Andrew in the linked thread [1]. > > As an aside, saying that made me realize this patch should be: > > Suggested-by: Andrew Lunn > >> Is the refclock disappearing because of power saving? >> Or because the link is down? > > I'm not really well-versed in what's allowed from the PHY here, but at > least the Motorcomm and Realtek PHYs seem to only stop this clock while > the link is down. So from what I can tell it's PHY stopping the clock > because of power saving for when the link is down. I'm not sure how that > should translate into an answer to your question here... > >> Because if it's the latter we should be able to skip reading the stats >> when link is down (still racy but better than waiting in cases we can >> detect?) > > If checking the link is definitely up as a condition for updating stats > would be acceptable, then maybe the original patch from the linked > thread [2] can also be adopted? My understanding is that such option would fit Jakub's suggestion. Note that the commit message should be expanded and clarified WRT the original submission. /P