From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C5C21A9FA7 for ; Mon, 2 Mar 2026 16:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772468108; cv=none; b=NmjT1BCK9pPY9br06FBfKYlkNiSGTglkl3fbw/o/dQL2y/I3xYFp++ykWR723/0k/RcbrnhFUKNPA9NW7C3rckWrq4hmbs3MOHV+DMII2aBr4S4sEUGHt7TUotnXjPvYEMvktfqQslKvlQo0+jN2i7ho8/NYfg55GSsOxj6qe10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772468108; c=relaxed/simple; bh=8GD2iWJim7kYdz0G3J09qCaIKjDGwlSkBDVLBsaUGvo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=leVzdr8KqeiVCmjwqP9GfkciqnIuUoyKWex80XM5F6P3ZBS/K6KgjenS6VrmoJClffBSFxc7qApoW3j6p36Rlv+ej8mXRPHMUlpD9da2lFivsXbcb/B2n7qGgQq6OLRsb12M4OosMfdjqAyAvYiwTWPZPcnPDNHVezMU5zdRfP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=FNggyPq6; arc=none smtp.client-ip=209.85.210.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="FNggyPq6" Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-7d4bc9e48bbso2224841a34.2 for ; Mon, 02 Mar 2026 08:15:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1772468105; x=1773072905; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jr7yd0FVfAcPCwKFpMsPFjSUxY3s3eXmkELD2qfsYR0=; b=FNggyPq6ALrEZsgW3L+USUCGRljGj09hl1lqmpyrxHaV3kyw+NqIJdE4IgrcZDyXWf DbYtRNR/d7rixVS2b6U0sCUTg1W3dSwgvDhMgakvfkTJjWDKvmwVts327wjeTDcSDbi0 HW0msZooPu15QOwaLyKzZ69iUZe4MLE8v9BM6J9lBexdMuMAJf7Pi9ZHgbhLAvgYI/ML pPFp00zP3OO9OvOUBtuvLXmt56LJyBg3j8QHSVfO3CVYSgugtYQbGw6bY/hFWcaEA1dE ZYjSbTM5JbGuYNuepgJvEhaCFnWyQ3t7l5cz/DBwObahxI0Nj3D+kNdz69wZ6M+JxvJv XFuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772468105; x=1773072905; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jr7yd0FVfAcPCwKFpMsPFjSUxY3s3eXmkELD2qfsYR0=; b=EY0hXF4AtaRHu3ZXZPIbutui+faCH2XP1vduA82+pbjbG7x6oQiUdFDeykit1D50Cj uWLNYp2qpN8tUkldjgblZddm6RgAaarPLbvjbslyVuoF20bPnVYAwcQAKyPMTsOhhZBh Z909/oU07aaXfCBZ8aNIx+YzC0siJ5vlqxTzvdTgcyrpdoeLgY0aR0sRv8Nbn3l+YLZo q8jt3s3R3T4NAFz9nlekfw2sIHJmIMAMETQJMYvt7n7flkgke34sClygCRzCKdT1gqUE ZkAt14ri9cKbPMw2g/PU2hjy07bTdUpXkmBbN+pMggPpQLk5YSoPN5Xwnp0Xvsyek9di nhNQ== X-Forwarded-Encrypted: i=1; AJvYcCWdpbVjoQezaUK13V8OHzsA5+Ylf5jEkEbe6K7Ydiui5sQWyoooWlYj0UwiYLIk41+KQlnwxtRNZc4FnYw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3q2i0cvryAOdBhCN+V2m+z9s93HgX5n/n/YJbJRpNPfLj0m4r 8GEX1WebD869ERoRhGf9iLXSTgqK3o2INj4Ul/S1XHVPQw8aAlfWSiEQ1OLuDPJHHcw= X-Gm-Gg: ATEYQzwbgtUZ9uhq3ZYQNGFUYDFHYsD++qvlHAXJbuiFhl6gCKzNBAZWpt/iWtEi7Om pgg6i+QyQFuJKb3Ky2NznYmU7H5mxSdAiyPWnSxtwQ8+byl/prFanTTGjd3eSvp/8qdAcBozNgi UF2pkH1GSBXCANrjlmVtFqJ24EhInPrZEpL43HYlho+XOOcnuIM+r5SktY/8iBw0qrJ66TPNsv7 oQb8Ti4ZaTVTTywUjfxpnDpAlIwVVId85AbWPfoQH6YHyAZEmWdNEtfaunMG3n/UrI6nT0bcnFH iDDiHWKpyhqUZOWiUsrtqePUGZiZhdMVp/VJFbBwOPmQbBLhWrQ8W3kXsSbX0g8cf69kbaWlC1M 4xTWA820nQIYBh7RyvTN3HSSysdI/NDsSrkaxiB8vphOeszK4Z/7Ps5tfmdQskYsqVESo1NUDJf ojA6w+j5oIH7ZAKsPyELjFZuWrP4TOHs5prRZMiR+5hMetD0D+VCkWR804NFXsGcoaB5QmHbOOn Q== X-Received: by 2002:a05:6830:45c:b0:7d5:96a9:3883 with SMTP id 46e09a7af769-7d596a939f9mr4361431a34.23.1772468105614; Mon, 02 Mar 2026 08:15:05 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:4c09:7c6b:bc48:f2f7? ([2600:8803:e7e4:500:4c09:7c6b:bc48:f2f7]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d586625e4esm10996129a34.15.2026.03.02.08.15.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 08:15:05 -0800 (PST) Message-ID: Date: Mon, 2 Mar 2026 10:15:04 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: adc: ti-ads1119: Replace IRQF_ONESHOT with IRQF_NO_THREAD To: Felix Gu , Francesco Dolcini , =?UTF-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: =?UTF-8?Q?Jo=C3=A3o_Paulo_Gon=C3=A7alves?= , Francesco Dolcini , Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260303-ti-ads1119-v1-1-71b54880edf3@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260303-ti-ads1119-v1-1-71b54880edf3@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/2/26 10:00 AM, Felix Gu wrote: > Since commit aef30c8d569c ("genirq: Warn about using IRQF_ONESHOT > without a threaded handler"), the IRQ core checks IRQF_ONESHOT flag > in IRQ request and gives a warning if there is no threaded handler. > > Since there is no threaded handler, replace devm_request_threaded_irq > with devm_request_irq, and replace IRQF_ONESHOT with IRQF_NO_THREAD. > > Fixes: a9306887eba4 ("iio: adc: ti-ads1119: Add driver") > Signed-off-by: Felix Gu > --- Reviewed-by: David Lechner Although I would swap the order of paragraphs in the commit message. The second one is the real problem (so should go first) and the first one is just how the problem was found.