From: Andrew Lunn <andrew@lunn.ch>
To: Ian Rogers <irogers@google.com>
Cc: Pavan Chebbi <pavan.chebbi@broadcom.com>,
Michael Chan <michael.chan@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Elkin Cruz <elkin@google.com>
Subject: Re: [PATCH net] tg3: Propagate PHY reset retry failures in tg3_phy_reset_5703_4_5()
Date: Thu, 19 Nov 2026 21:15:14 +0100 [thread overview]
Message-ID: <d925c794-579f-4b7a-9ff9-8502d79b97ca@lunn.ch> (raw)
In-Reply-To: <20261119171021.1535172-1-irogers@google.com>
On Thu, Nov 19, 2026 at 09:10:21AM -0800, Ian Rogers wrote:
> In tg3_phy_reset_5703_4_5(), the 10-iteration retry loop discards the
> return value of both tg3_readphy() calls on continue and never checks
> err after the loop terminates. If MDIO reads fail across all 10
> retries,
If it fails 10 times, the hardware is dead, and there is no
recovery. The best you can do is make the probe fail.
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
This clearly does not bother anybody.
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
Andrew
prev parent reply other threads:[~2026-11-19 20:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 17:10 Ian Rogers
2026-11-19 20:15 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d925c794-579f-4b7a-9ff9-8502d79b97ca@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=elkin@google.com \
--cc=irogers@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®