From: Qian Cai <cai@lca.pw>
To: Kostya Serebryany <kcc@google.com>,
Nick Desaulniers <ndesaulniers@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
Mark Brown <broonie@kernel.org>,
Alexander Potapenko <glider@google.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Christoph Lameter <cl@linux.com>,
Andrey Konovalov <andreyknvl@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Evgenii Stepanov <eugenis@google.com>
Subject: Re: [PATCH] kasan: turn off asan-stack for clang-8 and earlier
Date: Tue, 19 Feb 2019 20:25:23 -0500 [thread overview]
Message-ID: <d925ca37-ff0d-adba-6e1e-a7eaa47404b0@lca.pw> (raw)
In-Reply-To: <CAN=P9pgC8EzawtxMzp6d3AsMPkSpTd0Ry6j+Jn+YgC_XP2Fd_w@mail.gmail.com>
On 2/19/19 7:33 PM, Kostya Serebryany wrote:
>>> Well, I am using clang 8.0 on arm64 and running the kernel just fine for a few
>>> weeks now and never trigger a single stack overflow (THREAD_SHIFT = 15) because
>>> I never use any of those drivers you mentioned above. I don't think it is a good
>>> idea to blankly remove the testing coverage here and affect people don't use all
>>> those offensive functions at all.
>>
>> Thanks for the patch, Arnd! Hopefully we can fix that up in Clang
>> soon. Qian, I guess the alternative would be to add `-mllvm
>> -asan-stack=0` on potentially up to 140 Makefiles?
Depends on the exact stack consumption of those 140 functions. For example, I
don't care if you turn-off -asan-stack if the current stack size is < 32k.
For those functions always consume like a lot of stack like 8k or more, fix them
in Makefile if not too many of them.
next prev parent reply other threads:[~2019-02-20 1:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 21:49 Arnd Bergmann
2019-02-19 22:17 ` Qian Cai
2019-02-19 22:43 ` Nick Desaulniers
2019-02-20 0:33 ` Kostya Serebryany
2019-02-20 1:25 ` Qian Cai [this message]
2019-02-20 6:44 ` Dmitry Vyukov
2019-02-20 9:19 ` Arnd Bergmann
2019-02-20 14:44 ` Andrey Konovalov
2019-02-20 14:51 ` Arnd Bergmann
2019-02-20 17:00 ` Andrey Ryabinin
2019-02-20 17:35 ` Arnd Bergmann
2019-02-20 18:07 ` Nick Desaulniers
2019-02-20 18:44 ` Mark Brown
2019-02-20 20:02 ` Nick Desaulniers
2019-02-20 21:13 ` Arnd Bergmann
2019-02-20 21:40 ` Arnd Bergmann
2019-02-20 22:12 ` Kostya Serebryany
2019-02-20 23:46 ` Kostya Serebryany
2019-02-21 17:19 ` Arnd Bergmann
2019-02-21 10:06 ` Andrey Ryabinin
2019-02-21 15:19 ` Arnd Bergmann
2019-02-21 16:14 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d925ca37-ff0d-adba-6e1e-a7eaa47404b0@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=broonie@kernel.org \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=schwidefsky@de.ibm.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®