From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.15.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8D7FD524; Sat, 22 Jun 2024 16:58:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719075537; cv=none; b=IFCjo4brLZuwe4bJUxiJrCie7CEeOu8cx4J7aNHxMavnt0qZwLXJVp5YAN4xRiNWpGvz5bnSOoFBh9jc6pF8x5VfoIjkH2AiPfelVpY5ddg5lVDLvnCy4jVIMQFZ20P9C/Qzwm+8F73dLeC4r5n7WISwEElj3VPokLmxMlDDVGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719075537; c=relaxed/simple; bh=LzuEAz5ACZZ3Z9HVdqDIC9jT2azVEnV3YngE0bu/gbE=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=ojbC1sNvJHQSxRxDjqaUuohhXsQbB8SC+GCr+Rgttlqjl3uINNdk5QHVI/xX0QN7vcpNwio3woEHnEwvAk+x6YVcpbBnwHgbGXaqw7t4kAXqp64c2NHfoaRTjd9o1cS3BWiyGgFiCtOLElpItbYNwIgIW0eqTNGE4dEXPHqH1i0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=HynXeE9z; arc=none smtp.client-ip=212.227.15.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="HynXeE9z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1719075502; x=1719680302; i=markus.elfring@web.de; bh=TcDyN6ebGmrRSeGodLD7ggmlinGRC7WoNwqGNQbVxCI=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:To:Cc:References: Subject:From:In-Reply-To:Content-Type:Content-Transfer-Encoding: cc:content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=HynXeE9zwyLTMwT3LvzNAqIBXOMeplJ7ZEygRxBvTDjFG32U8fPaMbm7Xywln3/t 7PhhIgySwJ7tg93G5tIHvX/pnhW0aF+gzIuxyt4sLR59KJ7Bx5abEIV3iGVWIHAI+ QqpUEm857O+H4Xt3oQ06oFPddSyNwkBo5v4x0Ky+deTpgRxAM7b/CrLAr2LFo4PT8 Ej+w3ejH7eQ+rszoFzxw+ZnOoSkQ6t36ZGg3yNStWUqCaxizScye8Y68PnIwQIN56 293Auh+CVxGu910cK4fxn1hb7628a25n9gt/t8hzyIKUJ+tE7x1WvCbK3le8qizft l8IkkASiskUA+VsdhQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.85.95]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N5UgI-1sRNVE0Rli-00vfMm; Sat, 22 Jun 2024 18:58:22 +0200 Message-ID: Date: Sat, 22 Jun 2024 18:58:20 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Huai-Yuan Liu , linux-hippi@sunsite.dk, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jes Sorensen , Paolo Abeni , Sunil Kovvuri Goutham Cc: LKML , Jia-Ju Bai References: <20240622063227.456107-1-qq810974084@gmail.com> Subject: Re: [PATCH V3] hippi: fix possible buffer overflow caused by bad DMA value in rr_start_xmit() Content-Language: en-GB From: Markus Elfring In-Reply-To: <20240622063227.456107-1-qq810974084@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Yy3/QPWZOkPJsFXP2RMxyU9jhXTMPneS8qs+SA9CLZnPk0mJsGA I4nyeoQ4z8sSkP7ZVwdybwkKpQAxo7cfjLa1rNTskGVCIZDka8h2XoKJFrPKU+CnEJ1+6gw q57bx7ZUpqaZWNHy42lL+V+hUjrRpb7JSwrRaPhVqscKAo+mv4+5HE/QuDrfGNxOtt8jUT+ lKU1GtDv+i18d44so8OhA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Uhl6KWuMk94=;1Z7xWg8hA+IBBAfoKhZKesB9XQ1 dcNVJRMdNWpzBVxujF5AlJmgAoOjZtes5HpSgkgLY+qKJvIHa/RnAiy1qKI631Mw4/Sn83z4l icDVIEZVEaQoRPoVSrIv9jQnBwTb7LioedbGjVv45BsA1PdJ2rJ/JU1Rge+33eV0cAaNv1/Qu fb1ImM+1mDmutizbEjgurhpnt48l8J5pr3bMrEU2aKWQaTZI7GQopjE9HhqthOLRgZaTSoQP1 mlCp6IUHqrm7FwBuS1eP4ErziruBR6XgzKY5nP45kzbQwxNPUf6GAQIGJy2JdHMAUBxGstRAi PzaReWRj49s4U5DapdZPI/Ec76+GisS9sWGAgRGLEgxMD27BFmctOXJMSIZg+QfK3Zw9l9s3B QU3vfcQr7gYf8y5e02jy116NXJLiLYn6LeI2wQTYBhG6XgHPpwwHAWFTVJ8E5GHA5Bc4UHpBd WPtlOF6iXkbgp0g80WRovrybAzc3knOll5qmAX6ZXqgju9bGHMdiFxF58DssiMXwyzUOeEv4g ZGlt/ZD/f5pMGBuduKHw9TCxB9jkXToEXvvyE9CsLg2TX4EFRQpx1K26AVXcZqQFtqn10PiUB li8Ya63EpaFZ0jDl0eXHWUtgDA6Ma5rdfaTI5O9xjKkM9qvkpGleTLTxBbcLnFiQQ7pBy/MGD +zQ14QaiCT60lEAu8IOugDIGYgkAm8vGvkjxEdanPF8mkuilPun76kUeQqEk5yi6prUib3Cmp j7GBxtGLpICacOMcZLkBZHRDNTR5djE36B0nMUGl/hG/A2h1sIR5VFLJSEbWd9CVPKWuUGK5w g1lRhKY2m5NryRgnFrRoL+Qd8ivxnfWumvasy2GpN5Jns= > =E2=80=A6. Becausetxctrl->pi is assigned to =E2=80=A6 Word separation? > To address this issue, the index should be checked. Can an imperative wording be more desirable for such a change description? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/process/submitting-patches.rst?h=3Dv6.10-rc4#n94 Regards, Markus