From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792477738; b=25PSBfRsTFHX4nDaR8WwjDag8A8q/QTYRAgJoVfe2qZgI6fjdIHdFoE07qE86XgKJgYb ZnkKnM1nAvAE/HkTWR/XkHEiUVPSmlFrMNS2TI2HK72VOW2p2W6jdL7RHUIrxhYzqNDKx D4Qc/og9rSPOhJYmEp4OFjMmMAGNFWEfaLsXv4BZUlhBXws4zDLAL47qs/fk9Uc4vNBmh Zs31FHwLewxWvJ2SWZbULf3ATzrDsbusj5BzDuia0gV0PziNpSHEMUCamuLsipSUHJHsx fhvKOO+RjbzPczv0RbZ2ihvikqFMnKpU9FBXwIxYuGcQc154iRVozHsErRUZZmBc6XQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792477738; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-ORIG-GUID: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-Spam-Info: X-Authority-Analysis:X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=jZcm4xn8R1wI1FG/ihJT42XES5tbZ9l7S/ULBsgYweY=; b=LcE/EJh9l/uT4VGMxAOdxDD++0pMVaC9qHLNjcnKvnxTmsa7+vBnlYO8K4FfYU0Xu78i 61ENIfsazZJtrxTTDpsPknI/+LoFw9G/CI7ZEMcI41IuPqP/fIssy/OldCGTY8W1GnnFd U/WhtKTyVe0oXvfFRXaKgktjwSgNqCJ3qjCwU3fbHJq4sP5LZ5ppjf19V/tRiIjIwL7Rw EE6UT1vtfTJDktkPIFOdwfB/zyA/wjAsJBjm/wKF0j1bv10O5XQ2YA9aKczS4Uahi3sQH /q1Jc+qCN5d1MchjsCv0R4vJsXCWdetJaVh0dxlmpAW0XszmiAfcF2nn19xQOhLa6DA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=HdX7H4VS; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=boMd2yM1; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DBAD606A31D for ; Tue, 20 Oct 2026 06:28:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8DBAD606A31D Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=HdX7H4VS; dkim=pass (2048-bit key, unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=boMd2yM1 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 69K0tXUk4032354 for ; Tue, 20 Oct 2026 06:28:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jZcm4xn8R1wI1FG/ihJT42XES5tbZ9l7S/ULBsgYweY=; b=HdX7H4VSz6pLF8gH JpPZacGT7sqCuPx9k/anR2BYBwdh7nfNZ3U2zbqsrekvOw6A3jP0YcLWLMSOhAl9 W9sODGkcIV5twKlysosQIpvT2R4ki9JXWlWx/XYcWNMT4j8tQ21DXH8Ycq2shPzs 8Actnb2ajBD5pBfMqKhB2NPfVgO6pcAvWX7zyEvaFi5paH/472OfQQGXdFpyVHV8 u8KTemw5COVfhSzpAUikKdS5FfWfkR84u8UTrH6IkUGcbTX/frWDGHzFwWE2HX7J YHbO4Uq/5WKlx8v3GUtxMo9Z9AdzMkRrrdByup0dJsd+bpj13tkRjhHVrvM8I9fW 8Wqv+w== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hdw5q94gf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 20 Oct 2026 06:28:56 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-93f1e62510cso698599885a.1 for ; Mon, 19 Oct 2026 23:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1792477736; x=1793082536; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jZcm4xn8R1wI1FG/ihJT42XES5tbZ9l7S/ULBsgYweY=; b=boMd2yM1bvEE4WKB0fjuiiv6L+ofl3Ky8WMeOkCOKgF5Kzzz7zGKhrgSYK+w6CT4ZS J+WFpQb5Ip2p66nMsFoqQwzVwfktgYd75mb2z6IDnlWZn/IRNkCIhDjN2uSLdFc6RI7s oaHZa5Edn6UqN4UuvspvmhPlRijdV/a5Al5N2P3Liskeb/JPWgm1nUS7rvh42od+/88n /Ufr9ph7WaEqAnqhC28GZfuHUQGS+JX/sL/ygGV2FSqv/KoZi4TEtoNlK1oruo7VvdqX k3l4Sy8DU4uD86Vx0iAcksGwQ8Jox7MfJvMJ7Q9ljs/LWWmknmOAW/nEJcVH9mlKRkgD C5oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792477736; x=1793082536; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jZcm4xn8R1wI1FG/ihJT42XES5tbZ9l7S/ULBsgYweY=; b=L3Yq4cdPiN3L0Lx1PvUb+8/V17mhgeWuTpXzHHKdXOBNzTXtJ7EcuR6hDazOIB8Zkb A/c729+Lv2r0UBZV2CPMRK2YUvmUrv9zBFBCWJFyUH7njlNTBziyQjSBim7cktms6ED4 QHJwMPOz/H/o7HK2LF8+xppM/gKWKJfffmh8ajX7FujDBueerpwazQPc7TcHuKntWfp3 OrRk/RBDH41jL6EqXE05xjuf+kmDZxGpSFgvtZ+7zpa8N6q8N57wCsNKs7jyxYxpFeAd zcMfudlyZOlnpOzeI9xHk4Cp2VE+ZSIFV6+OaXqfTpM4AjrFOp3zLldTUOK6peBtNJPd zUrg== X-Forwarded-Encrypted: i=1; AKwUvBy++clU8bYpsQValoA+J6IrjECXUPHkPPQtlGdYY7Gt0dE24Mm7vvj7/iGh8Uhw1+x0A7UK10zeqGvERuk=@vger.kernel.org X-Gm-Message-State: AFq9FYJRFR5TnQA9uQZkqxT9REMhgTyj3a1kRNcXH1dBVtoiZFmQzY3E uiDQqQyJnc/sibAdPRew07COjPNSO/vx71imBXW+ozbdW4DCSsCM0QGS/KWLdhD3Z8/sMdbskkI BGUsSdy8AqNoSWbThTX9Kgs+IjTUcAjZlUkOuNGL7hR1RCnlrS46A/zE2hLkHpUoQ2fwlF4kkFh E= X-Gm-Gg: AYBFou2uX6UPaZz2BD6UB2wgt5OJYp1nc1HhplEuVbPzTik7tkiFjEBwZvhXUxoymzJ Jh+AeQ4xJL3pFDaPtFAhUZkorrCa4I2Bkt+mZPtzlotXvFzZbBm7/9lJOIzbkzXw8w2v29OYbXL yojX/cnSEzSJpPreRzj0TEGZyJBWjhzOKtzThKjhh1sOypiIFZXuaNgR7BHWnK+WMdGtDquTBgI pKRJjisrS9PrVN7S9oGZXL8rtEByEpQq230RIteSWbzo6ncKNLCVaOGcnhLuyvMo9TO7zVXcZY/ 5wGIVrYjLsX9yEK1kwxCe70/2hxuHAjx24LvhJ6CRrgImKOKH8YEEtL2fm/4MVt7VDAvEbhKkfM l9LC40/XJPTPxPk3vregXd6PaKA== X-Received: by 2002:a05:620a:8014:b0:93f:4d4e:ff6b with SMTP id af79cd13be357-93f4d4f0025mr166738585a.12.1792477735785; Mon, 19 Oct 2026 23:28:55 -0700 (PDT) X-Received: by 2002:a05:620a:8014:b0:93f:4d4e:ff6b with SMTP id af79cd13be357-93f4d4f0025mr166737085a.12.1792477735360; Mon, 19 Oct 2026 23:28:55 -0700 (PDT) Received: from [192.168.68.120] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-48e1d80fdbbsm4094816f8f.17.2026.10.19.23.28.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 23:28:54 -0700 (PDT) Message-ID: Date: Tue, 20 Oct 2026 07:28:53 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: qcom: q6apm: Fix the wait for SHARED_MEM_UNMAP_REGIONS To: redducc , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Krzysztof Kozlowski , Ajay Kumar Nandam Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20261019161805.2427-1-sushmit718@gmail.com> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20261019161805.2427-1-sushmit718@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: RJZRw6R0Jsiy07sbvCYjiLos0GJgFw4D X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDIwMDAyNSBTYWx0ZWRfX+T982XA5cohQ wg1b50CLCadsVjFsHDWFL8KeEJthkZ5KHzVIm5MlzYGSFFZcT9EHXKUf+b4K7IsvmvA3U1vyL/q Crpe+QEj4XeSZykFluAxRnNX21d4is+dvxMlyDBLm5pIX+UdSqJhDGslOceA7HG9ARSO+hQ5zcd u5hQbE3mQfRYzNwhRJ3LwR+A+C7SaLrBfXWAFrHYDnlQR8y3SSBg8K841vTPwjPoENXty8zdg/R lnA4U0MJ85XSFvDayEnIJn/8wfpdi/pQYENP3J2RPJECAJ5GGEEItYqeYBbCV5WZWTH+/bVH80i t+v9pSjFnw/MfCw7EsqozkN8s4SjK5N0t1QAsi+6lM6yLCU+7fzZzNZcVde/J3Y1JlwUmr12IZI p2zD5SMscuB8eTkRNWhvirDhM0ZX12BIQdjBc7Ykgmm+0YKFloNJYAuAXcz57PMhlogtg2SfHx5 k8ZGliuzG8T7+21U3OA== X-Proofpoint-Spam-Info: AW1haW4tMjYxMDIwMDAyNSBTYWx0ZWRfX29IVCJXVjfhB QP71MfQ5GhASq0pitizKakH9RWx2cBnOU4NAKgqOzY+54zquTl+E/hRvdm+q3XxhwWEShsT6+oH Y8K/S7e04OQfIA51I86O1b5Pq4eCyis= X-Authority-Analysis: v=2.4 cv=LpcHWXdc c=1 sm=1 tr=0 ts=6ad70a28 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=MqWYEmV0nRCTjd50ys4A:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: RJZRw6R0Jsiy07sbvCYjiLos0GJgFw4D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-20_01,2026-10-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610190000 definitions=main-2610200025 On 10/19/26 5:18 PM, redducc wrote: > The DSP acknowledges APM_CMD_SHARED_MEM_UNMAP_REGIONS with a > GPR_BASIC_RSP_RESULT packet. apm_callback() stores the packet opcode, > GPR_BASIC_RSP_RESULT, as the result opcode, but > audioreach_send_cmd_sync() waits for the result opcode to match the > command, APM_CMD_SHARED_MEM_UNMAP_REGIONS. The wait never completes, > so every unmap blocks for the full 5 s timeout and logs > "CMD timeout". > > Store the opcode of the command being acknowledged, as the other > GPR_BASIC_RSP_RESULT cases already do. > > Fixes: 8ea6e25c8536 ("ASoC: qcom: q6apm: Add support for early buffer mapping on DSP") > Assisted-by: LLM > Signed-off-by: redducc This issue is already addressed in <20261016141153.1346219-1-shengchao.guo@oss.qualcomm.com> --srini > --- > sound/soc/qcom/qdsp6/q6apm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c > index b6b1ef6833b3..379b15b7e503 100644 > --- a/sound/soc/qcom/qdsp6/q6apm.c > +++ b/sound/soc/qcom/qdsp6/q6apm.c > @@ -960,7 +960,7 @@ static int apm_callback(const struct gpr_resp_pkt *data, void *priv, int op) > wake_up(&apm->wait); > break; > case APM_CMD_SHARED_MEM_UNMAP_REGIONS: > - apm->result.opcode = hdr->opcode; > + apm->result.opcode = result->opcode; > apm->result.status = 0; > rsp = data->payload; > > > base-commit: 6a56f4f29711dd2da49f03a5b99ce53779e638d7 > prerequisite-patch-id: 154550924ab1d2c1bc95517c058aaee0bb242f92 > prerequisite-patch-id: 22bca48e48813fb55976db043f9c35c926c61e3d > prerequisite-patch-id: cd21b1ff6a4fef14c706cea97fc906d7a0331b5c > prerequisite-patch-id: ce4057205dd2c2a6650c3a36c60664bd2737e202