From: Mario Limonciello <mario.limonciello@amd.com>
To: Qianfeng Rong <rongqianfeng@vivo.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
John Allen <john.allen@amd.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ccp - Remove redundant __GFP_ZERO
Date: Fri, 8 Aug 2025 11:22:42 -0500 [thread overview]
Message-ID: <d92b9a71-cccf-4e19-ae87-68627e16fc26@amd.com> (raw)
In-Reply-To: <20250808074426.214726-1-rongqianfeng@vivo.com>
On 8/8/2025 2:44 AM, Qianfeng Rong wrote:
> Remove the redundant __GFP_ZERO flag from kzalloc() since kzalloc()
> inherently zeroes memory.
>
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> drivers/crypto/ccp/hsti.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/hsti.c b/drivers/crypto/ccp/hsti.c
> index 1b39a4fb55c0..0ab3708951af 100644
> --- a/drivers/crypto/ccp/hsti.c
> +++ b/drivers/crypto/ccp/hsti.c
> @@ -84,7 +84,7 @@ static int psp_poulate_hsti(struct psp_device *psp)
> return 0;
>
> /* Allocate command-response buffer */
> - req = kzalloc(sizeof(*req), GFP_KERNEL | __GFP_ZERO);
> + req = kzalloc(sizeof(*req), GFP_KERNEL);
> if (!req)
> return -ENOMEM;
>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
next prev parent reply other threads:[~2025-08-08 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 7:44 Qianfeng Rong
2025-08-08 16:22 ` Mario Limonciello [this message]
2025-08-16 9:36 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d92b9a71-cccf-4e19-ae87-68627e16fc26@amd.com \
--to=mario.limonciello@amd.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rongqianfeng@vivo.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®