From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753970AbdBGLaW (ORCPT ); Tue, 7 Feb 2017 06:30:22 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:34969 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbdBGLaT (ORCPT ); Tue, 7 Feb 2017 06:30:19 -0500 Subject: Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set To: Colin King , Stephen Hemminger , "David S . Miller" , bridge@lists.linux-foundation.org, netdev@vger.kernel.org References: <20170207105638.17918-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Nikolay Aleksandrov Message-ID: Date: Tue, 7 Feb 2017 12:30:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170207105638.17918-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/02/17 11:56, Colin King wrote: > From: Colin Ian King > > The error check on err is redundant as it is being checked > previously each time it has been updated. Remove this redundant > check. > > Detected with CoverityScan, CID#140030("Logically dead code") > > Signed-off-by: Colin Ian King > --- > net/bridge/br_netlink.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c > index fc5d885..cdc4e2a 100644 > --- a/net/bridge/br_netlink.c > +++ b/net/bridge/br_netlink.c > @@ -612,9 +612,6 @@ static int br_afspec(struct net_bridge *br, > return err; > break; > } > - > - if (err) > - return err; > } > > return err; > Actually that code can be reduced further, I'll follow up with a patch later. Reviewed-by: Nikolay Aleksandrov