From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3553204587 for ; Tue, 14 Jan 2025 18:39:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736879958; cv=fail; b=ibEH1rZFZTkhD7gur6tDxnGRq2vVYA0/EEtxhHYW6r2CHojUqHp1tVFuwLOMnXbfaFRoK6MZIsj1jijzmBmXcuqnOhFqMydegzalWHI+Tk/6loFdvX3yzdjqoLsNIkP0qOO2LMwh6c5XCklHgtgYsw6sB3iI5SK7KJMZAolDJNk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736879958; c=relaxed/simple; bh=zYNnxb+rBrE2+oUpjcanV17fCRRpbtDab2uzGS/5PYU=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=sUyFB11Uw0LVlBiFEyZ1ZKG/CUBtQ6JImNFCkV0I4ptB21It7Wrl0vo1GincDnt41NhUzuHhe8E0S068nm/09fuhJetaI870selGq3O4ZtvZxrFcdy5y0qFiSutT+3XvyQJJNAHJasIATb99V7jxVMKb6w59f0tm4zmAlCTwwqs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=fLX8FhZG; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=jwgxqsfg; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="fLX8FhZG"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="jwgxqsfg" Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50EIXrRN032564; Tue, 14 Jan 2025 18:38:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=zYNnxb+rBrE2+oUpjcanV17fCRRpbtDab2uzGS/5PYU=; b= fLX8FhZGp3TfDemzxdYBPqOOXuET19cUp/xmNAHrTJSzU97l2FXEXIkyVN+5Hckf IHZyuL7rbvaf8m9NRPnpD8QvnAlNoKew8wHxbkCLeNxi6AUCELuAO+Mcu0clhVKU vGqHvBnY3FPjeZtONxvJjptbw7ehF7CZGRH6SwMMhkBlKmq8FziWouEcuVxwzXI8 IHkzlwEoXY9BgkzG1FjNKdjjjesuunumUB4blWxDKGVmbn0bxiS0HBF/5l0AFmjE oCKR6y46d+1TpJ7wnChi+KVYoDkAI1VXE+4KuqdbL7IIz5YyYnHSEJ6qP2WIPIWe 1FET1H3E+0ifSH/fD6aaVA== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 443f7y6bsu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Jan 2025 18:38:55 +0000 (GMT) Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 50EHBuTM035016; Tue, 14 Jan 2025 18:38:54 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2045.outbound.protection.outlook.com [104.47.73.45]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 443f38gg66-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Jan 2025 18:38:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=evyD6YriloHBxg1TsDEDcz/BWQA7F7xRKmgIRwHgs4v11YR5koL5fdTQZ5Qu75cydoEQt7L9VWD4neiC7Z+sg1gltNnFxcLfGwjbI/I0dlSICkwCeAtC3UAinZFzWltN+SkvFHu+hoUpGnoxnf1UHVOo2HBbkIn0JV6lkinZ0a68BsB1eTHouKZb3b+CLTJ0UP2auJju6yL9Ti2u0PtPKWrFjIhVxH/5moJV9UahQAsFmwDOvNlMoy0WAz/rY221ZiYZ+/X0x9FIRdUQj+Tsd+SreecSTF4w4VLLZyM1aT07TyQ1QMr4NqSkDoVXwyvx8FrQJOnoMgFVWOAqU7i73g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zYNnxb+rBrE2+oUpjcanV17fCRRpbtDab2uzGS/5PYU=; b=o40NETzch+QoQjhZYlXuJxLBC9XOh4oYTeWqC09ao7VLpzq6NM8b+J1taXzBjcf40f5KgRYoDmj+EXkK+1cHfNDZ2BYYTW9Sucgfm3W5ihdD54k05S3Hev+nH94aqTyFofV1IZWtE0GSAijAGzP/q/t+j+yC6TqUUEP3riH6nOpoOnOh15JQ2HPBoDB62X6YBIFF5XY5tk0cC9tDd0ezvcwta8ysgKCjcQO+J+xRbv0Bi2xDTK4g5Qi2vpZ0BiypxXw/xeHM0E3vexPCInroQRhg5xGXu3lpxVO2lYnjz0tBIA8Sj02fd640Uc++ZoCXpbcePQ8wff7TBrpiEAA0NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zYNnxb+rBrE2+oUpjcanV17fCRRpbtDab2uzGS/5PYU=; b=jwgxqsfgdQh1K4iHrRoLNCkaySbu+vXmN9r2tYP4oihPv6tsDB0UKYPhUiU2C+7UMS4i4rihcPPltphUtTlvq21UsfBlREJDANbqHdN52PjxgRLsFzDibLxXl7+af8znbj7cZftxRu35JdyXhjG29/qmhBleLxhFXIBU7Y8cg2g= Received: from BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) by BN0PR10MB5013.namprd10.prod.outlook.com (2603:10b6:408:120::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8335.19; Tue, 14 Jan 2025 18:38:51 +0000 Received: from BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9]) by BYAPR10MB3366.namprd10.prod.outlook.com ([fe80::baf2:dff1:d471:1c9%4]) with mapi id 15.20.8335.017; Tue, 14 Jan 2025 18:38:51 +0000 Date: Tue, 14 Jan 2025 18:38:49 +0000 From: Lorenzo Stoakes To: Jann Horn Cc: Yang Shi , arnd@arndb.de, gregkh@linuxfoundation.org, Liam.Howlett@oracle.com, vbabka@suse.cz, willy@infradead.org, liushixin2@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] /dev/zero: make private mapping full anonymous mapping Message-ID: References: <20250113223033.4054534-1-yang@os.amperecomputing.com> <2dda50aa-e4a1-4664-b8fa-56ba975db329@lucifer.local> <65691afc-615a-4716-8a2e-1f43bc65111c@os.amperecomputing.com> <3fdcd6a5-27fe-411b-923c-b7410e4cbda9@lucifer.local> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P265CA0073.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::6) To BYAPR10MB3366.namprd10.prod.outlook.com (2603:10b6:a03:14f::25) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB3366:EE_|BN0PR10MB5013:EE_ X-MS-Office365-Filtering-Correlation-Id: 1102bbf4-101a-465f-14cc-08dd34cab135 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VEY3MjVRU3RvZUNvQklLMXNMbFYxMXoxRmtqZlE4bWhuRVNUMTMvdjNkZThk?= =?utf-8?B?SnhTbS8zOHlHZ3Y4REJ2MGRpM0t6bldQNERFQUhlWUE5alNlUWErZzA2TExY?= =?utf-8?B?TEZRZStVck0vT0tPaFNhZG9qK3VyVXIzb1FnTmJUV1doOU5tV1oxdmpEdHpN?= =?utf-8?B?S2t4UjgxazhGQ2JWV1pJekhldElpREc0VWpNeW11VXU2SjNBbGpWc2xaVlJI?= =?utf-8?B?MTIrN255aUJQbitQbGhZV0N2UkdBNEdEUmx6Mm52eVNDVWRBM3kwNFF6NDM1?= =?utf-8?B?ZE1aR2V1WS9MUDFLSFp0azVrVnJzT2lyWkRHNmFqV1M4V09kSktvWElNN0ZU?= =?utf-8?B?d3kzZHdndGFHR09Dd3I2eUtGcGpkSU9uL0plSU0zL1loZ2lubjlaMVdsNEt5?= =?utf-8?B?MzFjUHJidjJBblNlR2RobG0zTnBlSi9FbmlaRmo5N0pVNWlpKzA1L0tLbVky?= =?utf-8?B?V2lFWmR4L0JORTFQdmNBYWJSRGNaWC9SNkdFend0KzBwM20vUldpTm1CREZC?= =?utf-8?B?OUUxMVA5VTUxa2tHakZLZ1ZhSGs1OUxDZWxvelZna1hzQk9mUlBiVVM1eTB6?= =?utf-8?B?eWJJOXZVMGJ4YTVSaENhUFlObnM1dXJ1K04zY2dJMXBRT3hFdXdjU1FseFRk?= =?utf-8?B?VmthdVhLYlNTSElxSTBZd2xQTm9nT09iTkZZbUZNaEp2bmVZWHJxRmZTcEQx?= =?utf-8?B?Vk9sVlV5VWVUQTU4QWFHMWNuZ3NQSUVLSVhRZ054aVUvTGdwUzFad0YxNUdq?= =?utf-8?B?aW5OUjJDaXNPaVc1eVhrNGNuRnNWU0FGdkhiSHNHcmVYeDlLeXdNc1hPNWZw?= =?utf-8?B?NU12MU82MS9IdW5FTmUwUGNqWUw0cElONHJtcHFiZ2luKzlsenh5cHl4Q3Ju?= =?utf-8?B?Mzg1TlcwcmFsaVV2azhxeG5XSU16cjFMeDVtV3FrNWRNd0RHb2Fod1dKSWg3?= =?utf-8?B?N1pCVENVTHY1a21VR1l4Q1pCYmJtT0duLzRhMFQzLzQ5djZKN0IzejkvT2lR?= =?utf-8?B?dUhoaFF4elBLbTRLYTE0YjBqeUVuSXZuVFpOdzVRWjEveWJJVElQTEduVGM1?= =?utf-8?B?dHBNdUYwcnVQSGZhSzFsUlFlak55dzgweWJvSFp5N2U1TE1rS21vWW90WFY5?= =?utf-8?B?blJBQXhUWTl0Qy9NcWtFVElLWG5ObXFhaDRrcGZBalZRVEFQU2dFdVAyQnB0?= =?utf-8?B?dE4va0o5TytlYTQ2c2dORGhXREpuMFZXUUFvaTZQN0hBem9RVU1jVkQvbXlC?= =?utf-8?B?bzVBYnJKNGo2dDlLcWlVWU9Gek1nVjkvVDRZMkRjK3RkdThVY0JyVjlxSW94?= =?utf-8?B?VXV2aG5pUFRhZkhxR29wM2c4cGljaDJhU3diWStZTUJDUHZzUU9TUWZmdEtE?= =?utf-8?B?NXZPSzFaTHBMdFVNbEdjVzBlVVRRRFBjYjFObUFQTVlPbVFCa25YVUtGaEJN?= =?utf-8?B?VWYyZnhDQ2drOWR4YitxZklLa1VVWGR0d1RRNzhLczlOZnk2cXhCbFJkSXBW?= =?utf-8?B?ZWlua0Rtbm1VaVNBRG1sKzRuMGV3emJQYllTYXJNMy9La0kyRWdtY0MyUnBC?= =?utf-8?B?KzZpYS81NXR6cHFJbitQKzVpYnV2ektjSVBFU3JMeHdvc1FRSDBhUHZIMkxo?= =?utf-8?B?OGlyeG0vZXlSeCtxNWFoZEZLUUt5bVdVdG9JZDE4OTZkVk5nNmdKUllub0gr?= =?utf-8?B?NENrYjY3aWhmc3gwcnE0Y0NSVzMxYjdwb2FBUEMxUDdXRnUrY1hkS3k5UmJS?= =?utf-8?B?ekRjWU1QL2cyNFFJRjZSb2lwUkRSdUZ4MmczWDVzSXowdDRTQjhrT0FZcyti?= =?utf-8?B?ak9KY2FLdTJMWGNtR3BaN21sODliaUpkd082cnIyWlhKc2NRWkVISzlHWWd6?= =?utf-8?Q?BtfuajwcbQxMv?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB3366.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SHV3MnRVUGZpWXZoa055MkFIZ1hOTm1ldm05UnRCdHVrWjJ6TE8wTHZlMG9Y?= =?utf-8?B?WkdQNklSS3laOEZzcWxWMCtxL3QrYWV6UFQ2WmpwUjl0a2dCOUxqektyVlcz?= =?utf-8?B?Q0RQU3VtYStzY2tlNWlHTXBjdzVkWmIrdVFVdE5iVXRjTzhndHVORjV3TDA4?= =?utf-8?B?VVlzWmFmYjI0YXFTR1dJK0pJMm9na0U3SHdKbFQwQmZ1bmJySHU5elpMQmFn?= =?utf-8?B?cDFFTHBMazZxZ0d6UjltN0NkVEtZTzFDVUk5QUlnVXNqR2NsbFNpTHhVa2l2?= =?utf-8?B?Y0hpc28yZ0FjTmNqUGJhdSt6OHJOZ3RaTGVhZ3NZaWJ3UUUvd2J4dGRiNFBJ?= =?utf-8?B?Y2cyWTM3TmRnaVUzZjJTUFI4VWJkbTgyS01MMWliUFFXRkFXaHhFNlJZcGZF?= =?utf-8?B?bW9scDNkMEJZcWtwazhJVE5GVnY5dHVvYzBnaW1XcEkxS3dJY0dFc1QxWE5S?= =?utf-8?B?UUpqcWhVdDVpY2s4VUtjczVkYzdoSUJybWt5aU5kTXh0VUFZa1JMQmxXS3RU?= =?utf-8?B?V2hCN05kVlBUVVF2Vkl6Mlk0QVhzeDQrU3BNNEoxMDVJMVlyTHhRaGVrcVhL?= =?utf-8?B?RUhtQitmSUJ3bHk0OVdjbVBMTitGL0IrVDNGZFRVWjFTdGlha0d3N2pCVjhx?= =?utf-8?B?eGlCaTVYREdxZ1lGaUx0SUhFQ1U5RWgyZnIvNWNUUEp4c1JJeVlhaHJQZ0J2?= =?utf-8?B?eXljVmZuTVQ5MUpNMnlDa2tXUy8wR3ZOMlNtdGtuaTk2TWtxSW5tSHB2bDZE?= =?utf-8?B?QWU2dXlnS005aEppQjl0TTZjQjlzZGF5SG0xa2ZFdTh2bHRoZ2FVRnROd3lC?= =?utf-8?B?NDd3UUFkOWswS08zbnB3aEVrOXVoNWNHSWEveWFEUk04djNpTHJIS0NOWFAy?= =?utf-8?B?enZTNXA1Ni9hWE1mWWd5SVFCa0k1UTNuZmZEeVc5amV3OXEyK1l3eHV3Ukx6?= =?utf-8?B?dzlSOHEyNDV5elhjWE5ta0tNZHg5QkVTeTcyTk4zdnJqcForczhLUXZnb3Uy?= =?utf-8?B?Y2VSc2dBNW84azNwMXFNRnZtZW53ZS9oL1JaVzg5WjFYTlk5Ukt0Mmp3NXdD?= =?utf-8?B?N05Xc3hhWHNudWhiVzZlSzN1U0UxellJckV5K3JhemZQZWlaU1pFY0dpeTJr?= =?utf-8?B?SzJqL1FpbytWNXlzZ0RkQVh1L2ZvV0VqOGJNaWVFQUF0YnBqMTJIRW9scFpK?= =?utf-8?B?Ym5mamZWSEVRZE9EcldZOUt3UkxWYjh6Y1FmRVBzblg5aFlMallhaXpEbnBt?= =?utf-8?B?Z3RGTDhtSHhmdERyVEM2RlpwVm9weFhqMG5iZElSd0VKdWw0WjBmMDlxVUZW?= =?utf-8?B?c0tKYVhFVFpCSFdvcFZKK1dGUkZmblcrd05tdzNVTzdnZVBEdCtmOUYySE9L?= =?utf-8?B?U1VlcXFza3FER1FWOWZFVXoyNUpZL3ZVV293aEZIUnZiR3pRU1o5Y2lQTFU1?= =?utf-8?B?Yk55T3M3dk0zZFJ5SitwTmlGY0VYM1NZNG1YZkJ2Ty9rZE90UWxOOTJSODhY?= =?utf-8?B?S0hVaThKL1NoZnJ5U2JPbXpyMkRaSTA1RTJkeTdJZFVPM3J5dmVXZ0x4UUUv?= =?utf-8?B?bGNVTWdTc0lLaFlDb1l6cGhoY2FtRkxvcGVBNnBsUlozWTNSYXVUQTNRZ2pa?= =?utf-8?B?cGQ1NVZLaWQwU0x1aFk2WktpaW0zVXZYOXBXNUxJNlB6Z1dtQ1REa1lDTVUz?= =?utf-8?B?cDdOMmRaaEVaZThTMkQrT1FWN3JBeUhoelowcm53ZS9FTzNVd0lBMWRTWnBI?= =?utf-8?B?VE5mWlVuZnNQYmhQNlA5OHZZdGswZGtlYS9EUzc5YzFQS05pek1WNGkvenpu?= =?utf-8?B?UFQ2dCtrUmpJV3libTRZZWJZdC94Zlo0NXFMcjlIMTZHSnBEQ29QcmZqTTlX?= =?utf-8?B?TWlMOFlJZU41NmlNQ3VjbWJjNzNWNDkvd0lndEJaSlIvTlJ1eWgyNVZoUEpB?= =?utf-8?B?SUo0eU90NU9DWGVDQXNVL0ZDaFlnb3l6a29kZWcyck5iU2RQSjlkR2hFQnhD?= =?utf-8?B?djJlTDFPazV2SXY0TEhRQ29ZQ2pUY0xtK0hEY3BwcGU5c2phUUVoSjQ3RURm?= =?utf-8?B?QUtIWVVZd1hSbXRmYTV1VFo4ZndPcWQrRFNSUW9vaEE3RzN1dzZucDdqTUY4?= =?utf-8?B?S1o0aUlqTzhuaGFYNld0d3NlNnpORnA5bUU1ZWsxZzdncDNSQXN6M2l6ZXBH?= =?utf-8?B?NVE9PQ==?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Ww3BrNWazX90qqBcbx8lFOnB2kR54LOviKChggmxIuNvkow1+adBS6fvPU6r4fkmZWqKfJPwz9HamBP57brp5pVdQmPecA2rvmJTDot+eB4LkhkLqcIouHSicxV1VDcC5u/aocPv594+wLFrGAtZhR4x9f8kHDNALKNaA6A2u4RJsWe/HJ60fHolbOKW+FoMvqY+MTHQST9xFTZyc40db4yJvJu8E4mdVj2ktF1SBsp2N+qCmRoBvM0ZYHtnaT9vfRYuXobKMjCVKPO6Hzv6ktfWJ0AEyExku+dDJvMUlDWZuzUHckYdbQGiNDFVUCQzkI2RjlSOXSHXElT2YSeyeXHFY5ORVTju14gzUuqeGWXU+BW0AM2AUt1N2EfbSU5T08Vt1A7xYjc3d91I8rA6+7wo8DoZitq0Aw+rMlzzqF4sITBS9pgQpO23iHN9zw4RJRRg/hezcx1h9X2vvBUivCJM1ie2gY5XKSRi2drmLXEoOho8O/VFbnnpVnG2nY2FB15KyRq4VVd5U2wY5jlUfFeM56TciXF7o5i1hZ10rSRLKyndMOaFTfvQ8FLSmQfL1u/6wSL/+JDukQKVRA5DLFOkR1KQWkyQoTNL1LqkM3M= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1102bbf4-101a-465f-14cc-08dd34cab135 X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3366.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2025 18:38:51.8360 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N09J4vxj2TW+st1Hhp7aCdFc/qgYsbB/pvNUjJd2VHVyFa2g0BML0hgGK84qcI2OnbYfKG3n9xfbQdlUZrUIhweLf1Fq5haksw3GuMIw/W8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5013 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-01-14_06,2025-01-13_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2411120000 definitions=main-2501140142 X-Proofpoint-ORIG-GUID: -8f43T3KuZ09lY_-Z4SWzF_qLK89smKJ X-Proofpoint-GUID: -8f43T3KuZ09lY_-Z4SWzF_qLK89smKJ On Tue, Jan 14, 2025 at 07:32:51PM +0100, Jann Horn wrote: > On Tue, Jan 14, 2025 at 7:15 PM Lorenzo Stoakes > wrote: > > On Tue, Jan 14, 2025 at 08:53:01AM -0800, Yang Shi wrote: > > > On 1/14/25 4:05 AM, Lorenzo Stoakes wrote: > > > > On Mon, Jan 13, 2025 at 02:30:33PM -0800, Yang Shi wrote: > > > > > + fput(vma->vm_file); > > > > > + vma->vm_file = NULL; > > > > > + vma->vm_pgoff = vma->vm_start >> PAGE_SHIFT; > > > > This is just not permitted. We maintain mmap state which contains the file > > and pgoff state which gets threaded through the mapping operation, and > > simply do not expect you to change these fields. > > > > In future we will assert on this or preferably, restrict users to only > > changing VMA flags, the private field and vm_ops. > > > > > > Hmm, this might have been mremap()'d _potentially_ though? And then now > > > > this will be wrong? But then we'd have no way of tracking it correctly... > > > > > > I'm not quite familiar with the subtle details and corner cases of > > > meremap(). But mmap_zero() should be called by mmap(), so the VMA has not > > > been visible to user yet at this point IIUC. How come mremap() could move > > > it? > > > > Ah OK, in that case fine on that front. > > > > But you are not permitted to touch this field (we need to enforce this...) > > Sidenote: I think the GPU DRM subsystem relies on changing pgoff in > some of their mmap handlers; maybe talk to them about this if you > haven't already. See for example drm_gem_prime_mmap() and > dma_buf_mmap(). Thanks Jann , I feel like I've opened up a can of worms with this :) I will note these as things to prioritise in the audit. It might be worth both auditing and then actually doing the change to restrict what can be done here too. The problem is it requires changing a trillion callers, but hey I'm Mr. Churn after all... ;) Sorry Yang - I realise this is a pain and not at all obvious. Something we in mm need to sort out (by which I mean _me_ :) your contribution and ideas here are very valued!