From: Waiman Long <longman@redhat.com>
To: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org, Juri Lelli <juri.lelli@redhat.com>,
Cestmir Kalina <ckalina@redhat.com>,
Alex Gladkov <agladkov@redhat.com>, Phil Auld <pauld@redhat.com>,
Costa Shulyupin <cshulyup@redhat.com>
Subject: Re: [PATCH wq/for-6.9 v5 0/4] workqueue: Enable unbound cpumask update on ordered workqueues
Date: Thu, 8 Feb 2024 14:33:50 -0500 [thread overview]
Message-ID: <d9319087-1e97-4a55-aaed-dbce8fe3b0f7@redhat.com> (raw)
In-Reply-To: <ZcUq3VnputFml3LK@slm.duckdns.org>
On 2/8/24 14:26, Tejun Heo wrote:
> On Thu, Feb 08, 2024 at 11:10:10AM -0500, Waiman Long wrote:
>> v5:
>> - [v4] https://lore.kernel.org/lkml/20240207011911.975608-1-longman@redhat.com/
>> - Streamline patch 2 by simplifying unplug_oldest_pwq() and calling it
>> only in pwq_release_workfn().
>>
>> v4:
>> - [v3] https://lore.kernel.org/lkml/20240205194602.871505-1-longman@redhat.com/
>> - Rebase on the latest for-6.9 branch again & discard the use of
>> __WQ_ORDERED_EXPLICIT and resetting of __WQ_ORDERED.
>> - Add a new patch 1 to change the ordering of pwq's in wq->pwqs from
>> oldest to newest.
>> - Change the terminalogy from freeze/thaw to plug/unplug.
>> - Allow more than 2 pwq's in wq->pwqs of ordered workqueue but only the
>> oldest one is unplugged. This eliminates the need to wait for
>> the draining of extra pwq in workqueue_apply_unbound_cpumask().
>>
>> v3:
>> - [v2] https://lore.kernel.org/lkml/20240203154334.791910-1-longman@redhat.com/
>> - Drop patch 1 as it has been merged into the for-6.9 branch.
>> - Use rcu_access_pointer() to access wq->dfl_pwq.
>> - Use RCU protection instead of acquiring wq->mutex in
>> apply_wqattrs_cleanup().
> Applied the series w/ (w/ the updated second patch) to wq/for-6.9.
>
> Thanks for working on this. It's really great that this got solved finally.
Me too. Thanks for all the good suggestions that you had given me as I
don't have a full understanding of all the different pieces of the
workqueue code.
Cheers,
Longman
prev parent reply other threads:[~2024-02-08 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 16:10 Waiman Long
2024-02-08 16:10 ` [PATCH wq/for-6.9 v5 1/4] workqueue: Link pwq's into wq->pwqs from oldest to newest Waiman Long
2024-02-08 16:10 ` [PATCH wq/for-6.9 v5 2/4] workqueue: Enable unbound cpumask update on ordered workqueues Waiman Long
2024-02-08 17:42 ` Tejun Heo
2024-02-08 16:10 ` [PATCH wq/for-6.9 v5 3/4] kernel/workqueue: Let rescuers follow unbound wq cpumask changes Waiman Long
2024-02-08 16:10 ` [PATCH wq/for-6.9 v5 4/4] workqueue: Bind unbound workqueue rescuer to wq_unbound_cpumask Waiman Long
2024-02-08 19:12 ` [PATCH wq/for-6.9 v6 2/4] workqueue: Enable unbound cpumask update on ordered workqueues Waiman Long
2024-02-08 19:26 ` [PATCH wq/for-6.9 v5 0/4] " Tejun Heo
2024-02-08 19:33 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9319087-1e97-4a55-aaed-dbce8fe3b0f7@redhat.com \
--to=longman@redhat.com \
--cc=agladkov@redhat.com \
--cc=ckalina@redhat.com \
--cc=cshulyup@redhat.com \
--cc=jiangshanlai@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pauld@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®