Re: [PATCH V1 3/3] dt-bindings: tegra: clock,memory,thermal: add header Copyright

[Bitan Biswas <bbiswas@nvidia.com>]

Hi Krzysztof,

On 9/21/21 2:47 AM, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
> 
> 
> On 21/09/2021 11:42, Bitan Biswas wrote:
>> Add Copyright for below Tegra dt-bindings headers:
>> 1. clock
>> 2. gpio
>> 3. mailbox
>> 4. memory
>> 5. thermal
>> 6. reset
>> 7. pinctrl
> 
> Why? Please explain.
> 
> These are trivial constants, so I doubt there is here any copyright value.
> 
You may see I was adding the missing Copyright of files created by 
Nvidia developers in past. I have not evaluated the copyright value of 
the contents added in the initial check-in. As suggested, I plan to drop 
this patch in any further revisions of patches from this list.

>>   include/dt-bindings/reset/tegra210-car.h            | 4 ++++
>>   include/dt-bindings/thermal/tegra124-soctherm.h     | 4 ++++
>>   include/dt-bindings/thermal/tegra186-bpmp-thermal.h | 4 ++++
>>   include/dt-bindings/thermal/tegra194-bpmp-thermal.h | 4 ++++
>>   22 files changed, 104 insertions(+)
>>
> 
> (...)
> 
>> diff --git a/include/dt-bindings/memory/tegra30-mc.h b/include/dt-bindings/memory/tegra30-mc.h
>> index 930f708aca17..4972cf7e3cf2 100644
>> --- a/include/dt-bindings/memory/tegra30-mc.h
>> +++ b/include/dt-bindings/memory/tegra30-mc.h
>> @@ -1,4 +1,10 @@
>>   /* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Copyright (c) 2014-2021, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
>> + *
>> + * Author: Thierry Reding <treding@nvidia.com>
>> + *
> 
> I am sorry, but that's not entirely how it works. You cannot add only
> selected (stripped) copyrights backwards. If adding, please include all
> copyright holders.
> 

I had emailed the authors(outside Nvidia) asking about additional 
Copyright to add, but did not get response from all. One author was fine 
with adding the Nvidia Copyright. I see now Copyright backwards needs us 
to follow above approach. As mentioned above in my reply to your 
comments I am planning to drop this patch if sending subsequent 
revisions in this patch list.

Thanks for the inputs.

-regards,
  Bitan